sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Desruisseaux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SIS-179) Extract Database class from Shapefile class to allow reading DBF without shapefile
Date Tue, 07 Oct 2014 01:43:34 GMT

    [ https://issues.apache.org/jira/browse/SIS-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161344#comment-14161344
] 

Martin Desruisseaux commented on SIS-179:
-----------------------------------------

Maybe {{org.apache.sis.storage.database}} is a too generic package name for a code which is
specific to the DBF3 format? Some alternatives may be:

* Keep {{Database}} and related classes in {{org.apache.sis.storage.shapefile}} for now, if
possible as package-privated classes.
* Or alternatively, but them in a {{org.apache.sis.internal.storage.dbf3}} package. Note the
{{internal}} in the package name - those packages are hidden from public API. The reason for
that is that JDBC drivers usually expose only their API through JDBC interfaces, and try to
hide their internal mechanic from the user as much as possible.

Note that the {{sis-shapefile}} module has significant dependencies, like {{sis-referencing}}
(to be needed for parsing {{.prj}} files). The weight of those dependencies may discourage
some peoples to use {{sis-shapefile}} for reading plain DBF3 files. Maybe some users would
be more interested in having a copy of the code for the DBF3-only part in a separated, lightweight
project. However having the DBF3-only part in a separated package may make such separation
easier.

P.S.: If possible, I would like to get ride of {{CodePage}} class since I think it duplicates
{{java.nio.charset}}.


> Extract Database class from Shapefile class to allow reading DBF without shapefile
> ----------------------------------------------------------------------------------
>
>                 Key: SIS-179
>                 URL: https://issues.apache.org/jira/browse/SIS-179
>             Project: Spatial Information Systems
>          Issue Type: Improvement
>          Components: Features, Storage
>    Affects Versions: 0.5
>            Reporter: M. Le Bihan
>            Priority: Minor
>         Attachments: DataType.java, Database.java, FieldDescriptor.java, ShapeFile.java,
package-info.java
>
>
> Extracting the DBF binary reader from th Shapefile class to a Database class allows the
loading of a DBF file when it is not accompanied with a shapefile.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message