sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1617591 - /sis/branches/JDK8/core/sis-metadata/src/main/java/org/apache/sis/metadata/PropertyAccessor.java
Date Tue, 12 Aug 2014 21:20:52 GMT
Author: desruisseaux
Date: Tue Aug 12 21:20:52 2014
New Revision: 1617591

URL: http://svn.apache.org/r1617591
Log:
Added a minor design note in comment.

Modified:
    sis/branches/JDK8/core/sis-metadata/src/main/java/org/apache/sis/metadata/PropertyAccessor.java

Modified: sis/branches/JDK8/core/sis-metadata/src/main/java/org/apache/sis/metadata/PropertyAccessor.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-metadata/src/main/java/org/apache/sis/metadata/PropertyAccessor.java?rev=1617591&r1=1617590&r2=1617591&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-metadata/src/main/java/org/apache/sis/metadata/PropertyAccessor.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-metadata/src/main/java/org/apache/sis/metadata/PropertyAccessor.java
[UTF-8] Tue Aug 12 21:20:52 2014
@@ -146,6 +146,13 @@ class PropertyAccessor {
      * {@preformat java
      *     type.isAssignableFrom(implementation);
      * }
+     *
+     * <div class="note"><b>Design note:</b>
+     * We could enforce the above-cited restriction with type parameter: if the {@link #type}
field is declared
+     * as {@code Class<T>}, then this {@code implementation} field would be declared
as {@code Class<? extends T>}.
+     * However this is not useful for this internal class because the {@code <T>} type
is never known; we have the
+     * {@code <?>} type everywhere except in tests, which result in compiler warnings
at {@code PropertyAccessor}
+     * construction.</div>
      */
     final Class<?> implementation;
 



Mime
View raw message