sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1599787 - in /sis/ip-review: ./ rev/06477/ rev/06606/ rev/07862/ rev/20874/ rev/24485/ rev/24925/
Date Tue, 03 Jun 2014 20:28:33 GMT
Author: desruisseaux
Date: Tue Jun  3 20:28:33 2014
New Revision: 1599787

URL: http://svn.apache.org/r1599787
Log:
Added IP review for AbstractMathTransform.

Added:
    sis/ip-review/AbstractMathTransform.xhtml   (with props)
    sis/ip-review/rev/06477/
    sis/ip-review/rev/06477/AbstractMathTransform.xhtml   (with props)
    sis/ip-review/rev/06477/HEADER.html   (with props)
    sis/ip-review/rev/06606/
    sis/ip-review/rev/06606/AbstractMathTransform.xhtml   (with props)
    sis/ip-review/rev/06606/HEADER.html   (with props)
    sis/ip-review/rev/07862/
    sis/ip-review/rev/07862/AbstractMathTransform.xhtml   (with props)
    sis/ip-review/rev/07862/HEADER.html   (with props)
    sis/ip-review/rev/20874/AbstractMathTransform.xhtml   (with props)
    sis/ip-review/rev/24485/AbstractMathTransform.xhtml   (with props)
    sis/ip-review/rev/24925/AbstractMathTransform.xhtml   (with props)

Added: sis/ip-review/AbstractMathTransform.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/AbstractMathTransform.xhtml?rev=1599787&view=auto
==============================================================================
--- sis/ip-review/AbstractMathTransform.xhtml (added)
+++ sis/ip-review/AbstractMathTransform.xhtml Tue Jun  3 20:28:33 2014
@@ -0,0 +1,98 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractMathTransform history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractMathTransform history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/AbstractMathTransform.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31593</td><td>2008-09-25</td><td>desruisseaux</td><td>Bug fixes: 1) wrong field set in metadata 2) missing conversion between float[] and double[] array.</td></tr>
+<tr><td class="rev">31567</td><td>2008-09-22</td><td>desruisseaux</td><td>Fixed GEOT-2046. Patch submitted by Tara Athan.</td></tr>
+<tr><td class="rev">31547</td><td>2008-09-18</td><td>desruisseaux</td><td>Anticipating GEO-143.</td></tr>
+<tr><td class="rev">31486</td><td>2008-09-09</td><td>desruisseaux</td><td>Documentation adjustements (no code change).</td></tr>
+<tr><td class="rev">31000</td><td>2008-07-10</td><td>desruisseaux</td><td>Avoid usage of 2 deprecated constructors from CRSFactory. Their replacement were tricky and required more sophesticated code in ReferencingFactoryContainer.toGeodetic3D.</td></tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations in the process.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30639</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: cleanup library/referencing</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update referencing headers</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29955</td><td>2008-04-17</td><td>desruisseaux</td><td>Added a paranoiac check for CRS.transform(CoordinateOperation, ...) working on envelopes crossing axis extremums. Fixed a NoSuchElementException in MosaicImageReader when the requested region has no tiles. Fixed a NullPointerException in MosaicImageWriter when the allowed memory is smaller than the area of the smallest tile.</td></tr>
+<tr><td class="rev">29711</td><td>2008-03-25</td><td>desruisseaux</td><td>In MapProjection, provide more information in the logged warning (especially the projection name) in order to compensate for the loss of stack trace. In subclasses, replaced "Math." occurences by a static import for readability (there is a lot of sin(x), cos(x), sqrt(x) etc. calls in those classes). Also replaced sqrt(x*x + y*y) by hypot(x,y) and (exp(x)-exp(-x))/2 by sinh(x) which are new functions in Java 5 (hopefully more accurate and/or faster). Applied some Java 5 language syntax (generic types and @Override annotation).</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28846</td><td>2008-01-20</td><td>desruisseaux</td><td>Covariant return type for inverse() method in MathTransform1D and MathTransform2D. Also javadoc fixes and Java 5 type safety. Changed ViewType to an enum and initial implementation of GridCoverageViews (not yet connected to GridCoverage2D).</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28393</td><td>2007-12-17</td><td>desruisseaux</td><td>WKT formatting now includes the semi-major and semi-minor axis length if they differ from the datum. Applied Java 5 features. Uses WarpAffine when applicable during Raster reprojection.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a href="rev/24925/AbstractMathTransform.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">24510</td><td>2007-02-19</td><td>desruisseaux</td><td>Moved 'isIdentity(double tolerance)' method from AbstractMathTransform to LinearTransform interface.</td></tr>
+<tr><td class="rev">24493</td><td>2007-02-17</td><td>desruisseaux</td><td>Cleaning in 'isIdentity(double)' methods. Note that AbstractMathTransform.isIdentity(double) may move in the LinearTransform interface, so we are marking them as deprecated for now and will create a new LinearTransform.isIdentity(double) method in a next commit.</td></tr>
+<tr><td class="rev">24485</td><td>2007-02-16</td><td class="unav">simboss</td><td><a href="rev/24485/AbstractMathTransform.xhtml">-first bunch of changes for the alignment of trunk with 2.3.x</a></td></tr>
+<tr><td class="rev">23632</td><td>2006-12-29</td><td>desruisseaux</td><td>GEOT-859: Refactored the URN syntax adapter for CRS factories. The adapter now apply to any factory. Some progress toward version management (but not yet there). NOTE: this new implementation forces axis order "as specified in the database", which is different from the original "URNEPSGAdapter" implementation which used (x,y) order. Various changes in many corners of "org.geotools.referencing.factory" as a side-effect of this work. Minor opportunist javadoc fixes in other modules.</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">22126</td><td>2006-10-14</td><td>desruisseaux</td><td>Rolled back to non-static inner classes, now that the Clover bug has been fixed (as for maven-clover-plugin 2.3, released recently).</td></tr>
+<tr><td class="rev">21780</td><td>2006-10-03</td><td>desruisseaux</td><td>Removed methods from the referencing module that were deprecated in Geotools 2.3. This imply the replacement of 'CRS.transform' by 'CRS.findMathTransform' in the whole Geotools code base.</td></tr>
+<tr><td class="rev">21289</td><td>2006-08-30</td><td>desruisseaux</td><td>First working version of ESRI authority factory. However, the fallback mechanism is not yet in place, and the corresponding test suite in plugin/epsg-ext-esri doesn't work yet (GEOT-774).</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/AbstractMathTransform.xhtml">ip review</a></td></tr>
+<tr><td class="rev">20756</td><td>2006-07-30</td><td class="unav">aaime</td><td><a href="rev/20874/AbstractMathTransform.xhtml">Clover in, PMD out since nobody is using it. Also changed a few classes to make them compatible with Clover (workaround for a Clover bug, see http://www.cenqua.com/forums/thread.jspa?forumID=1&amp;threadID=2333)</a></td></tr>
+<tr><td class="rev">19769</td><td>2006-06-02</td><td>desruisseaux</td><td>Javadoc fix: replaced 'degrees' by 'decimal degrees' when relevant (GEOT-855)</td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">17522</td><td>2006-01-11</td><td>desruisseaux</td><td>Added a few experimental @tutorial javadoc tags.</td></tr>
+<tr><td class="rev">16514</td><td>2005-10-25</td><td>desruisseaux</td><td>Added a check if order to use an 'Equirectangular' parameter group without 'latitude of origin' parameter if the latitude of origin is 0.</td></tr>
+<tr><td class="rev">16205</td><td>2005-10-11</td><td>desruisseaux</td><td>Cleaned javadoc warning. More work done on Maven 2 configuration (GEOT-691)</td></tr>
+<tr><td class="rev">15556</td><td>2005-08-30</td><td>desruisseaux</td><td>Bug fix in 'createTransformedShape' / Clarification in the way a GridCoverage2D convenience constructor handle axis</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15325</td><td>2005-08-13</td><td>desruisseaux</td><td>Created a matrix package on top of vecmath / Fixed 'getPositionalAccuracy' issues</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">14657</td><td>2005-07-01</td><td>desruisseaux</td><td>Ongoing work for the port of grid coverage operations from 'legacy' to 'main' (GEOT-413): ported SampleDimensionSelect</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13922</td><td>2005-05-29</td><td>desruisseaux</td><td>Renaming of remainding GeoAPI implementations. Renaming is now finished.</td></tr>
+<tr><td class="rev">13836</td><td>2005-05-26</td><td>desruisseaux</td><td>Added 'Default' suffix to some CRS implementations: partial work</td></tr>
+<tr><td class="rev">13371</td><td>2005-05-04</td><td>desruisseaux</td><td>Added a test cases for WarpTransform2D</td></tr>
+<tr><td class="rev">13361</td><td>2005-05-03</td><td>desruisseaux</td><td>First part of LocalizationGrid refactoring work (explanation email to be sent shortly)</td></tr>
+<tr><td class="rev">11008</td><td>2005-02-02</td><td>desruisseaux</td><td>Ask OperationMethod to be specified explicitly</td></tr>
+<tr><td class="rev">11007</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed ArrayIndexOutOfBoundsException in transform(DirectPosition,DirectPosition)</td></tr>
+<tr><td class="rev">10944</td><td>2005-02-01</td><td>desruisseaux</td><td>Bug fix in ProjectedCRS: axis swapping and units conversion were not correctly handled</td></tr>
+<tr><td class="rev">10469</td><td>2005-01-11</td><td>desruisseaux</td><td>Replaced calls to 'getDim[Source|Target]' by 'get[Source|Target]Dimensions</td></tr>
+<tr><td class="rev">10228</td><td>2005-01-04</td><td>desruisseaux</td><td>Renamed 'getDimSource' as 'getSourceDimension'</td></tr>
+<tr><td class="rev">9266</td><td>2004-11-23</td><td>desruisseaux</td><td>Last WKT tuning; parsing and formatting should now be functional</td></tr>
+<tr><td class="rev">9092</td><td>2004-11-11</td><td>desruisseaux</td><td>Slight modification in the protected API for handling parameters</td></tr>
+<tr><td class="rev">7862</td><td>2004-09-09</td><td class="unav">jgarnett</td><td><a href="rev/07862/AbstractMathTransform.xhtml">Removed import warnings - after checking javadocs.</a></td></tr>
+<tr><td class="rev">6888</td><td>2004-07-14</td><td>desruisseaux</td><td>Update for GeoAPI changes (Info -->  IdentifiedObject)</td></tr>
+<tr><td class="rev">6704</td><td>2004-07-03</td><td>desruisseaux</td><td>Parse MathTransform arguments using parametes available in providers</td></tr>
+<tr><td class="rev">6657</td><td>2004-06-30</td><td>desruisseaux</td><td>Fine tuning getParameterValues() method</td></tr>
+<tr><td class="rev">6627</td><td>2004-06-29</td><td>desruisseaux</td><td>Finished refactoring of WKT formatting for MathTransform</td></tr>
+<tr><td class="rev">6606</td><td>2004-06-29</td><td class="unav">rschulz</td><td><a href="rev/06606/AbstractMathTransform.xhtml">fixed bug in rollLongitude method</a></td></tr>
+<tr><td class="rev">6565</td><td>2004-06-26</td><td>desruisseaux</td><td>First draft of a MapProjection port</td></tr>
+<tr><td class="rev">6536</td><td>2004-06-25</td><td>desruisseaux</td><td>Added SingleCRS class / Renamed ObliqueCartesianCS as AffineCS / Moved Position as super-interface for DirectPosition and Point</td></tr>
+<tr><td class="rev">6494</td><td>2004-06-23</td><td>desruisseaux</td><td>Avoid ParameterValue object creation when formatting WKT parameters</td></tr>
+<tr><td class="rev">6477</td><td>2004-06-19</td><td class="unav">rschulz</td><td><a href="rev/06477/AbstractMathTransform.xhtml">added ensureInRange() method</a></td></tr>
+<tr><td class="rev">6440</td><td>2004-06-13</td><td>desruisseaux</td><td>Added GeocentricTransform / Added registry service in TransformFactory / Refactored JUnit tests</td></tr>
+<tr><td class="rev">6375</td><td>2004-06-10</td><td>desruisseaux</td><td>Work on parameters handling</td></tr>
+<tr><td class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing CRS implementation</td></tr>
+<tr><td class="rev">6325</td><td>2004-06-04</td><td>desruisseaux</td><td>Added MathTransform implementations</td></tr>
+<tr><td class="rev">6301</td><td>2004-06-03</td><td>desruisseaux</td><td>Refactored basic transform in their own package</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/06477/AbstractMathTransform.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/06477/AbstractMathTransform.xhtml?rev=1599787&view=auto
==============================================================================
--- sis/ip-review/rev/06477/AbstractMathTransform.xhtml (added)
+++ sis/ip-review/rev/06477/AbstractMathTransform.xhtml Tue Jun  3 20:28:33 2014
@@ -0,0 +1,50 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractMathTransform changes for revisions 6476:6477</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractMathTransform changes for revisions 6476:6477</h1>
+<p>This method has been removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r6476:6477 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/AbstractMathTransform.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 6476</th><th>Revision 6477</th></tr>
+<tr><td><pre>}
+
+/**
+ * Transform the specified shape. The default implementation compute
+ * quadratic curves using three points for each shape's segments.
+ *</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Makes sure that the specified longitude stay within ±180 degrees. This methpod should be</span>
+<span class="add"> * invoked after coordinates are transformed. This</span>
+<span class="add"> * method may add or substract an amount of 360° to &lt;var&gt;x&lt;/var&gt;.</span>
+<span class="add"> *</span>
+<span class="add"> * @param  x The longitude.</span>
+<span class="add"> * @return The longitude in the range +/- 180°.</span>
+<span class="add"> */</span>
+<span class="add">protected double ensureInRange(double x) {</span>
+<span class="add">    if (x &gt; Math.PI) {</span>
+<span class="add">        x -= 2*Math.PI;</span>
+<span class="add">    } else if (x &lt; -Math.PI) {</span>
+<span class="add">        x += 2*Math.PI;</span>
+<span class="add">    }</span>
+<span class="add">    return x;</span>
+<span class="add">}</span>
+<span class="add"></span>
+<span class="add">/**</span>
+ * Transform the specified shape. The default implementation compute
+ * quadratic curves using three points for each shape's segments.
+ *</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/06477/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/06477/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/06477/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/06477/HEADER.html?rev=1599787&view=auto
==============================================================================
--- sis/ip-review/rev/06477/HEADER.html (added)
+++ sis/ip-review/rev/06477/HEADER.html Tue Jun  3 20:28:33 2014
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 6477</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 6477</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>rschulz</td></tr>
+  <tr><td><b>Date:</b></td><td>2004-06-19</td></tr>
+  <tr><td><b>Message:</b></td><td>added ensureInRange() method</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/06477/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/06477/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/06606/AbstractMathTransform.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/06606/AbstractMathTransform.xhtml?rev=1599787&view=auto
==============================================================================
--- sis/ip-review/rev/06606/AbstractMathTransform.xhtml (added)
+++ sis/ip-review/rev/06606/AbstractMathTransform.xhtml Tue Jun  3 20:28:33 2014
@@ -0,0 +1,61 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractMathTransform changes for revisions 6605:6606</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractMathTransform changes for revisions 6605:6606</h1>
+<p>This method has been removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r6605:6606 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/AbstractMathTransform.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 6605</th><th>Revision 6606</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+<span class="del"> * (C) 2003, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+<span class="add"> * (C) 2003, 2004 Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Makes sure that the specified longitude stay within &amp;plusmn;&amp;pi; radians. This method</span>
+ * is typically invoked after geographic coordinates are transformed. This method may add
+ * or substract some amount of 2&amp;pi; radians to &lt;var&gt;x&lt;/var&gt;.
+ *</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Ensures that the specified longitude stay within &amp;plusmn;&amp;pi; radians. This method</span>
+ * is typically invoked after geographic coordinates are transformed. This method may add
+ * or substract some amount of 2&amp;pi; radians to &lt;var&gt;x&lt;/var&gt;.
+ *</pre></td></tr>
+<tr><td><pre> * @return The longitude in the range &amp;plusmn;&amp;pi; radians.
+ */
+protected static double rollLongitude(final double x) {
+<span class="del">    return x + (2*Math.PI)*Math.floor(x / (2*Math.PI) + 0.5);</span>
+}
+
+/**</pre></td>
+<td><pre> * @return The longitude in the range &amp;plusmn;&amp;pi; radians.
+ */
+protected static double rollLongitude(final double x) {
+<span class="add">    return x - (2*Math.PI)*Math.floor(x / (2*Math.PI) + 0.5);</span>
+}
+
+/**</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/06606/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/06606/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/06606/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/06606/HEADER.html?rev=1599787&view=auto
==============================================================================
--- sis/ip-review/rev/06606/HEADER.html (added)
+++ sis/ip-review/rev/06606/HEADER.html Tue Jun  3 20:28:33 2014
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 6606</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 6606</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>rschulz</td></tr>
+  <tr><td><b>Date:</b></td><td>2004-06-29</td></tr>
+  <tr><td><b>Message:</b></td><td>fixed bug in rollLongitude method</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/06606/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/06606/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/07862/AbstractMathTransform.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07862/AbstractMathTransform.xhtml?rev=1599787&view=auto
==============================================================================
--- sis/ip-review/rev/07862/AbstractMathTransform.xhtml (added)
+++ sis/ip-review/rev/07862/AbstractMathTransform.xhtml Tue Jun  3 20:28:33 2014
@@ -0,0 +1,49 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractMathTransform changes for revisions 7861:7862</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractMathTransform changes for revisions 7861:7862</h1>
+<p>This commit has been reverted (<code>Identifier</code>) or lines have been deleted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r7861:7862 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/AbstractMathTransform.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 7861</th><th>Revision 7862</th></tr>
+<tr><td><pre>import javax.units.SI;
+
+// OpenGIS dependencies
+<span class="del">import org.opengis.metadata.Identifier;</span>
+import org.opengis.referencing.operation.Matrix;
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransform1D;</pre></td>
+<td><pre>import javax.units.SI;
+
+// OpenGIS dependencies
+<span class="add">//import org.opengis.metadata.Identifier;</span>
+import org.opengis.referencing.operation.Matrix;
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransform1D;</pre></td></tr>
+<tr><td><pre>import org.geotools.referencing.wkt.Formatter;
+import org.geotools.referencing.wkt.Formattable;
+import org.geotools.referencing.operation.GeneralMatrix;
+<span class="del">import org.geotools.referencing.wkt.UnformattableObjectException;</span>
+import org.geotools.geometry.GeneralDirectPosition;
+import org.geotools.resources.geometry.ShapeUtilities;
+import org.geotools.resources.Utilities;</pre></td>
+<td><pre>import org.geotools.referencing.wkt.Formatter;
+import org.geotools.referencing.wkt.Formattable;
+import org.geotools.referencing.operation.GeneralMatrix;
+<span class="add">//import org.geotools.referencing.wkt.UnformattableObjectException;</span>
+import org.geotools.geometry.GeneralDirectPosition;
+import org.geotools.resources.geometry.ShapeUtilities;
+import org.geotools.resources.Utilities;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/07862/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/07862/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/07862/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07862/HEADER.html?rev=1599787&view=auto
==============================================================================
--- sis/ip-review/rev/07862/HEADER.html (added)
+++ sis/ip-review/rev/07862/HEADER.html Tue Jun  3 20:28:33 2014
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 7862</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 7862</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2004-09-09</td></tr>
+  <tr><td><b>Message:</b></td><td>Removed import warnings - after checking javadocs.</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/07862/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/07862/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/AbstractMathTransform.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/AbstractMathTransform.xhtml?rev=1599787&view=auto
==============================================================================
--- sis/ip-review/rev/20874/AbstractMathTransform.xhtml (added)
+++ sis/ip-review/rev/20874/AbstractMathTransform.xhtml Tue Jun  3 20:28:33 2014
@@ -0,0 +1,203 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractMathTransform changes for revisions 20755:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractMathTransform changes for revisions 20755:20874</h1>
+<p>Changes in GeoTools header does not apply to Apache SIS, since we relicense only the part written by SIS contributors.
+Changes in the code (inner classes made static) have been reverted (back to non-static inner classes).</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20755:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/AbstractMathTransform.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20755</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, 2004 Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *</span>
+<span class="add"> *   (C) 2003-2006, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+<span class="del">*    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del">*    License along with this library; if not, write to the Free Software</span>
+<span class="del">*    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+<span class="del">*</span>
+<span class="del">*</span>
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td>
+<td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td></tr>
+<tr><td><pre> * @version $Id$
+ * @author Martin Desruisseaux
+ */
+<span class="del">protected abstract class Inverse extends AbstractMathTransform implements Serializable {</span>
+    /**
+     * Serial number for interoperability with different versions. This serial number is
+     * especilly important for inner classes, since the default {@code serialVersionUID}</pre></td>
+<td><pre> * @version $Id$
+ * @author Martin Desruisseaux
+ */
+<span class="add">protected static abstract class Inverse extends AbstractMathTransform implements Serializable {</span>
+    /**
+     * Serial number for interoperability with different versions. This serial number is
+     * especilly important for inner classes, since the default {@code serialVersionUID}</pre></td></tr>
+<tr><td><pre> * http://developer.java.sun.com/developer/bugParade/bugs/4211550.html
+ */
+private static final long serialVersionUID = 3528274816628012283L;
+
+/**
+ * Constructs an inverse math transform.
+ */
+<span class="del">protected Inverse() {</span>
+}
+
+/**</pre></td>
+<td><pre>  * http://developer.java.sun.com/developer/bugParade/bugs/4211550.html
+  */
+ private static final long serialVersionUID = 3528274816628012283L;
+<span class="add">private AbstractMathTransform original;</span>
+
+ /**
+  * Constructs an inverse math transform.
+  */
+<span class="add"> protected Inverse(AbstractMathTransform original) {</span>
+<span class="add">     this.original = original;</span>
+ }
+
+ /**</pre></td></tr>
+<tr><td><pre> * points of the enclosing math transform.
+ */
+public int getSourceDimensions() {
+<span class="del">    return AbstractMathTransform.this.getTargetDimensions();</span>
+}
+
+/**</pre></td>
+<td><pre> * points of the enclosing math transform.
+ */
+public int getSourceDimensions() {
+<span class="add">    return original.getTargetDimensions();</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> * points of the enclosing math transform.
+ */
+public int getTargetDimensions() {
+<span class="del">    return AbstractMathTransform.this.getSourceDimensions();</span>
+}
+
+/**</pre></td>
+<td><pre> * points of the enclosing math transform.
+ */
+public int getTargetDimensions() {
+<span class="add">    return original.getSourceDimensions();</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> * the enclosing math transform.
+ */
+public Matrix derivative(final Point2D point) throws TransformException {
+<span class="del">    return invert(AbstractMathTransform.this.derivative(this.transform(point, null)));</span>
+}
+
+/**</pre></td>
+<td><pre> * the enclosing math transform.
+ */
+public Matrix derivative(final Point2D point) throws TransformException {
+<span class="add">    return invert(original.derivative(this.transform(point, null)));</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> * the enclosing math transform.
+ */
+public Matrix derivative(final DirectPosition point) throws TransformException {
+<span class="del">    return invert(AbstractMathTransform.this.derivative(this.transform(point, null)));</span>
+}
+
+/**</pre></td>
+<td><pre> * the enclosing math transform.
+ */
+public Matrix derivative(final DirectPosition point) throws TransformException {
+<span class="add">    return invert(original.derivative(this.transform(point, null)));</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> * of {@code this} is always {@code AbstractMathTransform.this}.
+ */
+public final MathTransform inverse() {
+<span class="del">    return AbstractMathTransform.this;</span>
+}
+
+/**</pre></td>
+<td><pre> * of {@code this} is always {@code AbstractMathTransform.this}.
+ */
+public final MathTransform inverse() {
+<span class="add">    return original;</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> * enclosing math transform.
+ */
+public boolean isIdentity() {
+<span class="del">    return AbstractMathTransform.this.isIdentity();</span>
+}
+
+/**</pre></td>
+<td><pre> * enclosing math transform.
+ */
+public boolean isIdentity() {
+<span class="add">    return original.isIdentity();</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> * Returns a hash code value for this math transform.
+ */
+public int hashCode() {
+<span class="del">    return ~AbstractMathTransform.this.hashCode();</span>
+}
+
+/**</pre></td>
+<td><pre> * Returns a hash code value for this math transform.
+ */
+public int hashCode() {
+<span class="add">    return ~original.hashCode();</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre>        formatter.append(parameters);
+        return "PARAM_MT";
+    } else {
+<span class="del">        formatter.append((Formattable) AbstractMathTransform.this);</span>
+        return "INVERSE_MT";
+    }
+}</pre></td>
+<td><pre>        formatter.append(parameters);
+        return "PARAM_MT";
+    } else {
+<span class="add">        formatter.append((Formattable) original);</span>
+        return "INVERSE_MT";
+    }
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24485/AbstractMathTransform.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24485/AbstractMathTransform.xhtml?rev=1599787&view=auto
==============================================================================
--- sis/ip-review/rev/24485/AbstractMathTransform.xhtml (added)
+++ sis/ip-review/rev/24485/AbstractMathTransform.xhtml Tue Jun  3 20:28:33 2014
@@ -0,0 +1,42 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractMathTransform changes for revisions 24484:24485</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractMathTransform changes for revisions 24484:24485</h1>
+<p>This method has been removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24484:24485 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/AbstractMathTransform.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24484</th><th>Revision 24485</th></tr>
+<tr><td><pre>}
+
+/**
+ * Constructs an error message for the {@link MismatchedDimensionException}.
+ *
+ * @param argument  The argument name with the wrong number of dimensions.</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Tests whether this transform does not move any points, by using</span>
+<span class="add"> * the provided &lt;code&gt;tolerance&lt;/code&gt; value.</span>
+<span class="add"> * The default implementation always returns {@code false}.</span>
+<span class="add"> */</span>
+<span class="add">public boolean isIdentity(double tolerance) {</span>
+<span class="add">    return false;</span>
+<span class="add">}</span>
+<span class="add"></span>
+<span class="add">/**</span>
+ * Constructs an error message for the {@link MismatchedDimensionException}.
+ *
+ * @param argument  The argument name with the wrong number of dimensions.</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24485/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24485/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24925/AbstractMathTransform.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/AbstractMathTransform.xhtml?rev=1599787&view=auto
==============================================================================
--- sis/ip-review/rev/24925/AbstractMathTransform.xhtml (added)
+++ sis/ip-review/rev/24925/AbstractMathTransform.xhtml Tue Jun  3 20:28:33 2014
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractMathTransform changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractMathTransform changes for revisions 24924:24925</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/transform/AbstractMathTransform.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>import org.opengis.referencing.operation.OperationMethod;
+import org.opengis.referencing.operation.TransformException;
+import org.opengis.referencing.operation.NoninvertibleTransformException;
+<span class="del">import org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+<span class="del">import org.opengis.spatialschema.geometry.DirectPosition;</span>
+import org.opengis.parameter.InvalidParameterValueException;
+import org.opengis.parameter.ParameterDescriptorGroup;
+import org.opengis.parameter.ParameterValueGroup;</pre></td>
+<td><pre>import org.opengis.referencing.operation.OperationMethod;
+import org.opengis.referencing.operation.TransformException;
+import org.opengis.referencing.operation.NoninvertibleTransformException;
+<span class="add">import org.opengis.geometry.MismatchedDimensionException;</span>
+<span class="add">import org.opengis.geometry.DirectPosition;</span>
+import org.opengis.parameter.InvalidParameterValueException;
+import org.opengis.parameter.ParameterDescriptorGroup;
+import org.opengis.parameter.ParameterValueGroup;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24925/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24925/AbstractMathTransform.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message