sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1575895 [1/2] - in /sis/ip-review: ./ rev/07846/ rev/07857/ rev/07860/ rev/10796/ rev/20874/ rev/24973/
Date Mon, 10 Mar 2014 10:38:41 GMT
Author: desruisseaux
Date: Mon Mar 10 10:38:40 2014
New Revision: 1575895

URL: http://svn.apache.org/r1575895
Log:
Added IP review.

Added:
    sis/ip-review/MatrixParameterDescriptors.xhtml   (with props)
    sis/ip-review/MatrixParameters.xhtml   (with props)
    sis/ip-review/MeasurementParameter.xhtml   (with props)
    sis/ip-review/ParameterFormat.xhtml   (with props)
    sis/ip-review/rev/07846/MatrixParameterDescriptors.xhtml   (with props)
    sis/ip-review/rev/07857/MeasurementParameter.xhtml   (with props)
    sis/ip-review/rev/07860/
    sis/ip-review/rev/07860/HEADER.html   (with props)
    sis/ip-review/rev/07860/MatrixParameters.xhtml   (with props)
    sis/ip-review/rev/10796/MatrixParameterDescriptors.xhtml   (with props)
    sis/ip-review/rev/10796/MatrixParameters.xhtml   (with props)
    sis/ip-review/rev/10796/MeasurementParameter.xhtml   (with props)
    sis/ip-review/rev/10796/ParameterFormat.xhtml   (with props)
    sis/ip-review/rev/20874/MatrixParameterDescriptors.xhtml   (with props)
    sis/ip-review/rev/20874/MatrixParameters.xhtml   (with props)
    sis/ip-review/rev/20874/MeasurementParameter.xhtml   (with props)
    sis/ip-review/rev/20874/ParameterFormat.xhtml   (with props)
    sis/ip-review/rev/24973/MatrixParameters.xhtml   (with props)

Added: sis/ip-review/MatrixParameterDescriptors.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/MatrixParameterDescriptors.xhtml?rev=1575895&view=auto
==============================================================================
--- sis/ip-review/MatrixParameterDescriptors.xhtml (added)
+++ sis/ip-review/MatrixParameterDescriptors.xhtml Mon Mar 10 10:38:40 2014
@@ -0,0 +1,73 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>MatrixParameterDescriptors history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>MatrixParameterDescriptors history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/parameter/MatrixParameterDescriptors.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31000</td><td>2008-07-10</td><td>desruisseaux</td><td>Avoid usage of 2 deprecated constructors from CRSFactory. Their replacement were tricky and required more sophesticated code in ReferencingFactoryContainer.toGeodetic3D.</td></tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations in the process.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update referencing headers</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29753</td><td>2008-04-01</td><td>desruisseaux</td><td>Applied parameterized types as a side-effect of hunting for a DimensionMismatchException during reprojection.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28267</td><td>2007-12-06</td><td>desruisseaux</td><td>GeoTools trunk now build against GeoAPI 2.2-SNAPSHOT.</td></tr>
+<tr><td class="rev">28069</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 generics in org.geotools.image.io, and partially in org.geotools.parameters.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/MatrixParameterDescriptors.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15325</td><td>2005-08-13</td><td>desruisseaux</td><td>Created a matrix package on top of vecmath / Fixed 'getPositionalAccuracy' issues</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">14608</td><td>2005-06-25</td><td>desruisseaux</td><td>EPSG authority factory now uses path informations for ConcatenatedOperation object creations / Added PostgreSQL plugin (mostly as a demo) / Javadoc fixes</td></tr>
+<tr><td class="rev">14550</td><td>2005-06-16</td><td>desruisseaux</td><td>Removed deprecated fields and methods</td></tr>
+<tr><td class="rev">14235</td><td>2005-06-10</td><td>desruisseaux</td><td>Replaced _PROPERTY suffix by _KEY as of GEOT-577</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13922</td><td>2005-05-29</td><td>desruisseaux</td><td>Renaming of remainding GeoAPI implementations. Renaming is now finished.</td></tr>
+<tr><td class="rev">13906</td><td>2005-05-28</td><td>desruisseaux</td><td>Renamed some 'Default' prefix as 'Abstract'</td></tr>
+<tr><td class="rev">13836</td><td>2005-05-26</td><td>desruisseaux</td><td>Added 'Default' suffix to some CRS implementations: partial work</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/MatrixParameterDescriptors.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">9118</td><td>2004-11-14</td><td>desruisseaux</td><td>Mercator projection port completed (but untested) as a use case for other projection ports</td></tr>
+<tr><td class="rev">8726</td><td>2004-10-21</td><td>desruisseaux</td><td>Various bug fixes in parameter handling</td></tr>
+<tr><td class="rev">8621</td><td>2004-10-14</td><td>desruisseaux</td><td>Enforced 'maximumOccurs==1' in ParameterValue implementation</td></tr>
+<tr><td class="rev">8610</td><td>2004-10-13</td><td>desruisseaux</td><td>Changed ParameterDescriptorGroup.descriptor(String) return type from 'ParameterValue' to 'GeneralParameterValue'</td></tr>
+<tr><td class="rev">8596</td><td>2004-10-12</td><td>desruisseaux</td><td>Redirected javadoc links toward org.opengis.* instead org.geotools.* when the discussion is general enough</td></tr>
+<tr><td class="rev">8518</td><td>2004-10-11</td><td>desruisseaux</td><td>Apply changes voted in OGC meeting at Southampton: use of Identifier and GenericName</td></tr>
+<tr><td class="rev">7846</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a href="rev/07846/MatrixParameterDescriptors.xhtml">Cleaned up opengis/geotools split</a></td></tr>
+<tr><td class="rev">7836</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a href="rev/07846/MatrixParameterDescriptors.xhtml">First round of resync with geoapi</a></td></tr>
+<tr><td class="rev">7706</td><td>2004-08-31</td><td class="unav">jgarnett</td><td><a href="rev/07846/MatrixParameterDescriptors.xhtml">Change over to parameter descriptor and added parse( text ), text() methods.</a></td></tr>
+<tr><td class="rev">6888</td><td>2004-07-14</td><td>desruisseaux</td><td>Update for GeoAPI changes (Info -->  IdentifiedObject)</td></tr>
+<tr><td class="rev">6575</td><td>2004-06-27</td><td>desruisseaux</td><td>MatrixParameters now uses ParameterRealValue / In providers, moved parameters in a static field.</td></tr>
+<tr><td class="rev">6383</td><td>2004-06-11</td><td>desruisseaux</td><td>Search for parameters and operation methods by identifiers</td></tr>
+<tr><td class="rev">6375</td><td>2004-06-10</td><td>desruisseaux</td><td>Work on parameters handling</td></tr>
+<tr><td class="rev">6371</td><td>2004-06-09</td><td>desruisseaux</td><td>Added test cases for parameters</td></tr>
+<tr><td class="rev">6366</td><td>2004-06-09</td><td>desruisseaux</td><td>First working implementation of MatrixParameters</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/MatrixParameterDescriptors.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/MatrixParameterDescriptors.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/MatrixParameters.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/MatrixParameters.xhtml?rev=1575895&view=auto
==============================================================================
--- sis/ip-review/MatrixParameters.xhtml (added)
+++ sis/ip-review/MatrixParameters.xhtml Mon Mar 10 10:38:40 2014
@@ -0,0 +1,68 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>MatrixParameters history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>MatrixParameters history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/parameter/MatrixParameters.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update referencing headers</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29753</td><td>2008-04-01</td><td>desruisseaux</td><td>Applied parameterized types as a side-effect of hunting for a DimensionMismatchException during reprojection.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28267</td><td>2007-12-06</td><td>desruisseaux</td><td>GeoTools trunk now build against GeoAPI 2.2-SNAPSHOT.</td></tr>
+<tr><td class="rev">28069</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 generics in org.geotools.image.io, and partially in org.geotools.parameters.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">24973</td><td>2007-03-30</td><td class="unav">chorner</td><td><a href="rev/24973/MatrixParameters.xhtml">GEO-93: GeoTools/GeoAPI ISO 19115 Metadata synchronization</a></td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/MatrixParameters.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15325</td><td>2005-08-13</td><td>desruisseaux</td><td>Created a matrix package on top of vecmath / Fixed 'getPositionalAccuracy' issues</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">14608</td><td>2005-06-25</td><td>desruisseaux</td><td>EPSG authority factory now uses path informations for ConcatenatedOperation object creations / Added PostgreSQL plugin (mostly as a demo) / Javadoc fixes</td></tr>
+<tr><td class="rev">14550</td><td>2005-06-16</td><td>desruisseaux</td><td>Removed deprecated fields and methods</td></tr>
+<tr><td class="rev">14205</td><td>2005-06-09</td><td>desruisseaux</td><td>Updated to GeoAPI 2.0 final release</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13922</td><td>2005-05-29</td><td>desruisseaux</td><td>Renaming of remainding GeoAPI implementations. Renaming is now finished.</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/MatrixParameters.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">8726</td><td>2004-10-21</td><td>desruisseaux</td><td>Various bug fixes in parameter handling</td></tr>
+<tr><td class="rev">8701</td><td>2004-10-20</td><td>desruisseaux</td><td>Added the 'remove' operation to ParameterValueGroup</td></tr>
+<tr><td class="rev">8621</td><td>2004-10-14</td><td>desruisseaux</td><td>Enforced 'maximumOccurs==1' in ParameterValue implementation</td></tr>
+<tr><td class="rev">8610</td><td>2004-10-13</td><td>desruisseaux</td><td>Changed ParameterDescriptorGroup.descriptor(String) return type from 'ParameterValue' to 'GeneralParameterValue'</td></tr>
+<tr><td class="rev">8518</td><td>2004-10-11</td><td>desruisseaux</td><td>Apply changes voted in OGC meeting at Southampton: use of Identifier and GenericName</td></tr>
+<tr><td class="rev">7860</td><td>2004-09-09</td><td class="unav">jgarnett</td><td><a href="rev/07860/MatrixParameters.xhtml">Make use of values() override for toWKT to pick up on (3 hour bug hunt)</a></td></tr>
+<tr><td class="rev">7846</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a href="rev/07860/MatrixParameters.xhtml">Cleaned up opengis/geotools split</a></td></tr>
+<tr><td class="rev">7836</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a href="rev/07860/MatrixParameters.xhtml">First round of resync with geoapi</a></td></tr>
+<tr><td class="rev">7706</td><td>2004-08-31</td><td class="unav">jgarnett</td><td><a href="rev/07860/MatrixParameters.xhtml">Change over to parameter descriptor and added parse( text ), text() methods.</a></td></tr>
+<tr><td class="rev">6888</td><td>2004-07-14</td><td>desruisseaux</td><td>Update for GeoAPI changes (Info -->  IdentifiedObject)</td></tr>
+<tr><td class="rev">6627</td><td>2004-06-29</td><td>desruisseaux</td><td>Finished refactoring of WKT formatting for MathTransform</td></tr>
+<tr><td class="rev">6536</td><td>2004-06-25</td><td>desruisseaux</td><td>Added SingleCRS class / Renamed ObliqueCartesianCS as AffineCS / Moved Position as super-interface for DirectPosition and Point</td></tr>
+<tr><td class="rev">6383</td><td>2004-06-11</td><td>desruisseaux</td><td>Search for parameters and operation methods by identifiers</td></tr>
+<tr><td class="rev">6366</td><td>2004-06-09</td><td>desruisseaux</td><td>First working implementation of MatrixParameters</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/MatrixParameters.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/MatrixParameters.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/MeasurementParameter.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/MeasurementParameter.xhtml?rev=1575895&view=auto
==============================================================================
--- sis/ip-review/MeasurementParameter.xhtml (added)
+++ sis/ip-review/MeasurementParameter.xhtml Mon Mar 10 10:38:40 2014
@@ -0,0 +1,66 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>MeasurementParameter history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>MeasurementParameter history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/parameter/FloatParameter.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations in the process.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29753</td><td>2008-04-01</td><td>desruisseaux</td><td>Applied parameterized types as a side-effect of hunting for a DimensionMismatchException during reprojection.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28267</td><td>2007-12-06</td><td>desruisseaux</td><td>GeoTools trunk now build against GeoAPI 2.2-SNAPSHOT.</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">28069</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 generics in org.geotools.image.io, and partially in org.geotools.parameters.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/MeasurementParameter.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16205</td><td>2005-10-11</td><td>desruisseaux</td><td>Cleaned javadoc warning. More work done on Maven 2 configuration (GEOT-691)</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">14175</td><td>2005-06-08</td><td>desruisseaux</td><td>Imaging parameters tunning</td></tr>
+<tr><td class="rev">14157</td><td>2005-06-07</td><td>desruisseaux</td><td>Added parameter wrappers around JAI's ParameterList, for implementation of GridCoverage operations backed by JAI operators</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13922</td><td>2005-05-29</td><td>desruisseaux</td><td>Renaming of remainding GeoAPI implementations. Renaming is now finished.</td></tr>
+<tr><td class="rev">12952</td><td>2005-04-03</td><td>desruisseaux</td><td>Updated metadata implementation for GeoAPI changes (GEO-51 and GEO-56)</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/MeasurementParameter.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">8726</td><td>2004-10-21</td><td>desruisseaux</td><td>Various bug fixes in parameter handling</td></tr>
+<tr><td class="rev">8596</td><td>2004-10-12</td><td>desruisseaux</td><td>Redirected javadoc links toward org.opengis.* instead org.geotools.* when the discussion is general enough</td></tr>
+<tr><td class="rev">8518</td><td>2004-10-11</td><td>desruisseaux</td><td>Apply changes voted in OGC meeting at Southampton: use of Identifier and GenericName</td></tr>
+<tr><td class="rev">7857</td><td>2004-09-09</td><td class="unav">jgarnett</td><td><a href="rev/07857/MeasurementParameter.xhtml">name to getName().toString( null )</a></td></tr>
+<tr><td class="rev">7846</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a href="rev/07857/MeasurementParameter.xhtml">Cleaned up opengis/geotools split</a></td></tr>
+<tr><td class="rev">7836</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a href="rev/07857/MeasurementParameter.xhtml">First round of resync with geoapi</a></td></tr>
+<tr><td class="rev">7706</td><td>2004-08-31</td><td class="unav">jgarnett</td><td><a href="rev/07857/MeasurementParameter.xhtml">Change over to parameter descriptor and added parse( text ), text() methods.</a></td></tr>
+<tr><td class="rev">6589</td><td>2004-06-28</td><td>desruisseaux</td><td>Improved parameters handling</td></tr>
+<tr><td class="rev">6575</td><td>2004-06-27</td><td>desruisseaux</td><td>MatrixParameters now uses ParameterRealValue / In providers, moved parameters in a static field.</td></tr>
+<tr><td class="rev">6565</td><td>2004-06-26</td><td>desruisseaux</td><td>First draft of a MapProjection port</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/MeasurementParameter.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/MeasurementParameter.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/ParameterFormat.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/ParameterFormat.xhtml?rev=1575895&view=auto
==============================================================================
--- sis/ip-review/ParameterFormat.xhtml (added)
+++ sis/ip-review/ParameterFormat.xhtml Mon Mar 10 10:38:40 2014
@@ -0,0 +1,63 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ParameterFormat history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ParameterFormat history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/parameter/ParameterWriter.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31148</td><td>2008-08-07</td><td>desruisseaux</td><td>Renamed GenericName.name() as tip(). The old method still around as a deprecated one.</td></tr>
+<tr><td class="rev">31139</td><td>2008-08-06</td><td>desruisseaux</td><td>Avoid usage of deprecated methods from the org.opengis.util.GenericName interface.</td></tr>
+<tr><td class="rev">31132</td><td>2008-08-05</td><td>desruisseaux</td><td>As a side effect of "geotidy" work, ported a few bug fixes in metadata. Avoid usage of deprecated GeneralName.getScope() method, replaced by scope().</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28536</td><td>2007-12-28</td><td>desruisseaux</td><td>MosaicImageReader now take subsampling in account. The build is still failing for unrelated reason, see Hudson report #22.</td></tr>
+<tr><td class="rev">28267</td><td>2007-12-06</td><td>desruisseaux</td><td>GeoTools trunk now build against GeoAPI 2.2-SNAPSHOT.</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">23632</td><td>2006-12-29</td><td>desruisseaux</td><td>GEOT-859: Refactored the URN syntax adapter for CRS factories. The adapter now apply to any factory. Some progress toward version management (but not yet there). NOTE: this new implementation forces axis order "as specified in the database", which is different from the original "URNEPSGAdapter" implementation which used (x,y) order. Various changes in many corners of "org.geotools.referencing.factory" as a side-effect of this work. Minor opportunist javadoc fixes in other modules.</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/ParameterFormat.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16205</td><td>2005-10-11</td><td>desruisseaux</td><td>Cleaned javadoc warning. More work done on Maven 2 configuration (GEOT-691)</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">15231</td><td>2005-08-08</td><td>desruisseaux</td><td>Added NodataFilter and GradientMagnitude operation / Various bug fixes</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">14725</td><td>2005-07-06</td><td>desruisseaux</td><td>Refactoring of GridCoverage operations: moved to a processing sub-package, operations are first-level classes (not inner classes), implementations hiden when possible, GridCoverageProcessor renamed as Processor and generalized (accepts Coverage instead of GridCoverage).</td></tr>
+<tr><td class="rev">14570</td><td>2005-06-21</td><td>desruisseaux</td><td>Addition of geocentric affine transform as of GEOT-591</td></tr>
+<tr><td class="rev">14205</td><td>2005-06-09</td><td>desruisseaux</td><td>Updated to GeoAPI 2.0 final release</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">11816</td><td>2005-03-07</td><td>desruisseaux</td><td>First draft of GridCoverage operation port</td></tr>
+<tr><td class="rev">11146</td><td>2005-02-07</td><td>desruisseaux</td><td>CoordinateOperationFactory refactoring</td></tr>
+<tr><td class="rev">11144</td><td>2005-02-07</td><td>desruisseaux</td><td>Fixed GEOT-400 (create appropriate instance of Operation subclasses)</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/ParameterFormat.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">9243</td><td>2004-11-22</td><td>desruisseaux</td><td>Tuned WKT parsing and formatting</td></tr>
+<tr><td class="rev">9133</td><td>2004-11-16</td><td>desruisseaux</td><td>Parameter formatting tuning</td></tr>
+<tr><td class="rev">9118</td><td>2004-11-14</td><td>desruisseaux</td><td>Mercator projection port completed (but untested) as a use case for other projection ports</td></tr>
+<tr><td class="rev">9117</td><td>2004-11-13</td><td>desruisseaux</td><td>Added the capability to list all available MathTransforms</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/ParameterFormat.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/ParameterFormat.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/07846/MatrixParameterDescriptors.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07846/MatrixParameterDescriptors.xhtml?rev=1575895&view=auto
==============================================================================
--- sis/ip-review/rev/07846/MatrixParameterDescriptors.xhtml (added)
+++ sis/ip-review/rev/07846/MatrixParameterDescriptors.xhtml Mon Mar 10 10:38:40 2014
@@ -0,0 +1,301 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>MatrixParameterDescriptors changes for revisions 7705:7846</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>MatrixParameterDescriptors changes for revisions 7705:7846</h1>
+<p>In this commit:</p>
+<ul>
+  <li>Changes for renaming of GeoAPI interface: <code>OperationParameter</code> → <code>ParameterDescriptor</code>.
+      Reverting this changes causes compilation errors, which can be fixed only be re-applying the same change.</li>
+  <li>Addition of <code>serialVersionUID = 1L</code>: this change has been reverted
+      (replaced by computed <code>serialVersionUID</code>).</li>
+</ul>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r7705:7846 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/parameter/MatrixParameterDescriptors.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 7705</th><th>Revision 7846</th></tr>
+<tr><td><pre>// OpenGIS dependencies
+import org.opengis.parameter.ParameterValue;
+<span class="del">import org.opengis.parameter.OperationParameter;</span>
+import org.opengis.parameter.ParameterValueGroup;
+import org.opengis.parameter.GeneralParameterValue;
+<span class="del">import org.opengis.parameter.GeneralOperationParameter;</span>
+import org.opengis.parameter.ParameterNotFoundException;
+import org.opengis.parameter.InvalidParameterNameException;
+import org.opengis.referencing.operation.Matrix;</pre></td>
+<td><pre>// OpenGIS dependencies
+import org.opengis.parameter.ParameterValue;
+<span class="add">import org.opengis.parameter.ParameterDescriptor;</span>
+import org.opengis.parameter.ParameterValueGroup;
+import org.opengis.parameter.GeneralParameterValue;
+<span class="add">import org.opengis.parameter.GeneralParameterDescriptor;</span>
+import org.opengis.parameter.ParameterNotFoundException;
+import org.opengis.parameter.InvalidParameterNameException;
+import org.opengis.referencing.operation.Matrix;</pre></td></tr>
+<tr><td><pre> *
+ * @see MatrixParameterValues
+ */
+<span class="del">public class MatrixParameters extends OperationParameterGroup {</span>
+    /**
+     * The default matrix size for the {@linkplain #MatrixParameters(Map) one-argument constructor}.
+     */</pre></td>
+<td><pre> *
+ * @see MatrixParameterValues
+ */
+<span class="add">public class MatrixParameters extends ParameterGroupDescriptor {</span>
+<span class="add">    private static final long serialVersionUID = 1L;</span>
+<span class="add"></span>
+    /**
+     * The default matrix size for the {@linkplain #MatrixParameters(Map) one-argument constructor}.
+     */</pre></td></tr>
+<tr><td><pre> * on matrix element values. Concequently, the same descriptors can be reused for all
+ * {@link MatrixParameterValues} instances.
+ */
+<span class="del">private final OperationParameter[] parameters = new OperationParameter[CACHE_SIZE*CACHE_SIZE];</span>
+
+/**
+ * The descriptor for the &lt;code&gt;"num_row"&lt;/code&gt; parameter.
+ */
+<span class="del">protected final OperationParameter numRow;</span>
+
+/**
+ * The descriptor for the &lt;code&gt;"num_col"&lt;/code&gt; parameter.
+ */
+<span class="del">protected final OperationParameter numCol;</span>
+
+/**
+ * The prefix to insert in front of parameter name for each matrix elements.</pre></td>
+<td><pre> * on matrix element values. Concequently, the same descriptors can be reused for all
+ * {@link MatrixParameterValues} instances.
+ */
+<span class="add">private final ParameterDescriptor[] parameters = new ParameterDescriptor[CACHE_SIZE*CACHE_SIZE];</span>
+
+/**
+ * The descriptor for the &lt;code&gt;"num_row"&lt;/code&gt; parameter.
+ */
+<span class="add">protected final ParameterDescriptor numRow;</span>
+
+/**
+ * The descriptor for the &lt;code&gt;"num_col"&lt;/code&gt; parameter.
+ */
+<span class="add">protected final ParameterDescriptor numCol;</span>
+
+/**
+ * The prefix to insert in front of parameter name for each matrix elements.</pre></td></tr>
+<tr><td><pre>     *       used in this implementation is inefficient  for large amount of matrix
+     *       elements.
+     */
+<span class="del">    this(properties, new OperationParameter[] {</span>
+<span class="del">        new org.geotools.parameter.OperationParameter("num_row", DEFAULT_MATRIX_SIZE, 2, 50),</span>
+<span class="del">        new org.geotools.parameter.OperationParameter("num_col", DEFAULT_MATRIX_SIZE, 2, 50)</span>
+    }, "elt_", '_');
+}</pre></td>
+<td><pre>     *       used in this implementation is inefficient  for large amount of matrix
+     *       elements.
+     */
+<span class="add">    this(properties, new ParameterDescriptor[] {</span>
+<span class="add">        new org.geotools.parameter.ParameterDescriptor("num_row", DEFAULT_MATRIX_SIZE, 2, 50),</span>
+<span class="add">        new org.geotools.parameter.ParameterDescriptor("num_col", DEFAULT_MATRIX_SIZE, 2, 50)</span>
+    }, "elt_", '_');
+}</pre></td></tr>
+<tr><td><pre> * @param separator  The separator between the row and the column index in parameter names.
+ */
+public MatrixParameters(final Map            properties,
+<span class="del">                        OperationParameter[] parameters,</span>
+                        final String         prefix,
+                        final char           separator)
+{</pre></td>
+<td><pre> * @param separator  The separator between the row and the column index in parameter names.
+ */
+public MatrixParameters(final Map            properties,
+<span class="add">                  ParameterDescriptor[] parameters,</span>
+                        final String         prefix,
+                        final char           separator)
+{</pre></td></tr>
+<tr><td><pre> * @return The parameter for the given name.
+ * @throws ParameterNotFoundException if there is no parameter for the given name.
+ */
+<span class="del">public final OperationParameter getParameter(final String name)</span>
+        throws ParameterNotFoundException
+{
+    return getParameter(name,</pre></td>
+<td><pre> * @return The parameter for the given name.
+ * @throws ParameterNotFoundException if there is no parameter for the given name.
+ */
+<span class="add">public final ParameterDescriptor getParameter(final String name)</span>
+        throws ParameterNotFoundException
+{
+    return getParameter(name,</pre></td></tr>
+<tr><td><pre> * @return The parameter for the given name.
+ * @throws ParameterNotFoundException if there is no parameter for the given name.
+ */
+<span class="del">final OperationParameter getParameter(String name, final int numRow, final int numCol)</span>
+        throws ParameterNotFoundException
+{
+    ensureNonNull("name", name);</pre></td>
+<td><pre> * @return The parameter for the given name.
+ * @throws ParameterNotFoundException if there is no parameter for the given name.
+ */
+<span class="add">final ParameterDescriptor getParameter(String name, final int numRow, final int numCol)</span>
+        throws ParameterNotFoundException
+{
+    ensureNonNull("name", name);</pre></td></tr>
+<tr><td><pre>/**
+ * Returns the parameter in this group for a matrix element at the specified
+ * index. row and column indices are 0 based. Indices must be lower that the
+<span class="del"> * {@link org.geotools.parameter.OperationParameter#getMaximumValue maximum values}</span>
+ * given to the {@link #numRow} and {@link #numCol} parameters.
+ *
+ * @param  row    The row indice.</pre></td>
+<td><pre>/**
+ * Returns the parameter in this group for a matrix element at the specified
+ * index. row and column indices are 0 based. Indices must be lower that the
+<span class="add"> * {@link org.geotools.parameter.ParameterDescriptor#getMaximumValue maximum values}</span>
+ * given to the {@link #numRow} and {@link #numCol} parameters.
+ *
+ * @param  row    The row indice.</pre></td></tr>
+<tr><td><pre> * @return The parameter descriptor for the specified matrix element.
+ * @throws IndexOutOfBoundsException if &lt;code&gt;row&lt;/code&gt; or &lt;code&gt;column&lt;/code&gt; is out of bounds.
+ */
+<span class="del">public final OperationParameter getParameter(final int row, final int column)</span>
+        throws IndexOutOfBoundsException
+{
+    return getParameter(row, column,</pre></td>
+<td><pre> * @return The parameter descriptor for the specified matrix element.
+ * @throws IndexOutOfBoundsException if &lt;code&gt;row&lt;/code&gt; or &lt;code&gt;column&lt;/code&gt; is out of bounds.
+ */
+<span class="add">public final ParameterDescriptor getParameter(final int row, final int column)</span>
+        throws IndexOutOfBoundsException
+{
+    return getParameter(row, column,</pre></td></tr>
+<tr><td><pre> * @return The parameter descriptor for the specified matrix element.
+ * @throws IndexOutOfBoundsException if &lt;code&gt;row&lt;/code&gt; or &lt;code&gt;column&lt;/code&gt; is out of bounds.
+ */
+<span class="del">final OperationParameter getParameter(final int row,    final int column,</span>
+                                      final int numRow, final int numCol)
+        throws IndexOutOfBoundsException
+{</pre></td>
+<td><pre> * @return The parameter descriptor for the specified matrix element.
+ * @throws IndexOutOfBoundsException if &lt;code&gt;row&lt;/code&gt; or &lt;code&gt;column&lt;/code&gt; is out of bounds.
+ */
+<span class="add">final ParameterDescriptor getParameter(final int row,    final int column,</span>
+                                      final int numRow, final int numCol)
+        throws IndexOutOfBoundsException
+{</pre></td></tr>
+<tr><td><pre>checkIndice("row",    row,    numRow);
+checkIndice("column", column, numCol);
+int index = -1;
+<span class="del">OperationParameter param;</span>
+if (row&lt;CACHE_SIZE &amp;&amp; column&lt;CACHE_SIZE) {
+    index = row*CACHE_SIZE + column;
+    param = parameters[index];</pre></td>
+<td><pre>checkIndice("row",    row,    numRow);
+checkIndice("column", column, numCol);
+int index = -1;
+<span class="add">ParameterDescriptor param;</span>
+if (row&lt;CACHE_SIZE &amp;&amp; column&lt;CACHE_SIZE) {
+    index = row*CACHE_SIZE + column;
+    param = parameters[index];</pre></td></tr>
+<tr><td><pre> * Note that this cache is shared by all MatrixParameters instance. There is no need
+ * to synchronize since it is not a big deal if the same parameter is constructed twice.
+ */
+<span class="del">param = new org.geotools.parameter.OperationParameter(prefix + row + separator + column,</span>
+<span class="del">        Double.TYPE, org.geotools.parameter.ParameterValue.wrap(row==column ? 1.0 : 0.0),</span>
+        null, null, Unit.ONE);
+if (index &gt;= 0) {
+    parameters[index] = param;</pre></td>
+<td><pre> * Note that this cache is shared by all MatrixParameters instance. There is no need
+ * to synchronize since it is not a big deal if the same parameter is constructed twice.
+ */
+<span class="add">param = new org.geotools.parameter.ParameterDescriptor(prefix + row + separator + column,</span>
+<span class="add">        Double.TYPE, org.geotools.parameter.Parameter.wrap(row==column ? 1.0 : 0.0),</span>
+        null, null, Unit.ONE);
+if (index &gt;= 0) {
+    parameters[index] = param;</pre></td></tr>
+<tr><td><pre>/**
+ * Returns the parameters in this group. The number or elements is inferred from the
+<span class="del"> * {@link org.geotools.parameter.OperationParameter#getDefaultValue default values}</span>
+ * given to the {@link #numRow} and {@link #numCol} parameters.
+ *
+ * @return The matrix parameters, including all elements.
+ */
+<span class="del">public final GeneralOperationParameter[] getParameters() {</span>
+    return getParameters(((Number) this.numRow.getDefaultValue()).intValue(),
+                         ((Number) this.numCol.getDefaultValue()).intValue());
+}</pre></td>
+<td><pre>/**
+ * Returns the parameters in this group. The number or elements is inferred from the
+<span class="add"> * {@link org.geotools.parameter.ParameterDescriptor#getDefaultValue default values}</span>
+ * given to the {@link #numRow} and {@link #numCol} parameters.
+ *
+ * @return The matrix parameters, including all elements.
+ */
+<span class="add">public final GeneralParameterDescriptor[] getParameters() {</span>
+    return getParameters(((Number) this.numRow.getDefaultValue()).intValue(),
+                         ((Number) this.numCol.getDefaultValue()).intValue());
+}</pre></td></tr>
+<tr><td><pre> * @param numCol The number of columns.
+ * @return The matrix parameters, including all elements.
+ */
+<span class="del">final GeneralOperationParameter[] getParameters(final int numRow, final int numCol) {</span>
+<span class="del">    final OperationParameter[] parameters = new OperationParameter[numRow*numCol + 2];</span>
+    int k = 0;
+    parameters[k++] = this.numRow;
+    parameters[k++] = this.numCol;</pre></td>
+<td><pre> * @param numCol The number of columns.
+ * @return The matrix parameters, including all elements.
+ */
+<span class="add">final GeneralParameterDescriptor[] getParameters(final int numRow, final int numCol) {</span>
+<span class="add">    final ParameterDescriptor[] parameters = new ParameterDescriptor[numRow*numCol + 2];</span>
+    int k = 0;
+    parameters[k++] = this.numRow;
+    parameters[k++] = this.numCol;</pre></td></tr>
+<tr><td><pre>    return ((MatrixParameterValues) parameters).getMatrix();
+}
+// Fallback on the general case (others implementations)
+<span class="del">final ParameterValue numRowParam = parameters.getValue(numRow.getName(null));</span>
+<span class="del">final ParameterValue numColParam = parameters.getValue(numCol.getName(null));</span>
+final int numRow = numRowParam.intValue();
+final int numCol = numColParam.intValue();
+final GeneralMatrix matrix = new GeneralMatrix(numRow, numCol);
+<span class="del">final GeneralParameterValue[] params = parameters.getValues();</span>
+if (params != null) {
+    for (int i=0; i&lt;params.length; i++) {
+        final GeneralParameterValue param = params[i];</pre></td>
+<td><pre>    return ((MatrixParameterValues) parameters).getMatrix();
+}
+// Fallback on the general case (others implementations)
+<span class="add">final ParameterValue numRowParam = parameters.parameter(numRow.getName().toString());</span>
+<span class="add">final ParameterValue numColParam = parameters.parameter(numCol.getName().toString());</span>
+final int numRow = numRowParam.intValue();
+final int numCol = numColParam.intValue();
+final GeneralMatrix matrix = new GeneralMatrix(numRow, numCol);
+<span class="add">final GeneralParameterValue[] params = Parameters.array( parameters );</span>
+if (params != null) {
+    for (int i=0; i&lt;params.length; i++) {
+        final GeneralParameterValue param = params[i];</pre></td></tr>
+<tr><td><pre>    continue;
+}
+RuntimeException cause = null;
+<span class="del">final String name = param.getDescriptor().getName(null);</span>
+if (name.regionMatches(true, 0, prefix, 0, prefix.length())) {
+    final int split = name.indexOf(separator, prefix.length());
+    if (split &gt;= 0) try {</pre></td>
+<td><pre>    continue;
+}
+RuntimeException cause = null;
+<span class="add">final String name = param.getDescriptor().getName().toString();</span>
+if (name.regionMatches(true, 0, prefix, 0, prefix.length())) {
+    final int split = name.indexOf(separator, prefix.length());
+    if (split &gt;= 0) try {</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/07846/MatrixParameterDescriptors.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/07846/MatrixParameterDescriptors.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/07857/MeasurementParameter.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07857/MeasurementParameter.xhtml?rev=1575895&view=auto
==============================================================================
--- sis/ip-review/rev/07857/MeasurementParameter.xhtml (added)
+++ sis/ip-review/rev/07857/MeasurementParameter.xhtml Mon Mar 10 10:38:40 2014
@@ -0,0 +1,318 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>MeasurementParameter changes for revisions 7705:7857</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>MeasurementParameter changes for revisions 7705:7857</h1>
+<p>In this commit:</p>
+<ul>
+  <li>Re-ordering of import statements. This change has been reverted.</li>
+  <li>Removal of some import statements. This change has been reverted
+      (the remover did not realized that some imports were used by javadoc).</li>
+  <li>Changes for renaming of GeoAPI interface: <code>OperationParameter</code> → <code>ParameterDescriptor</code>.
+      Reverting this changes causes compilation errors, which can be fixed only be re-applying the same change.</li>
+  <li>Class renaming: <code>ParameterRealValue</code> → <code>ParameterReal</code>. SIS uses different naming
+      convention. This class is renamed <code>MeasurementParameter</code>.</li>
+  <li><code>toString()</code> method implementation: this contribution has been removed from Geotk/SIS.
+      It is replaced by WKT 2 formatting.</li>
+</ul>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r7705:7857 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/parameter/FloatParameter.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 7705</th><th>Revision 7857</th></tr>
+<tr><td><pre> */
+package org.geotools.parameter;
+
+// J2SE dependencies
+import java.net.URL;
+<span class="del">import java.util.Set;</span>
+<span class="del">import java.util.Arrays;</span>
+<span class="del">import java.util.Locale;</span>
+import javax.units.Unit;
+<span class="del">import javax.units.SI;</span>
+<span class="del">import javax.units.NonSI;</span>
+<span class="del">import javax.units.Converter;</span>
+
+<span class="del">// OpenGIS dependencies</span>
+<span class="del">import org.opengis.util.CodeList;</span>
+<span class="del">import org.opengis.parameter.OperationParameter;</span>
+<span class="del">import org.opengis.parameter.GeneralOperationParameter;</span>
+import org.opengis.parameter.InvalidParameterTypeException;
+import org.opengis.parameter.InvalidParameterValueException;
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+<span class="del">import org.geotools.resources.cts.Resources;</span>
+<span class="del">import org.geotools.resources.cts.ResourceKeys;</span>
+
+<span class="del"></span>
+/**
+ * A parameter value as a real number. This class provides the same functionalities than
+<span class="del"> * {@link ParameterValue}, except that:</span>
+ * &lt;ul&gt;
+ *   &lt;li&gt;Values are always floating point numbers of type &lt;code&gt;double&lt;/code&gt;.&lt;/li&gt;
+<span class="del"> *   &lt;li&gt;Units are the same than the {@linkplain OperationParameter#getUnit default units}.&lt;/li&gt;</span>
+ * &lt;/ul&gt;
+ * When those conditions are meet, &lt;code&gt;ParameterRealValue&lt;/code&gt; is slightly more efficient
+ * than &lt;code&gt;ParameterValue&lt;/code&gt; since it avoid the creation of {@link Double} objects.</pre></td>
+<td><pre> */
+package org.geotools.parameter;
+
+<span class="add"></span>
+<span class="add">import org.opengis.parameter.ParameterDescriptor;</span>
+<span class="add"></span>
+// J2SE dependencies
+<span class="add">import java.lang.reflect.Array;</span>
+import java.net.URL;
+<span class="add"></span>
+import javax.units.Unit;
+
+<span class="add">import org.geotools.resources.Utilities;</span>
+<span class="add">import org.geotools.resources.cts.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.cts.Resources;</span>
+import org.opengis.parameter.InvalidParameterTypeException;
+import org.opengis.parameter.InvalidParameterValueException;
+
+
+/**
+ * A parameter value as a real number. This class provides the same functionalities than
+<span class="add"> * {@link Parameter}, except that:</span>
+ * &lt;ul&gt;
+ *   &lt;li&gt;Values are always floating point numbers of type &lt;code&gt;double&lt;/code&gt;.&lt;/li&gt;
+<span class="add"> *   &lt;li&gt;Units are the same than the {@linkplain ParameterDescriptor#getUnit default units}.&lt;/li&gt;</span>
+ * &lt;/ul&gt;
+ * When those conditions are meet, &lt;code&gt;ParameterRealValue&lt;/code&gt; is slightly more efficient
+ * than &lt;code&gt;ParameterValue&lt;/code&gt; since it avoid the creation of {@link Double} objects.</pre></td></tr>
+<tr><td><pre> * @version $Id$
+ * @author Martin Desruisseaux
+ *
+<span class="del"> * @see org.geotools.parameter.OperationParameter</span>
+<span class="del"> * @see org.geotools.parameter.ParameterValueGroup</span>
+ */
+<span class="del">public class ParameterRealValue extends GeneralParameterValue</span>
+                             implements org.opengis.parameter.ParameterValue
+{
+    /**</pre></td>
+<td><pre> * @version $Id$
+ * @author Martin Desruisseaux
+ *
+<span class="add"> * @see org.geotools.parameter.ParameterDescriptor</span>
+<span class="add"> * @see org.geotools.parameter.ParameterGroup</span>
+ */
+<span class="add">public class ParameterReal extends AbstractParameter</span>
+                             implements org.opengis.parameter.ParameterValue
+{
+    /**</pre></td></tr>
+<tr><td><pre>/**
+ * Construct a parameter from the specified descriptor. The descriptor
+<span class="del"> * {@linkplain org.geotools.parameter.OperationParameter#getValueClass() value class}</span>
+ * must be &lt;code&gt;{@linkplain Double}.class&lt;/code&gt;.
+ *
+ * @param  descriptor The abstract definition of this parameter.
+ * @throws IllegalArgumentException if the value class is not &lt;code&gt;Double.class&lt;/code&gt;.
+ */
+<span class="del">public ParameterRealValue(final OperationParameter descriptor) {</span>
+    super(descriptor);
+    final Class type = descriptor.getValueClass();
+    final Class expected = Double.class;</pre></td>
+<td><pre>/**
+ * Construct a parameter from the specified descriptor. The descriptor
+<span class="add"> * {@linkplain org.geotools.parameter.ParameterDescriptor#getValueClass() value class}</span>
+ * must be &lt;code&gt;{@linkplain Double}.class&lt;/code&gt;.
+ *
+ * @param  descriptor The abstract definition of this parameter.
+ * @throws IllegalArgumentException if the value class is not &lt;code&gt;Double.class&lt;/code&gt;.
+ */
+<span class="add">public ParameterReal(final ParameterDescriptor descriptor) {</span>
+    super(descriptor);
+    final Class type = descriptor.getValueClass();
+    final Class expected = Double.class;</pre></td></tr>
+<tr><td><pre> * @param  value The parameter value.
+ * @throws IllegalArgumentException if the value class is not &lt;code&gt;Double.class&lt;/code&gt;.
+ */
+<span class="del">public ParameterRealValue(final OperationParameter descriptor, final double value) {</span>
+    this(descriptor);
+    setValue(value);
+}</pre></td>
+<td><pre> * @param  value The parameter value.
+ * @throws IllegalArgumentException if the value class is not &lt;code&gt;Double.class&lt;/code&gt;.
+ */
+<span class="add">public ParameterReal(final ParameterDescriptor descriptor, final double value) {</span>
+    this(descriptor);
+    setValue(value);
+}</pre></td></tr>
+<tr><td><pre>/**
+ * Returns the unit of measure of the {@linkplain #doubleValue() parameter value}. The default
+<span class="del"> * implementation always delegates to {@link org.geotools.parameter.OperationParameter#getUnit}.</span>
+ *
+ * @return The unit of measure, or &lt;code&gt;null&lt;/code&gt; if none.
+ */
+public Unit getUnit() {
+<span class="del">    return ((OperationParameter) descriptor).getUnit();</span>
+}
+
+/**</pre></td>
+<td><pre>/**
+ * Returns the unit of measure of the {@linkplain #doubleValue() parameter value}. The default
+<span class="add"> * implementation always delegates to {@link org.geotools.parameter.ParameterDescriptor#getUnit}.</span>
+ *
+ * @return The unit of measure, or &lt;code&gt;null&lt;/code&gt; if none.
+ */
+public Unit getUnit() {
+<span class="add">    return ((ParameterDescriptor) descriptor).getUnit();</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre>final Unit thisUnit = getUnit();
+if (thisUnit == null) {
+    throw new IllegalStateException(Resources.format(
+<span class="del">          ResourceKeys.ERROR_UNITLESS_PARAMETER_$1, ParameterValue.getName(descriptor)));</span>
+}
+<span class="del">final int expectedID = ParameterValue.getUnitMessageID(thisUnit);</span>
+<span class="del">if (ParameterValue.getUnitMessageID(unit) != expectedID) {</span>
+    throw new IllegalArgumentException(Resources.format(expectedID, unit));
+}
+return thisUnit.getConverterTo(unit).convert(value);</pre></td>
+<td><pre>final Unit thisUnit = getUnit();
+if (thisUnit == null) {
+    throw new IllegalStateException(Resources.format(
+<span class="add">          ResourceKeys.ERROR_UNITLESS_PARAMETER_$1, Parameter.getName(descriptor)));</span>
+}
+<span class="add">final int expectedID = Parameter.getUnitMessageID(thisUnit);</span>
+<span class="add">if (Parameter.getUnitMessageID(unit) != expectedID) {</span>
+    throw new IllegalArgumentException(Resources.format(expectedID, unit));
+}
+return thisUnit.getConverterTo(unit).convert(value);</pre></td></tr>
+<tr><td><pre> */
+public URL valueFile() throws InvalidParameterTypeException {
+    throw new InvalidParameterTypeException(getClassTypeError(),
+<span class="del">              ParameterValue.getName(descriptor));</span>
+}
+
+/**</pre></td>
+<td><pre> */
+public URL valueFile() throws InvalidParameterTypeException {
+    throw new InvalidParameterTypeException(getClassTypeError(),
+<span class="add">              Parameter.getName(descriptor));</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> */
+public void setValue(double value, final Unit unit) throws InvalidParameterValueException {
+    ensureNonNull("unit", unit);
+<span class="del">    final Unit thisUnit = ((OperationParameter) descriptor).getUnit();</span>
+    if (thisUnit == null) {
+        throw new IllegalStateException(Resources.format(
+<span class="del">              ResourceKeys.ERROR_UNITLESS_PARAMETER_$1, ParameterValue.getName(descriptor)));</span>
+    }
+<span class="del">    final int expectedID = ParameterValue.getUnitMessageID(thisUnit);</span>
+<span class="del">    if (ParameterValue.getUnitMessageID(unit) != expectedID) {</span>
+        throw new IllegalArgumentException(Resources.format(expectedID, unit));
+    }
+    value = unit.getConverterTo(thisUnit).convert(value);
+<span class="del">    ParameterValue.ensureValidValue((OperationParameter) descriptor, new Double(value));</span>
+    this.value = value;
+}</pre></td>
+<td><pre> */
+public void setValue(double value, final Unit unit) throws InvalidParameterValueException {
+    ensureNonNull("unit", unit);
+<span class="add">    final Unit thisUnit = ((ParameterDescriptor) descriptor).getUnit();</span>
+    if (thisUnit == null) {
+        throw new IllegalStateException(Resources.format(
+<span class="add">              ResourceKeys.ERROR_UNITLESS_PARAMETER_$1, Parameter.getName(descriptor)));</span>
+    }
+<span class="add">    final int expectedID = Parameter.getUnitMessageID(thisUnit);</span>
+<span class="add">    if (Parameter.getUnitMessageID(unit) != expectedID) {</span>
+        throw new IllegalArgumentException(Resources.format(expectedID, unit));
+    }
+    value = unit.getConverterTo(thisUnit).convert(value);
+<span class="add">    Parameter.ensureValidValue((ParameterDescriptor) descriptor, new Double(value));</span>
+    this.value = value;
+}</pre></td></tr>
+<tr><td><pre> *         (for example a value out of range).
+ */
+public void setValue(final double value) throws InvalidParameterValueException {
+<span class="del">    ParameterValue.ensureValidValue((OperationParameter) descriptor, new Double(value));</span>
+    this.value = value;
+}</pre></td>
+<td><pre> *         (for example a value out of range).
+ */
+public void setValue(final double value) throws InvalidParameterValueException {
+<span class="add">    Parameter.ensureValidValue((ParameterDescriptor) descriptor, new Double(value));</span>
+    this.value = value;
+}</pre></td></tr>
+<tr><td><pre> *         the value is numeric and out of range).
+ */
+public void setValue(final Object value) throws InvalidParameterValueException {
+<span class="del">    ParameterValue.ensureValidValue((OperationParameter) descriptor, value);</span>
+    this.value = ((Number) value).doubleValue();
+}</pre></td>
+<td><pre> *         the value is numeric and out of range).
+ */
+public void setValue(final Object value) throws InvalidParameterValueException {
+<span class="add">    Parameter.ensureValidValue((ParameterDescriptor) descriptor, value);</span>
+    this.value = ((Number) value).doubleValue();
+}</pre></td></tr>
+<tr><td><pre> */
+public void setValue(double[] values, final Unit unit) throws InvalidParameterValueException {
+    throw new InvalidParameterTypeException(getClassTypeError(),
+<span class="del">              ParameterValue.getName(descriptor));</span>
+}
+
+/**</pre></td>
+<td><pre> */
+public void setValue(double[] values, final Unit unit) throws InvalidParameterValueException {
+    throw new InvalidParameterTypeException(getClassTypeError(),
+<span class="add">              Parameter.getName(descriptor));</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> */
+public boolean equals(final Object object) {
+    if (super.equals(object)) {
+<span class="del">        final ParameterRealValue that = (ParameterRealValue) object;</span>
+        return Double.doubleToLongBits(this.value) ==
+               Double.doubleToLongBits(that.value);
+    }</pre></td>
+<td><pre> */
+public boolean equals(final Object object) {
+    if (super.equals(object)) {
+<span class="add">        final ParameterReal that = (ParameterReal) object;</span>
+        return Double.doubleToLongBits(this.value) ==
+               Double.doubleToLongBits(that.value);
+    }</pre></td></tr>
+<tr><td><pre>        final long code = Double.doubleToLongBits(value);
+        return (int)code ^ (int)(code &gt;&gt;&gt; 32) + super.hashCode()*37;
+    }
+}</pre></td>
+<td><pre>        final long code = Double.doubleToLongBits(value);
+        return (int)code ^ (int)(code &gt;&gt;&gt; 32) + super.hashCode()*37;
+    }
+<span class="add">    public String toString() {</span>
+<span class="add">        String name = descriptor.getName().toString( null );</span>
+<span class="add">        Object value = getValue();</span>
+<span class="add"></span>
+<span class="add">        StringBuffer buf = new StringBuffer();</span>
+<span class="add">        buf.append( "[&lt;" );</span>
+<span class="add">        buf.append( descriptor.getName().toString( null ) );</span>
+<span class="add">        buf.append( "&gt; " );</span>
+<span class="add">        if( value == null ){</span>
+<span class="add">            buf.append( "null" );</span>
+}
+<span class="add">        else {</span>
+<span class="add">            buf.append( value );</span>
+<span class="add">        }</span>
+<span class="add">        buf.append("]");</span>
+<span class="add">        return buf.toString();</span>
+<span class="add">    }</span>
+<span class="add">}</span></pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/07857/MeasurementParameter.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/07857/MeasurementParameter.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/07860/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07860/HEADER.html?rev=1575895&view=auto
==============================================================================
--- sis/ip-review/rev/07860/HEADER.html (added)
+++ sis/ip-review/rev/07860/HEADER.html Mon Mar 10 10:38:40 2014
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 7860</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 7860</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2004-09-09</td></tr>
+  <tr><td><b>Message:</b></td><td>Make use of values() override for toWKT to pick up on (3 hour bug hunt)</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/07860/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/07860/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message