sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1521897 - in /sis: branches/JDK7/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/matrix/ ip-review/ ip-review/rev/10796/ ip-review/rev/20874/ ip-review/rev/24485/ ip-review/rev/24925/
Date Wed, 11 Sep 2013 15:10:21 GMT
Author: desruisseaux
Date: Wed Sep 11 15:10:20 2013
New Revision: 1521897

URL: http://svn.apache.org/r1521897
Log:
More IP review.

Added:
    sis/ip-review/GeneralMatrix.xhtml   (with props)
    sis/ip-review/Matrices.xhtml   (with props)
    sis/ip-review/rev/10796/GeneralMatrix.xhtml   (with props)
    sis/ip-review/rev/20874/GeneralMatrix.xhtml   (with props)
    sis/ip-review/rev/20874/Matrices.xhtml   (with props)
    sis/ip-review/rev/24485/GeneralMatrix.xhtml   (with props)
    sis/ip-review/rev/24925/GeneralMatrix.xhtml   (with props)
Modified:
    sis/branches/JDK7/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/matrix/Matrices.java

Modified: sis/branches/JDK7/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/matrix/Matrices.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK7/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/matrix/Matrices.java?rev=1521897&r1=1521896&r2=1521897&view=diff
==============================================================================
--- sis/branches/JDK7/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/matrix/Matrices.java
[UTF-8] (original)
+++ sis/branches/JDK7/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/matrix/Matrices.java
[UTF-8] Wed Sep 11 15:10:20 2013
@@ -59,13 +59,12 @@ public final class Matrices extends Stat
      *
      * @see MatrixSIS#isIdentity(double)
      */
-    public static boolean isIdentity(final Matrix matrix, double tolerance) {
+    public static boolean isIdentity(final Matrix matrix, final double tolerance) {
         final int numRow = matrix.getNumRow();
         final int numCol = matrix.getNumCol();
         if (numRow != numCol) {
             return false;
         }
-        tolerance = Math.abs(tolerance);
         for (int j=0; j<numRow; j++) {
             for (int i=0; i<numCol; i++) {
                 double e = matrix.getElement(j,i);

Added: sis/ip-review/GeneralMatrix.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/GeneralMatrix.xhtml?rev=1521897&view=auto
==============================================================================
--- sis/ip-review/GeneralMatrix.xhtml (added)
+++ sis/ip-review/GeneralMatrix.xhtml Wed Sep 11 15:10:20 2013
@@ -0,0 +1,65 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralMatrix history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralMatrix history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and
how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/matrix/GeneralMatrix.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright:
Update referencing headers</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed
my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few
tests show that the compiler always select the best overloaded flavor working on primitive
types (except if an argument is a boolean and the other a different primitive type). Updated
a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return
values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29769</td><td>2008-04-02</td><td>desruisseaux</td><td>Renamed
TestScript as ScriptRunner. Renamed XMatrix.epsilonEquals(...) as XMatrix.equals(...) in order
to avoid ambiguity with GMatrix.epsilonEquals(...) at compile time.</td></tr>
+<tr><td class="rev">29768</td><td>2008-04-02</td><td>desruisseaux</td><td>Upgrated
the metadata and referencing tests to JUnit 4.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">28267</td><td>2007-12-06</td><td>desruisseaux</td><td>GeoTools
trunk now build against GeoAPI 2.2-SNAPSHOT.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java
5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation;
rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a
href="rev/24925/GeneralMatrix.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">24581</td><td>2007-02-26</td><td>desruisseaux</td><td>Rewrote
'createLinearConversion' from scratch, since testing of 'South Oriented' cases of map projections
show some issues with the old implementation.</td></tr>
+<tr><td class="rev">24510</td><td>2007-02-19</td><td>desruisseaux</td><td>Moved
'isIdentity(double tolerance)' method from AbstractMathTransform to LinearTransform interface.</td></tr>
+<tr><td class="rev">24493</td><td>2007-02-17</td><td>desruisseaux</td><td>Cleaning
in 'isIdentity(double)' methods. Note that AbstractMathTransform.isIdentity(double) may move
in the LinearTransform interface, so we are marking them as deprecated for now and will create
a new LinearTransform.isIdentity(double) method in a next commit.</td></tr>
+<tr><td class="rev">24485</td><td>2007-02-16</td><td class="unav">simboss</td><td><a
href="rev/24485/GeneralMatrix.xhtml">-first bunch of changes for the alignment of trunk
with 2.3.x</a></td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a
href="rev/20874/GeneralMatrix.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17964</td><td>2006-02-10</td><td>desruisseaux</td><td>Slight
simplification in the management of affine transform in ReferencedCanvas2D.</td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged
the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15325</td><td>2005-08-13</td><td>desruisseaux</td><td>Created
a matrix package on top of vecmath / Fixed 'getPositionalAccuracy' issues</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction
of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare
branch for splitting main</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized
I18N resources</td></tr>
+<tr><td class="rev">13928</td><td>2005-05-30</td><td>desruisseaux</td><td>Fixed
GEOT-482; added a convenience method for loading a matrix from a file</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added
@since javadoc tag</td></tr>
+<tr><td class="rev">13836</td><td>2005-05-26</td><td>desruisseaux</td><td>Added
'Default' suffix to some CRS implementations: partial work</td></tr>
+<tr><td class="rev">11623</td><td>2005-02-24</td><td>desruisseaux</td><td>Completed
the port of 'separateInput'. 'separateOutput' remain to be done. Both are needed for GridGeometry
in the grid coverage package.</td></tr>
+<tr><td class="rev">11140</td><td>2005-02-06</td><td>desruisseaux</td><td>Work
in progres for GEOT-400 (CoordinateOperationFactory should create appropriate subclass of
CoordinateOperation)</td></tr>
+<tr><td class="rev">11007</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed
ArrayIndexOutOfBoundsException in transform(DirectPosition,DirectPosition)</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed
wrong encoding in main/src</td></tr>
+<tr><td class="rev">10944</td><td>2005-02-01</td><td>desruisseaux</td><td>Bug
fix in ProjectedCRS: axis swapping and units conversion were not correctly handled</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a
href="rev/10796/GeneralMatrix.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">9346</td><td>2004-11-30</td><td>desruisseaux</td><td>First
working version of CoordinateOperationFactory</td></tr>
+<tr><td class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing
CRS implementation</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/GeneralMatrix.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/GeneralMatrix.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/Matrices.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/Matrices.xhtml?rev=1521897&view=auto
==============================================================================
--- sis/ip-review/Matrices.xhtml (added)
+++ sis/ip-review/Matrices.xhtml Wed Sep 11 15:10:20 2013
@@ -0,0 +1,43 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Matrices history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Matrices history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and
how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/matrix/MatrixFactory.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright:
Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29879</td><td>2008-04-09</td><td>desruisseaux</td><td>More
propagation of hints. Javadoc clarification.</td></tr>
+<tr><td class="rev">29768</td><td>2008-04-02</td><td>desruisseaux</td><td>Upgrated
the metadata and referencing tests to JUnit 4.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">22710</td><td>2006-11-12</td><td>desruisseaux</td><td>Review
of coverage branch merge: In 'CategoryList', check for the 'no data' category name only if
the geophysics value is some NaN value. Moved XAffineTransform to a public place and added
methods for testing axis swapping, as a proposed replacement for 'GeneralGridGeometry.swapXY(CoordinateSystem)'
(replacement not yet done; waiting for the okay from the mailing list). In GeneralGridGeometry,
added methods for returning a math transform relative to some pixel corner instead of pixel
center, as a proposed replacement for the 'getTransform(...)' public static methods (I would
like to remove those static methods in order to keep the API a little bit more orthogonal).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a
href="rev/20874/Matrices.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged
the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15325</td><td>2005-08-13</td><td>desruisseaux</td><td>Created
a matrix package on top of vecmath / Fixed 'getPositionalAccuracy' issues</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/Matrices.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/Matrices.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/GeneralMatrix.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/GeneralMatrix.xhtml?rev=1521897&view=auto
==============================================================================
--- sis/ip-review/rev/10796/GeneralMatrix.xhtml (added)
+++ sis/ip-review/rev/10796/GeneralMatrix.xhtml Wed Sep 11 15:10:20 2013
@@ -0,0 +1,82 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralMatrix changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralMatrix changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto reformat</cite>"
tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite>
import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are
keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/matrix/GeneralMatrix.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.referencing.operation;
+
+// J2SE dependencies
+import java.text.NumberFormat;
+<span class="del">import java.text.FieldPosition;</span>
+<span class="del">import java.awt.geom.AffineTransform;</span>
+import javax.vecmath.GMatrix;
+
+<span class="del">// OpenGIS dependencies</span>
+import org.opengis.referencing.operation.Matrix;
+<span class="del">import org.opengis.referencing.cs.AxisDirection;</span>
+import org.opengis.spatialschema.geometry.Envelope;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+<span class="del">// Resources</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+<span class="del">import org.geotools.resources.cts.Resources;</span>
+<span class="del">import org.geotools.resources.cts.ResourceKeys;</span>
+
+<span class="del"></span>
+/**
+ * A two dimensional array of numbers. Row and column numbering begins with zero.
+ *</pre></td>
+<td><pre>package org.geotools.referencing.operation;
+
+// J2SE dependencies
+<span class="add">import java.awt.geom.AffineTransform;</span>
+<span class="add">import java.text.FieldPosition;</span>
+import java.text.NumberFormat;
+<span class="add"></span>
+import javax.vecmath.GMatrix;
+
+<span class="add">import org.geotools.resources.Utilities;</span>
+<span class="add">import org.geotools.resources.cts.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.cts.Resources;</span>
+<span class="add">import org.opengis.referencing.cs.AxisDirection;</span>
+import org.opengis.referencing.operation.Matrix;
+import org.opengis.spatialschema.geometry.Envelope;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+
+/**
+ * A two dimensional array of numbers. Row and column numbering begins with zero.
+ *</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/GeneralMatrix.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/GeneralMatrix.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/GeneralMatrix.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/GeneralMatrix.xhtml?rev=1521897&view=auto
==============================================================================
--- sis/ip-review/rev/20874/GeneralMatrix.xhtml (added)
+++ sis/ip-review/rev/20874/GeneralMatrix.xhtml Wed Sep 11 15:10:20 2013
@@ -0,0 +1,60 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralMatrix changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralMatrix changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option)
any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those
who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/matrix/GeneralMatrix.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free
Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+ */
+package org.geotools.referencing.operation.matrix;</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.referencing.operation.matrix;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/GeneralMatrix.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/GeneralMatrix.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/Matrices.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/Matrices.xhtml?rev=1521897&view=auto
==============================================================================
--- sis/ip-review/rev/20874/Matrices.xhtml (added)
+++ sis/ip-review/rev/20874/Matrices.xhtml Wed Sep 11 15:10:20 2013
@@ -0,0 +1,60 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Matrices changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Matrices changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option)
any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those
who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/matrix/MatrixFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2005, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2005, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free
Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+ */
+package org.geotools.referencing.operation.matrix;</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2005-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2005, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.referencing.operation.matrix;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/Matrices.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/Matrices.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24485/GeneralMatrix.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24485/GeneralMatrix.xhtml?rev=1521897&view=auto
==============================================================================
--- sis/ip-review/rev/24485/GeneralMatrix.xhtml (added)
+++ sis/ip-review/rev/24485/GeneralMatrix.xhtml Wed Sep 11 15:10:20 2013
@@ -0,0 +1,92 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralMatrix changes for revisions 24484:24485</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralMatrix changes for revisions 24484:24485</h1>
+<p>This commit is a copy-and-paste of the <code>isIdentity()</code> method
that existed prior this commit,
+modified for working as a static method instead than a member method and with the following
code added:</p>
+
+<blockquote><pre>tolerance = Math.abs(tolerance);
+...
+Math.abs(... - ...) > tolerance</pre></blockquote>
+
+<p>SIS has the same method in <code>Matrices</code>, with the <code>tolerance
= abs(tolerance)</code> removed
+for consistency with <code>equals(..., tolerance)</code> methods and the <code>abs(...)
&gt; tolerance</code>
+inverted to <code>!(abs(...) &lt;= tolerance)</code> for working with NaN.
Since this is not original work,
+having this method in SIS is okay.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r24484:24485 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/matrix/GeneralMatrix.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24484</th><th>Revision 24485</th></tr>
+<tr><td><pre>private static final long serialVersionUID = 8447482612423035360L;
+
+/**
+ * Constructs a square identity matrix of size {@code size}&amp;nbsp;&amp;times;&amp;nbsp;{@code
size}.
+ */
+public GeneralMatrix(final int size) {</pre></td>
+<td><pre>private static final long serialVersionUID = 8447482612423035360L;
+
+/**
+<span class="add"> * Defaul tolerance value for floating point comparisons.</span>
+<span class="add"> */</span>
+<span class="add">public static final double EPS = 1E-6;</span>
+<span class="add"></span>
+<span class="add">/**</span>
+ * Constructs a square identity matrix of size {@code size}&amp;nbsp;&amp;times;&amp;nbsp;{@code
size}.
+ */
+public GeneralMatrix(final int size) {</pre></td></tr>
+<tr><td><pre>    assert isAffine() : this;
+    return true;
+}
+<span class="del"></span>
+/**
+ * {@inheritDoc}
+ */
+public final void multiply(final Matrix matrix) {</pre></td>
+<td><pre>    assert isAffine() : this;
+    return true;
+}
+/**
+<span class="add"> * Returns {@code true} if this matrix is an identity matrix using
the provided tolerance.</span>
+<span class="add"> * @since 2.3.1</span>
+<span class="add"> */</span>
+<span class="add">public final boolean isIdentity(double tolerance) {</span>
+<span class="add">    return isIdentity(this, tolerance);</span>
+<span class="add">}</span>
+<span class="add">/**</span>
+<span class="add"> * Returns {@code true} if this matrix is an identity matrix using
the provided tolerance.</span>
+<span class="add"> * @since 2.3.1</span>
+<span class="add"> */</span>
+<span class="add">public final static boolean isIdentity(final XMatrix matrix,double
tolerance) {</span>
+<span class="add">    tolerance=Math.abs(tolerance);</span>
+<span class="add">    final int numRow = matrix.getNumRow();</span>
+<span class="add">    final int numCol = matrix.getNumCol();</span>
+<span class="add">    if (numRow != numCol) {</span>
+<span class="add">        return false;</span>
+<span class="add">    }</span>
+<span class="add">    for (int j=0; j&lt;numRow; j++) {</span>
+<span class="add">        for (int i=0; i&lt;numCol; i++) {</span>
+<span class="add">            if (Math.abs(matrix.getElement(j,i)- (i==j ? 1 : 0))&gt;tolerance)
{</span>
+<span class="add">                return false;</span>
+<span class="add">            }</span>
+<span class="add">        }</span>
+<span class="add">    }</span>
+<span class="add">    assert matrix.isAffine() : matrix;</span>
+<span class="add">    return true;</span>
+<span class="add">}</span>
+<span class="add">/**</span>
+ * {@inheritDoc}
+ */
+public final void multiply(final Matrix matrix) {</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24485/GeneralMatrix.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24485/GeneralMatrix.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24925/GeneralMatrix.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/GeneralMatrix.xhtml?rev=1521897&view=auto
==============================================================================
--- sis/ip-review/rev/24925/GeneralMatrix.xhtml (added)
+++ sis/ip-review/rev/24925/GeneralMatrix.xhtml Wed Sep 11 15:10:20 2013
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralMatrix changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralMatrix changes for revisions 24924:24925</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/matrix/GeneralMatrix.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>// OpenGIS dependencies
+import org.opengis.referencing.cs.AxisDirection;
+import org.opengis.referencing.operation.Matrix;
+<span class="del">import org.opengis.spatialschema.geometry.Envelope;</span>
+<span class="del">import org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.io.LineFormat;</pre></td>
+<td><pre>// OpenGIS dependencies
+import org.opengis.referencing.cs.AxisDirection;
+import org.opengis.referencing.operation.Matrix;
+<span class="add">import org.opengis.geometry.Envelope;</span>
+<span class="add">import org.opengis.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.io.LineFormat;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24925/GeneralMatrix.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24925/GeneralMatrix.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message