sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1518979 - in /sis/ip-review: ./ rev/07848/ rev/10796/ rev/20874/ rev/25050/ rev/28657/
Date Fri, 30 Aug 2013 14:33:01 GMT
Author: desruisseaux
Date: Fri Aug 30 14:33:00 2013
New Revision: 1518979

URL: http://svn.apache.org/r1518979
Log:
Added IP review.

Added:
    sis/ip-review/ReferencingUtilities.xhtml   (with props)
    sis/ip-review/rev/07848/ReferencingUtilities.xhtml   (with props)
    sis/ip-review/rev/10796/ReferencingUtilities.xhtml   (with props)
    sis/ip-review/rev/20874/ReferencingUtilities.xhtml   (with props)
    sis/ip-review/rev/25050/
    sis/ip-review/rev/25050/HEADER.html   (with props)
    sis/ip-review/rev/25050/ReferencingUtilities.xhtml   (with props)
    sis/ip-review/rev/28657/
    sis/ip-review/rev/28657/HEADER.html   (with props)
    sis/ip-review/rev/28657/ReferencingUtilities.xhtml   (with props)
Modified:
    sis/ip-review/rev/07848/AbstractDirectPosition.xhtml

Added: sis/ip-review/ReferencingUtilities.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/ReferencingUtilities.xhtml?rev=1518979&view=auto
==============================================================================
--- sis/ip-review/ReferencingUtilities.xhtml (added)
+++ sis/ip-review/ReferencingUtilities.xhtml Fri Aug 30 14:33:00 2013
@@ -0,0 +1,92 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ReferencingUtilities history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ReferencingUtilities history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and
how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/resources/CRSUtilities.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31487</td><td>2008-09-10</td><td>desruisseaux</td><td>GEOT-1720:
CRS.getHorizontalCRS(...) now handles 3D GeographicCRS.</td></tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated
from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations
in the process.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30639</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: cleanup library/referencing</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright:
Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29416</td><td>2008-02-21</td><td>desruisseaux</td><td>Added
a GeneralEnvelope.validate() method for restricting an envelope to its CRS or CS domain of
validity, wraping around longitude if needed. Relaxed the transformations between GeographicBoundingBox
and Envelope, accepting GeographicCRS that are not necessarly WGS84.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28669</td><td>2008-01-09</td><td>desruisseaux</td><td>Removed
deprecated DataSource interface in order to simplify the EPSG factory code, for making debugging
easier. Fixed a bug in the search for authority name as a side effect of GEOT-1659 investigation.
Code formatting.</td></tr>
+<tr><td class="rev">28657</td><td>2008-01-09</td><td class="unav">danieler</td><td><a
href="rev/28657/ReferencingUtilities.xhtml">-substituted usage of CRSUtilities.getCRS2D
with CRS.getHorizontalCRS where it applied</a></td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">28521</td><td>2007-12-27</td><td>desruisseaux</td><td>Type
safety.</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More
MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated
utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java
5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation;
rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">27995</td><td>2007-11-22</td><td>desruisseaux</td><td>More
generics type, and moved two methods from ReferencingFactoryContainer to GeoAPI MathTransformFactory
interface. Note that the build fails in the arcsde module for a reason that seems unrelated
to this work.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">25787</td><td>2007-06-10</td><td>desruisseaux</td><td>Use
CRS.transform(CoordinateOperation, ...) instead of CRS.transform(MathTransform, ...) where
applicable.</td></tr>
+<tr><td class="rev">25050</td><td>2007-04-06</td><td class="unav">jgarnett</td><td><a
href="rev/25050/ReferencingUtilities.xhtml">example of custom file based TestSutie, copy
JTS parsing code over to unsupported/geometry</a></td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a
href="rev/25050/ReferencingUtilities.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">22452</td><td>2006-10-28</td><td>desruisseaux</td><td>Moved
some methods from CRSUtilities to CRS (GEOT-547).</td></tr>
+<tr><td class="rev">22443</td><td>2006-10-27</td><td>desruisseaux</td><td>Splitted
referencing, extracting metadata in their own module (GEOT-983). As a side effect, replaced
some calls of CRSUtilities.foo(...) by CRS.foo(...).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a
href="rev/20874/ReferencingUtilities.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17890</td><td>2006-02-06</td><td>desruisseaux</td><td>First
draft of a partial port of J2D-renderer to a GO-1 implementation.</td></tr>
+<tr><td class="rev">17720</td><td>2006-01-24</td><td>desruisseaux</td><td>Method
signature change in GeneraleEnvelope before 2.2-RC1 release. This is a compatible change if
the user recompile its code.</td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">17460</td><td>2006-01-05</td><td>desruisseaux</td><td>Added
support classes for GO-1 implementation. Partial Maven 2 fixes for the new module/renderer
module.</td></tr>
+<tr><td class="rev">15736</td><td>2005-09-19</td><td>desruisseaux</td><td>Added
convenience methods or constructors</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged
the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15299</td><td>2005-08-11</td><td>desruisseaux</td><td>Added
CRS.VALID.AREA formula in OpenOffice addin / Added convenience methods for fetching GeographicBoundingBox
and for fetching coordinate operation accuracy / Bug fix for parameter using dimensionless
unit in EPGS database</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction
of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare
branch for splitting main</td></tr>
+<tr><td class="rev">15231</td><td>2005-08-08</td><td>desruisseaux</td><td>Added
NodataFilter and GradientMagnitude operation / Various bug fixes</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized
I18N resources</td></tr>
+<tr><td class="rev">14581</td><td>2005-06-22</td><td>desruisseaux</td><td>Implemented
South-Orientated transverse mercator / more GEOT-589 work</td></tr>
+<tr><td class="rev">14564</td><td>2005-06-20</td><td>desruisseaux</td><td>Initial
implementation of GEOT-589. Partially tested, more tests to come</td></tr>
+<tr><td class="rev">14298</td><td>2005-06-13</td><td>desruisseaux</td><td>Removed
some GridCoverage-related deprecated API / Initial (incomplete) port of OperationJAI</td></tr>
+<tr><td class="rev">14205</td><td>2005-06-09</td><td>desruisseaux</td><td>Updated
to GeoAPI 2.0 final release</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added
@since javadoc tag</td></tr>
+<tr><td class="rev">13907</td><td>2005-05-28</td><td>desruisseaux</td><td>More
additions of 'Default' prefix in CRS package</td></tr>
+<tr><td class="rev">13906</td><td>2005-05-28</td><td>desruisseaux</td><td>Renamed
some 'Default' prefix as 'Abstract'</td></tr>
+<tr><td class="rev">13836</td><td>2005-05-26</td><td>desruisseaux</td><td>Added
'Default' suffix to some CRS implementations: partial work</td></tr>
+<tr><td class="rev">13762</td><td>2005-05-24</td><td>desruisseaux</td><td>Added
DefiningConversion</td></tr>
+<tr><td class="rev">13045</td><td>2005-04-10</td><td>desruisseaux</td><td>More
CoverageStack work</td></tr>
+<tr><td class="rev">13016</td><td>2005-04-07</td><td>desruisseaux</td><td>Moved
'org.geotools.io.image' to 'org.geotools.image.io' / Continue work on CoverageStack</td></tr>
+<tr><td class="rev">12985</td><td>2005-04-06</td><td>desruisseaux</td><td>First
draft of CoverageStack</td></tr>
+<tr><td class="rev">12965</td><td>2005-04-05</td><td>desruisseaux</td><td>Merged
'factory-hints' branch r12393:12964 into the trunk. Added 'getImplementationHints()' method
after the merge into Factory implementations, in order to get Geotools to compile with Maven.</td></tr>
+<tr><td class="rev">12953</td><td>2005-04-03</td><td>desruisseaux</td><td>Check
for inclusion before to add an Envelope</td></tr>
+<tr><td class="rev">12952</td><td>2005-04-03</td><td>desruisseaux</td><td>Updated
metadata implementation for GeoAPI changes (GEO-51 and GEO-56)</td></tr>
+<tr><td class="rev">11960</td><td>2005-03-10</td><td>desruisseaux</td><td>First
draft of GridCoverage 'resampler' operation port</td></tr>
+<tr><td class="rev">11549</td><td>2005-02-22</td><td>desruisseaux</td><td>Initial
cleaning for restarting GridCoverage work</td></tr>
+<tr><td class="rev">11212</td><td>2005-02-09</td><td>desruisseaux</td><td>Initial
work on Z-values handling</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed
wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a
href="rev/10796/ReferencingUtilities.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">10469</td><td>2005-01-11</td><td>desruisseaux</td><td>Replaced
calls to 'getDim[Source|Target]' by 'get[Source|Target]Dimensions</td></tr>
+<tr><td class="rev">8218</td><td>2004-09-27</td><td>desruisseaux</td><td>Back
to work: clean up</td></tr>
+<tr><td class="rev">7848</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a
href="rev/07848/ReferencingUtilities.xhtml">round 2 of sync with geoapi</a></td></tr>
+<tr><td class="rev">6888</td><td>2004-07-14</td><td>desruisseaux</td><td>Update
for GeoAPI changes (Info -->  IdentifiedObject)</td></tr>
+<tr><td class="rev">6536</td><td>2004-06-25</td><td>desruisseaux</td><td>Added
SingleCRS class / Renamed ObliqueCartesianCS as AffineCS / Moved Position as super-interface
for DirectPosition and Point</td></tr>
+<tr><td class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing
CRS implementation</td></tr>
+<tr><td class="rev">6265</td><td>2004-05-31</td><td>desruisseaux</td><td>Added
an initial Coverage implementation</td></tr>
+<tr><td class="rev">6150</td><td>2004-05-25</td><td>desruisseaux</td><td>Moved
geometry related resources in the org.geotools.resources.geometry package</td></tr>
+<tr><td class="rev">6100</td><td>2004-05-23</td><td>desruisseaux</td><td>Partial
implementation of GeoAPI referencing package</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Modified: sis/ip-review/rev/07848/AbstractDirectPosition.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07848/AbstractDirectPosition.xhtml?rev=1518979&r1=1518978&r2=1518979&view=diff
==============================================================================
--- sis/ip-review/rev/07848/AbstractDirectPosition.xhtml (original)
+++ sis/ip-review/rev/07848/AbstractDirectPosition.xhtml Fri Aug 30 14:33:00 2013
@@ -12,7 +12,7 @@
       <h1>Abstract &amp; GeneralDirectPosition changes for revisions 7847:7848</h1>
 <p>This commit removes the <code>Locale</code> argument in the call to
<code>getName(…)</code>,
 as a consequence of the removal of that argument in the GeoAPI method signature.
-This is a trivial change which can not be done in any other way (except omission of the call
to <code>toString()</code>,
+This is a trivial change which can hardly be done in other way (except omission of the call
to <code>toString()</code>,
 which Geotk/SIS does), since keeping that argument causes a compilation error.</p>
 <p><b>Command line:</b></p>
 <blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r7847:7848 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractDirectPosition.java</code></blockquote>

Added: sis/ip-review/rev/07848/ReferencingUtilities.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07848/ReferencingUtilities.xhtml?rev=1518979&view=auto
==============================================================================
--- sis/ip-review/rev/07848/ReferencingUtilities.xhtml (added)
+++ sis/ip-review/rev/07848/ReferencingUtilities.xhtml Fri Aug 30 14:33:00 2013
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ReferencingUtilities changes for revisions 7847:7848</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ReferencingUtilities changes for revisions 7847:7848</h1>
+<p>This commit removes the <code>Locale</code> argument in the call to
<code>getName(…)</code>,
+as a consequence of the removal of that argument in the GeoAPI method signature.
+This is a trivial change which can hardly be done in other way (except omission of the call
to <code>toString()</code>,
+which Geotk/SIS does), since keeping that argument causes a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r7847:7848 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/resources/CRSUtilities.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 7847</th><th>Revision 7848</th></tr>
+<tr><td><pre>if (!(crs instanceof CompoundCRS)) {
+    throw new TransformException(Resources.format(
+            ResourceKeys.ERROR_CANT_REDUCE_TO_TWO_DIMENSIONS_$1,
+<span class="del">            crs.getName(Locale.getDefault())));</span>
+}
+final CoordinateReferenceSystem[] c= ((CompoundCRS)crs).getCoordinateReferenceSystems();
+if (c.length == 0) {</pre></td>
+<td><pre>if (!(crs instanceof CompoundCRS)) {
+    throw new TransformException(Resources.format(
+            ResourceKeys.ERROR_CANT_REDUCE_TO_TWO_DIMENSIONS_$1,
+<span class="add">            crs.getName().toString()));</span>
+}
+final CoordinateReferenceSystem[] c= ((CompoundCRS)crs).getCoordinateReferenceSystems();
+if (c.length == 0) {</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/07848/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/07848/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/ReferencingUtilities.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/ReferencingUtilities.xhtml?rev=1518979&view=auto
==============================================================================
--- sis/ip-review/rev/10796/ReferencingUtilities.xhtml (added)
+++ sis/ip-review/rev/10796/ReferencingUtilities.xhtml Fri Aug 30 14:33:00 2013
@@ -0,0 +1,138 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ReferencingUtilities changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ReferencingUtilities changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto reformat</cite>"
tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite>
import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are
keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/resources/CRSUtilities.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.resources;
+
+// J2SE dependencies
+<span class="del">import java.util.Locale;</span>
+import java.awt.geom.Point2D;
+import java.awt.geom.Rectangle2D;
+<span class="del">import java.awt.geom.AffineTransform;</span>
+
+<span class="del">// OpenGIS dependencies</span>
+<span class="del">import org.opengis.metadata.extent.*;</span>
+<span class="del">import org.opengis.referencing.cs.*;</span>
+<span class="del">import org.opengis.referencing.crs.*;</span>
+<span class="del">import org.opengis.referencing.datum.*;</span>
+<span class="del">import org.opengis.referencing.operation.MathTransform;</span>
+<span class="del">import org.opengis.referencing.operation.MathTransform2D;</span>
+<span class="del">import org.opengis.referencing.operation.TransformException;</span>
+<span class="del">import org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+<span class="del">import org.opengis.spatialschema.geometry.Envelope;</span>
+<span class="del"></span>
+<span class="del">// Geotools dependencies</span>
+import org.geotools.measure.Latitude;
+import org.geotools.measure.Longitude;
+<span class="del">import org.geotools.measure.AngleFormat;</span>
+<span class="del">import org.geotools.geometry.GeneralEnvelope;</span>
+<span class="del">import org.geotools.geometry.GeneralDirectPosition;</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+import org.geotools.resources.cts.Resources;
+<span class="del">import org.geotools.resources.cts.ResourceKeys;</span>
+import org.geotools.resources.geometry.XRectangle2D;
+import org.geotools.util.UnsupportedImplementationException;
+
+
+/**</pre></td>
+<td><pre>package org.geotools.resources;
+
+// J2SE dependencies
+<span class="add">import java.awt.geom.AffineTransform;</span>
+import java.awt.geom.Point2D;
+import java.awt.geom.Rectangle2D;
+
+<span class="add">import org.geotools.geometry.GeneralDirectPosition;</span>
+<span class="add">import org.geotools.geometry.GeneralEnvelope;</span>
+<span class="add">import org.geotools.measure.AngleFormat;</span>
+import org.geotools.measure.Latitude;
+import org.geotools.measure.Longitude;
+<span class="add">import org.geotools.resources.cts.ResourceKeys;</span>
+import org.geotools.resources.cts.Resources;
+import org.geotools.resources.geometry.XRectangle2D;
+import org.geotools.util.UnsupportedImplementationException;
+<span class="add">import org.opengis.metadata.extent.BoundingPolygon;</span>
+<span class="add">import org.opengis.metadata.extent.Extent;</span>
+<span class="add">import org.opengis.metadata.extent.GeographicBoundingBox;</span>
+<span class="add">import org.opengis.metadata.extent.GeographicExtent;</span>
+<span class="add">import org.opengis.referencing.crs.CompoundCRS;</span>
+<span class="add">import org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+<span class="add">import org.opengis.referencing.crs.GeographicCRS;</span>
+<span class="add">import org.opengis.referencing.crs.ProjectedCRS;</span>
+<span class="add">import org.opengis.referencing.crs.SingleCRS;</span>
+<span class="add">import org.opengis.referencing.crs.TemporalCRS;</span>
+<span class="add">import org.opengis.referencing.crs.VerticalCRS;</span>
+<span class="add">import org.opengis.referencing.cs.AxisDirection;</span>
+<span class="add">import org.opengis.referencing.cs.CoordinateSystem;</span>
+<span class="add">import org.opengis.referencing.cs.CoordinateSystemAxis;</span>
+<span class="add">import org.opengis.referencing.datum.Datum;</span>
+<span class="add">import org.opengis.referencing.datum.Ellipsoid;</span>
+<span class="add">import org.opengis.referencing.datum.GeodeticDatum;</span>
+<span class="add">import org.opengis.referencing.operation.MathTransform;</span>
+<span class="add">import org.opengis.referencing.operation.MathTransform2D;</span>
+<span class="add">import org.opengis.referencing.operation.TransformException;</span>
+<span class="add">import org.opengis.spatialschema.geometry.Envelope;</span>
+<span class="add">import org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+
+
+/**</pre></td></tr>
+<tr><td><pre>/**
+ * Returns a character string for the specified geographic area. The string will have the
+<span class="del"> * form "45°00.00'N-50°00.00'N 30°00.00'E-40°00.00'E".
If a map projection is required in</span>
+ * order to obtain this representation, it will be automatically applied.  This string is
+ * mostly used for debugging purpose.
+ *</pre></td>
+<td><pre>/**
+ * Returns a character string for the specified geographic area. The string will have the
+<span class="add"> * form "45�00.00'N-50�00.00'N 30�00.00'E-40�00.00'E".
If a map projection is required in</span>
+ * order to obtain this representation, it will be automatically applied.  This string is
+ * mostly used for debugging purpose.
+ *</pre></td></tr>
+<tr><td><pre>//                               createFromCoordinateSystems(cs,
GeographicCoordinateSystem.WGS84);
+//                bounds = transform((MathTransform2D) tr.getMathTransform(), bounds, null);
+            }
+<span class="del">            final AngleFormat fmt = new AngleFormat("DD°MM.m'");</span>
+            buffer = fmt.format(new  Latitude(bounds.getMinY()), buffer, null); buffer.append('-');
+            buffer = fmt.format(new  Latitude(bounds.getMaxY()), buffer, null); buffer.append('
');
+            buffer = fmt.format(new Longitude(bounds.getMinX()), buffer, null); buffer.append('-');</pre></td>
+<td><pre>//                               createFromCoordinateSystems(cs, GeographicCoordinateSystem.WGS84);
+//                bounds = transform((MathTransform2D) tr.getMathTransform(), bounds, null);
+            }
+<span class="add">            final AngleFormat fmt = new AngleFormat("DD�MM.m'");</span>
+            buffer = fmt.format(new  Latitude(bounds.getMinY()), buffer, null); buffer.append('-');
+            buffer = fmt.format(new  Latitude(bounds.getMaxY()), buffer, null); buffer.append('
');
+            buffer = fmt.format(new Longitude(bounds.getMinX()), buffer, null); buffer.append('-');</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/ReferencingUtilities.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/ReferencingUtilities.xhtml?rev=1518979&view=auto
==============================================================================
--- sis/ip-review/rev/20874/ReferencingUtilities.xhtml (added)
+++ sis/ip-review/rev/20874/ReferencingUtilities.xhtml Fri Aug 30 14:33:00 2013
@@ -0,0 +1,50 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ReferencingUtilities changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ReferencingUtilities changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option)
any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those
who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/resources/CRSUtilities.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty
of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free
Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+ */
+package org.geotools.resources;</pre></td>
+<td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.resources;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/HEADER.html?rev=1518979&view=auto
==============================================================================
--- sis/ip-review/rev/25050/HEADER.html (added)
+++ sis/ip-review/rev/25050/HEADER.html Fri Aug 30 14:33:00 2013
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 25050</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 25050</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-04-06</td></tr>
+  <tr><td><b>Message:</b></td><td>example of custom file
based TestSutie, copy JTS parsing code over to unsupported/geometry</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/ReferencingUtilities.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/ReferencingUtilities.xhtml?rev=1518979&view=auto
==============================================================================
--- sis/ip-review/rev/25050/ReferencingUtilities.xhtml (added)
+++ sis/ip-review/rev/25050/ReferencingUtilities.xhtml Fri Aug 30 14:33:00 2013
@@ -0,0 +1,69 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ReferencingUtilities changes for revisions 24924:25050</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ReferencingUtilities changes for revisions 24924:25050</h1>
+<p>Changes in the import statements were driven by a GeoAPI change - there is not way
to do otherwise.
+Changes in <code>FactoryFinder</code> were also driven by a classname change
(this time in GeoTools),
+but is expected to be irrelevant for Apache SIS since we plan to use dependency injection
instead.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r24924:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/resources/CRSUtilities.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 25050</th></tr>
+<tr><td><pre>import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransform2D;
+import org.opengis.referencing.operation.TransformException;
+<span class="del">import org.opengis.spatialschema.geometry.Envelope;</span>
+<span class="del">import org.opengis.spatialschema.geometry.DirectPosition;</span>
+<span class="del">import org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.geometry.GeneralDirectPosition;</pre></td>
+<td><pre>import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransform2D;
+import org.opengis.referencing.operation.TransformException;
+<span class="add">import org.opengis.geometry.Envelope;</span>
+<span class="add">import org.opengis.geometry.DirectPosition;</span>
+<span class="add">import org.opengis.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.geometry.GeneralDirectPosition;</pre></td></tr>
+<tr><td><pre>import org.geotools.measure.Latitude;
+import org.geotools.measure.Longitude;
+import org.geotools.referencing.CRS;
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+import org.geotools.referencing.crs.DefaultGeographicCRS;
+import org.geotools.resources.i18n.ErrorKeys;
+import org.geotools.resources.i18n.Errors;</pre></td>
+<td><pre>import org.geotools.measure.Latitude;
+import org.geotools.measure.Longitude;
+import org.geotools.referencing.CRS;
+<span class="add">import org.geotools.referencing.ReferencingFactoryFinder;</span>
+import org.geotools.referencing.crs.DefaultGeographicCRS;
+import org.geotools.resources.i18n.ErrorKeys;
+import org.geotools.resources.i18n.Errors;</pre></td></tr>
+<tr><td><pre>try {
+    crs = getCRS2D(crs);
+    if (!CRS.equalsIgnoreMetadata(DefaultGeographicCRS.WGS84, crs)) {
+<span class="del">        final CoordinateOperation op = FactoryFinder.getCoordinateOperationFactory(null)</span>
+                .createOperation(crs, DefaultGeographicCRS.WGS84);
+        bounds = CRS.transform((MathTransform2D) op.getMathTransform(), bounds, null);
+    }</pre></td>
+<td><pre>try {
+    crs = getCRS2D(crs);
+    if (!CRS.equalsIgnoreMetadata(DefaultGeographicCRS.WGS84, crs)) {
+<span class="add">        final CoordinateOperation op = ReferencingFactoryFinder.getCoordinateOperationFactory(null)</span>
+                .createOperation(crs, DefaultGeographicCRS.WGS84);
+        bounds = CRS.transform((MathTransform2D) op.getMathTransform(), bounds, null);
+    }</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/28657/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/28657/HEADER.html?rev=1518979&view=auto
==============================================================================
--- sis/ip-review/rev/28657/HEADER.html (added)
+++ sis/ip-review/rev/28657/HEADER.html Fri Aug 30 14:33:00 2013
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 28657</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 28657</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>danieler</td></tr>
+  <tr><td><b>Date:</b></td><td>2008-01-09</td></tr>
+  <tr><td><b>Message:</b></td><td>-substituted usage
of CRSUtilities.getCRS2D with CRS.getHorizontalCRS where it applied</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/28657/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/28657/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/28657/ReferencingUtilities.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/28657/ReferencingUtilities.xhtml?rev=1518979&view=auto
==============================================================================
--- sis/ip-review/rev/28657/ReferencingUtilities.xhtml (added)
+++ sis/ip-review/rev/28657/ReferencingUtilities.xhtml Fri Aug 30 14:33:00 2013
@@ -0,0 +1,59 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ReferencingUtilities changes for revisions 28656:28657</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ReferencingUtilities changes for revisions 28656:28657</h1>
+<p>This change has not been retained.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r28656:28657 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/resources/CRSUtilities.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 28656</th><th>Revision 28657</th></tr>
+<tr><td><pre>Exception exception;
+final StringBuffer buffer = new StringBuffer();
+try {
+<span class="del">    crs = getCRS2D(crs);</span>
+<span class="del">    if (!CRS.equalsIgnoreMetadata(DefaultGeographicCRS.WGS84, crs))
{</span>
+        final CoordinateOperation op = ReferencingFactoryFinder.getCoordinateOperationFactory(null)
+<span class="del">                .createOperation(crs, DefaultGeographicCRS.WGS84);</span>
+        bounds = CRS.transform(op, bounds, null);
+    }
+    final AngleFormat fmt = new AngleFormat("DD°MM.m'");</pre></td>
+<td><pre>Exception exception;
+final StringBuffer buffer = new StringBuffer();
+try {
+<span class="add">    final CoordinateReferenceSystem crs2D = CRS.getHorizontalCRS(crs);</span>
+<span class="add"> if(crs2D==null)</span>
+<span class="add">  exception=new UnsupportedOperationException(</span>
+<span class="add">         Errors.format(</span>
+<span class="add">                     ErrorKeys.CANT_SEPARATE_CRS_$1,crs));</span>
+<span class="add"> else{</span>
+<span class="add">        if (!CRS.equalsIgnoreMetadata(DefaultGeographicCRS.WGS84,
crs2D)) {</span>
+        final CoordinateOperation op = ReferencingFactoryFinder.getCoordinateOperationFactory(null)
+<span class="add">                    .createOperation(crs2D, DefaultGeographicCRS.WGS84);</span>
+        bounds = CRS.transform(op, bounds, null);
+    }
+    final AngleFormat fmt = new AngleFormat("DD°MM.m'");</pre></td></tr>
+<tr><td><pre>    fmt.format(new Longitude(bounds.getMinX()), buffer, null).append('-');
+    fmt.format(new Longitude(bounds.getMaxX()), buffer, null);
+    return buffer.toString();
+} catch (TransformException e) {
+    exception = e;
+} catch (FactoryException e) {</pre></td>
+<td><pre>    fmt.format(new Longitude(bounds.getMinX()), buffer, null).append('-');
+    fmt.format(new Longitude(bounds.getMaxX()), buffer, null);
+    return buffer.toString();
+<span class="add"> }</span>
+} catch (TransformException e) {
+    exception = e;
+} catch (FactoryException e) {</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/28657/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/28657/ReferencingUtilities.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message