sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Desruisseaux (JIRA)" <>
Subject [jira] [Resolved] (SIS-90) Metadata objects should use EnumSet and CodeListSet when appropriate
Date Mon, 01 Jul 2013 11:40:20 GMT


Martin Desruisseaux resolved SIS-90.

       Resolution: Fixed
    Fix Version/s:     (was: 0.4)

Fixed on 0.3, except for the hole in the "unmodifiable" state which is documented in a separated
JIRA task (SIS-107).
> Metadata objects should use EnumSet and CodeListSet when appropriate
> --------------------------------------------------------------------
>                 Key: SIS-90
>                 URL:
>             Project: Spatial Information Systems
>          Issue Type: Improvement
>          Components: Metadata
>            Reporter: Martin Desruisseaux
>            Priority: Minor
>             Fix For: 0.3
> {{ModifiableMetadata}} selects the appropriate collection type for a given element type
by invoking the protected {{collectionType(Class)}} method. Current implementation returns
only {{List.class}} or {{Set.class}}. Consequently {{HashSet}} is used for all {{Enum}} and
{{CodeList}} collections.
> The {{EnumSet}} and {{CodeListSet}} are more efficient (more compact and presumed faster)
implementations of {{Set}} for enumerations and code lists, so they should be used. Note that
since {{EnumSet}} is mutable, we will need to clone it before to return such set from a unmodifiable
> We could also move {{collectionType(Class)}} method from {{ModifiableMetadata}} to {{StandardMetadata}}
instead, in order to control the collection type policy in a single place instead than for
each metadata object.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message