sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris A. Mattmann (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SIS-95) Explicitly specify Typed extends Object parameters in FallbackConverterTest
Date Tue, 02 Apr 2013 20:29:17 GMT
Chris A. Mattmann created SIS-95:
------------------------------------

             Summary: Explicitly specify Typed extends Object parameters in FallbackConverterTest
                 Key: SIS-95
                 URL: https://issues.apache.org/jira/browse/SIS-95
             Project: Spatial Information Systems
          Issue Type: Bug
          Components: Utilities
            Reporter: Chris A. Mattmann
            Priority: Minor
             Fix For: 0.3


I found this bug by trying to open up the latest version of SIS inside of Eclipse. Per [~desruisseaux]:

{quote}
Eclipse doesn't use the Sun/Oracle javac compiler. It uses its own compiler instead, which
doesn't behave exactly the same way. I have seen 3 or 4 similar situations in the past, where
the Eclipse and Sun compilers were in disagreement. However I do not remember having seen
a case where the Eclipse compiler was right...

In this particular case, the Eclipse compiler complains about that line:

{code:java}
c = FallbackConverter.merge(c, new StringConverter.Long());
{code}

The 'merge' method expect two arguments of type:

{code:java}
   ObjectConverter<S, ? extends T>
   ObjectConverter<S, ? extends T>
{code}

The types that we are actually providing are:
{code:java}
   ObjectConverter<String, ?>
   ObjectConverter<String, Long>
{code}

If we understand <?> as synonymous to <? extends Object>, the above is
right as far as I can see. But maybe Eclipse wants it to be specified
explicitly. could you try to edit line 63 please, replacing the
<String,?> by <String,? extends Object>.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message