sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1457741 [1/2] - in /sis/ip-review: ./ rev/10796/ rev/20874/ rev/24868/ rev/24897/ rev/24925/ rev/24965/ rev/24990/
Date Mon, 18 Mar 2013 12:45:30 GMT
Author: desruisseaux
Date: Mon Mar 18 12:45:29 2013
New Revision: 1457741

URL: http://svn.apache.org/r1457741
Log:
Some IP reviews for the identification package.

Added:
    sis/ip-review/DefaultBrowseGraphic.xhtml   (with props)
    sis/ip-review/DefaultDataIdentification.xhtml   (with props)
    sis/ip-review/DefaultKeywords.xhtml   (with props)
    sis/ip-review/DefaultRepresentativeFraction.xhtml   (with props)
    sis/ip-review/DefaultResolution.xhtml   (with props)
    sis/ip-review/rev/10796/DefaultBrowseGraphic.xhtml   (with props)
    sis/ip-review/rev/10796/DefaultDataIdentification.xhtml   (with props)
    sis/ip-review/rev/10796/DefaultKeywords.xhtml   (with props)
    sis/ip-review/rev/10796/DefaultResolution.xhtml   (with props)
    sis/ip-review/rev/20874/DefaultBrowseGraphic.xhtml   (with props)
    sis/ip-review/rev/20874/DefaultDataIdentification.xhtml   (with props)
    sis/ip-review/rev/20874/DefaultKeywords.xhtml   (with props)
    sis/ip-review/rev/20874/DefaultResolution.xhtml   (with props)
    sis/ip-review/rev/24868/DefaultResolution.xhtml   (with props)
    sis/ip-review/rev/24897/
    sis/ip-review/rev/24897/DefaultRepresentativeFraction.xhtml   (with props)
    sis/ip-review/rev/24897/HEADER.html   (with props)
    sis/ip-review/rev/24925/DefaultDataIdentification.xhtml   (with props)
    sis/ip-review/rev/24965/
    sis/ip-review/rev/24965/DefaultRepresentativeFraction.xhtml   (with props)
    sis/ip-review/rev/24965/HEADER.html   (with props)
    sis/ip-review/rev/24990/DefaultResolution.xhtml   (with props)

Added: sis/ip-review/DefaultBrowseGraphic.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/DefaultBrowseGraphic.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/DefaultBrowseGraphic.xhtml (added)
+++ sis/ip-review/DefaultBrowseGraphic.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,55 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultBrowseGraphic history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultBrowseGraphic history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/BrowseGraphicImpl.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31557</td><td>2008-09-19</td><td>desruisseaux</td><td>Removed JAXB annotations.</td></tr>
+<tr><td class="rev">30640</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/metadata, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30519</td><td>2008-06-05</td><td>acuster</td><td>Metadata header cleanup and copyright review.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29742</td><td>2008-03-31</td><td>cedricbr</td><td>Adapters for URI.</td></tr>
+<tr><td class="rev">29685</td><td>2008-03-20</td><td>cedricbr</td><td>Third part of the JAXB proposal, the annotations.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28057</td><td>2007-11-26</td><td>desruisseaux</td><td>More parameterized types, which revealed an other bug: getResults() should returns a Collection of Record, not Double.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">25189</td><td>2007-04-17</td><td>desruisseaux</td><td>Removed useless import statements.</td></tr>
+<tr><td class="rev">25175</td><td>2007-04-16</td><td>desruisseaux</td><td>Removed 'equals', 'hashCode', 'toString' and 'freeze' methods from every metadata implementation. They are now implemented by generic methods inherited from AbstractMetadata, which perform their work using Java reflection. This way we avoid lot of redundancy, some errors introduced by maintenance ('equals' method not updated in the way they should), more systematic implementations (espcially for the 'toString' method, which was not implemented at all for a majority of metadata), more support for future introduction of other metadata standards than ISO 19115, etc. The cost is more runtime overhead, but it still possible to provide custom implementations for 'equals' and 'hashCode' only in the class that appear to be bottleneck, if we want.</td></tr>
+<tr><td class="rev">22443</td><td>2006-10-27</td><td>desruisseaux</td><td>Splitted referencing, extracting metadata in their own module (GEOT-983). As a side effect, replaced some calls of CRSUtilities.foo(...) by CRS.foo(...).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/DefaultBrowseGraphic.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13752</td><td>2005-05-23</td><td>desruisseaux</td><td>Added the 'Impl' suffix to direct implementations of all metadata interfaces; deprecated the old implementations (not yet deleted).</td></tr>
+<tr><td class="rev">12958</td><td>2005-04-04</td><td>desruisseaux</td><td>Constructor tuning in metadata</td></tr>
+<tr><td class="rev">12952</td><td>2005-04-03</td><td>desruisseaux</td><td>Updated metadata implementation for GeoAPI changes (GEO-51 and GEO-56)</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/DefaultBrowseGraphic.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">9120</td><td>2004-11-15</td><td>desruisseaux</td><td>New metadata implementations</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/DefaultBrowseGraphic.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/DefaultBrowseGraphic.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/DefaultDataIdentification.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/DefaultDataIdentification.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/DefaultDataIdentification.xhtml (added)
+++ sis/ip-review/DefaultDataIdentification.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,62 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultDataIdentification history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultDataIdentification history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/DataIdentificationImpl.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31557</td><td>2008-09-19</td><td>desruisseaux</td><td>Removed JAXB annotations.</td></tr>
+<tr><td class="rev">30967</td><td>2008-07-09</td><td>desruisseaux</td><td>Removed deprecated methods.</td></tr>
+<tr><td class="rev">30640</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/metadata, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30519</td><td>2008-06-05</td><td>acuster</td><td>Metadata header cleanup and copyright review.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">30041</td><td>2008-04-25</td><td>desruisseaux</td><td>Renamed 'isMarshalling(boolean)' as 'xmlMarshalling(boolean)' and added a warning telling that it is a problematic patch. Removed the synchronized keyword in AbstractMetadata.equals(Object) as a fix of GEOT-1777).</td></tr>
+<tr><td class="rev">29761</td><td>2008-04-02</td><td>cedricbr</td><td>Manage the Distance tag with JAXB. Some code refactoring.</td></tr>
+<tr><td class="rev">29690</td><td>2008-03-20</td><td>cedricbr</td><td>Correction for the build failure.</td></tr>
+<tr><td class="rev">29685</td><td>2008-03-20</td><td>cedricbr</td><td>Third part of the JAXB proposal, the annotations.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28057</td><td>2007-11-26</td><td>desruisseaux</td><td>More parameterized types, which revealed an other bug: getResults() should returns a Collection of Record, not Double.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">25193</td><td>2007-04-18</td><td>desruisseaux</td><td>Fixed some typos in metadata revealed by the new ISOTest. First draft of hints review (still in process).</td></tr>
+<tr><td class="rev">25189</td><td>2007-04-17</td><td>desruisseaux</td><td>Removed useless import statements.</td></tr>
+<tr><td class="rev">25175</td><td>2007-04-16</td><td>desruisseaux</td><td>Removed 'equals', 'hashCode', 'toString' and 'freeze' methods from every metadata implementation. They are now implemented by generic methods inherited from AbstractMetadata, which perform their work using Java reflection. This way we avoid lot of redundancy, some errors introduced by maintenance ('equals' method not updated in the way they should), more systematic implementations (espcially for the 'toString' method, which was not implemented at all for a majority of metadata), more support for future introduction of other metadata standards than ISO 19115, etc. The cost is more runtime overhead, but it still possible to provide custom implementations for 'equals' and 'hashCode' only in the class that appear to be bottleneck, if we want.</td></tr>
+<tr><td class="rev">25098</td><td>2007-04-10</td><td>desruisseaux</td><td>Review of metadata changes.</td></tr>
+<tr><td class="rev">25070</td><td>2007-04-09</td><td>desruisseaux</td><td>Fixed usage of primitive wrappers in some method bodies.</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a href="rev/24925/DefaultDataIdentification.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">22443</td><td>2006-10-27</td><td>desruisseaux</td><td>Splitted referencing, extracting metadata in their own module (GEOT-983). As a side effect, replaced some calls of CRSUtilities.foo(...) by CRS.foo(...).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/DefaultDataIdentification.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13752</td><td>2005-05-23</td><td>desruisseaux</td><td>Added the 'Impl' suffix to direct implementations of all metadata interfaces; deprecated the old implementations (not yet deleted).</td></tr>
+<tr><td class="rev">12958</td><td>2005-04-04</td><td>desruisseaux</td><td>Constructor tuning in metadata</td></tr>
+<tr><td class="rev">12952</td><td>2005-04-03</td><td>desruisseaux</td><td>Updated metadata implementation for GeoAPI changes (GEO-51 and GEO-56)</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/DefaultDataIdentification.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">9120</td><td>2004-11-15</td><td>desruisseaux</td><td>New metadata implementations</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/DefaultDataIdentification.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/DefaultDataIdentification.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/DefaultKeywords.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/DefaultKeywords.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/DefaultKeywords.xhtml (added)
+++ sis/ip-review/DefaultKeywords.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,54 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultKeywords history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultKeywords history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/KeywordsImpl.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31557</td><td>2008-09-19</td><td>desruisseaux</td><td>Removed JAXB annotations.</td></tr>
+<tr><td class="rev">30640</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/metadata, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30519</td><td>2008-06-05</td><td>acuster</td><td>Metadata header cleanup and copyright review.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29685</td><td>2008-03-20</td><td>cedricbr</td><td>Third part of the JAXB proposal, the annotations.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28057</td><td>2007-11-26</td><td>desruisseaux</td><td>More parameterized types, which revealed an other bug: getResults() should returns a Collection of Record, not Double.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">25189</td><td>2007-04-17</td><td>desruisseaux</td><td>Removed useless import statements.</td></tr>
+<tr><td class="rev">25175</td><td>2007-04-16</td><td>desruisseaux</td><td>Removed 'equals', 'hashCode', 'toString' and 'freeze' methods from every metadata implementation. They are now implemented by generic methods inherited from AbstractMetadata, which perform their work using Java reflection. This way we avoid lot of redundancy, some errors introduced by maintenance ('equals' method not updated in the way they should), more systematic implementations (espcially for the 'toString' method, which was not implemented at all for a majority of metadata), more support for future introduction of other metadata standards than ISO 19115, etc. The cost is more runtime overhead, but it still possible to provide custom implementations for 'equals' and 'hashCode' only in the class that appear to be bottleneck, if we want.</td></tr>
+<tr><td class="rev">22443</td><td>2006-10-27</td><td>desruisseaux</td><td>Splitted referencing, extracting metadata in their own module (GEOT-983). As a side effect, replaced some calls of CRSUtilities.foo(...) by CRS.foo(...).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/DefaultKeywords.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13752</td><td>2005-05-23</td><td>desruisseaux</td><td>Added the 'Impl' suffix to direct implementations of all metadata interfaces; deprecated the old implementations (not yet deleted).</td></tr>
+<tr><td class="rev">12958</td><td>2005-04-04</td><td>desruisseaux</td><td>Constructor tuning in metadata</td></tr>
+<tr><td class="rev">12952</td><td>2005-04-03</td><td>desruisseaux</td><td>Updated metadata implementation for GeoAPI changes (GEO-51 and GEO-56)</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/DefaultKeywords.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">9120</td><td>2004-11-15</td><td>desruisseaux</td><td>New metadata implementations</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/DefaultKeywords.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/DefaultKeywords.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/DefaultRepresentativeFraction.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/DefaultRepresentativeFraction.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/DefaultRepresentativeFraction.xhtml (added)
+++ sis/ip-review/DefaultRepresentativeFraction.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,46 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultRepresentativeFraction history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultRepresentativeFraction history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:24897 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/RepresentativeFractionImpl.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31557</td><td>2008-09-19</td><td>desruisseaux</td><td>Removed JAXB annotations.</td></tr>
+<tr><td class="rev">30963</td><td>2008-07-09</td><td>cedricbr</td><td>Annotate the getter instead of the variable, since the denominator is now a long value, and that matches with the return type of the getter.</td></tr>
+<tr><td class="rev">30959</td><td>2008-07-08</td><td>desruisseaux</td><td>Update for a minor GeoAPI change (return type of RepresentativeFraction.getDenominator() changed from 'int' to 'long').</td></tr>
+<tr><td class="rev">30640</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/metadata, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30519</td><td>2008-06-05</td><td>acuster</td><td>Metadata header cleanup and copyright review.</td></tr>
+<tr><td class="rev">30517</td><td>2008-06-05</td><td>cedricbr</td><td>Reformating and more javadoc for the script. By the way, move an annotation from the getter to the variable, to solve a mistake between int and long at marshalling / unmarshalling time</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29685</td><td>2008-03-20</td><td>cedricbr</td><td>Third part of the JAXB proposal, the annotations.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28057</td><td>2007-11-26</td><td>desruisseaux</td><td>More parameterized types, which revealed an other bug: getResults() should returns a Collection of Record, not Double.</td></tr>
+<tr><td class="rev">27864</td><td>2007-11-12</td><td>desruisseaux</td><td>Use more Java 5 features. Also fixed a test which failed randomly.</td></tr>
+<tr><td class="rev">25098</td><td>2007-04-10</td><td>desruisseaux</td><td>Review of metadata changes.</td></tr>
+<tr><td class="rev">25075</td><td>2007-04-09</td><td>desruisseaux</td><td>Fixed SVN properties.</td></tr>
+<tr><td class="rev">25070</td><td>2007-04-09</td><td>desruisseaux</td><td>Fixed usage of primitive wrappers in some method bodies.</td></tr>
+<tr><td class="rev">24965</td><td>2007-03-29</td><td class="unav">jgarnett</td><td><a href="rev/24965/DefaultRepresentativeFraction.xhtml">updated with toScale method</a></td></tr>
+<tr><td class="rev">24924</td><td>2007-03-27</td><td>desruisseaux</td><td>Allows Factories.addFactoryIteratorProvider(...) to work even after FactoryRegistry instantiation. Minor cleaning in metadata.</td></tr>
+<tr><td class="rev">24897</td><td>2007-03-23</td><td class="unav">jgarnett</td><td><a href="rev/24897/DefaultRepresentativeFraction.xhtml">now with more number</a></td></tr>
+<tr><td class="rev">24868</td><td>2007-03-22</td><td class="unav">jgarnett</td><td><a href="rev/24897/DefaultRepresentativeFraction.xhtml">clean up metadata and referencing in response to GEO-93</a></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/DefaultRepresentativeFraction.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/DefaultRepresentativeFraction.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/DefaultResolution.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/DefaultResolution.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/DefaultResolution.xhtml (added)
+++ sis/ip-review/DefaultResolution.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,61 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultResolution history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultResolution history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/ResolutionImpl.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31557</td><td>2008-09-19</td><td>desruisseaux</td><td>Removed JAXB annotations.</td></tr>
+<tr><td class="rev">30967</td><td>2008-07-09</td><td>desruisseaux</td><td>Removed deprecated methods.</td></tr>
+<tr><td class="rev">30640</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/metadata, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30519</td><td>2008-06-05</td><td>acuster</td><td>Metadata header cleanup and copyright review.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29761</td><td>2008-04-02</td><td>cedricbr</td><td>Manage the Distance tag with JAXB. Some code refactoring.</td></tr>
+<tr><td class="rev">29685</td><td>2008-03-20</td><td>cedricbr</td><td>Third part of the JAXB proposal, the annotations.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28057</td><td>2007-11-26</td><td>desruisseaux</td><td>More parameterized types, which revealed an other bug: getResults() should returns a Collection of Record, not Double.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">25189</td><td>2007-04-17</td><td>desruisseaux</td><td>Removed useless import statements.</td></tr>
+<tr><td class="rev">25175</td><td>2007-04-16</td><td>desruisseaux</td><td>Removed 'equals', 'hashCode', 'toString' and 'freeze' methods from every metadata implementation. They are now implemented by generic methods inherited from AbstractMetadata, which perform their work using Java reflection. This way we avoid lot of redundancy, some errors introduced by maintenance ('equals' method not updated in the way they should), more systematic implementations (espcially for the 'toString' method, which was not implemented at all for a majority of metadata), more support for future introduction of other metadata standards than ISO 19115, etc. The cost is more runtime overhead, but it still possible to provide custom implementations for 'equals' and 'hashCode' only in the class that appear to be bottleneck, if we want.</td></tr>
+<tr><td class="rev">25098</td><td>2007-04-10</td><td>desruisseaux</td><td>Review of metadata changes.</td></tr>
+<tr><td class="rev">24990</td><td>2007-04-03</td><td class="unav">chorner</td><td><a href="rev/24990/DefaultResolution.xhtml">Metadata; corrections after review of r24868</a></td></tr>
+<tr><td class="rev">24973</td><td>2007-03-30</td><td class="unav">chorner</td><td><a href="rev/24990/DefaultResolution.xhtml">GEO-93: GeoTools/GeoAPI ISO 19115 Metadata synchronization</a></td></tr>
+<tr><td class="rev">24924</td><td>2007-03-27</td><td>desruisseaux</td><td>Allows Factories.addFactoryIteratorProvider(...) to work even after FactoryRegistry instantiation. Minor cleaning in metadata.</td></tr>
+<tr><td class="rev">24868</td><td>2007-03-22</td><td class="unav">jgarnett</td><td><a href="rev/24868/DefaultResolution.xhtml">clean up metadata and referencing in response to GEO-93</a></td></tr>
+<tr><td class="rev">22443</td><td>2006-10-27</td><td>desruisseaux</td><td>Splitted referencing, extracting metadata in their own module (GEOT-983). As a side effect, replaced some calls of CRSUtilities.foo(...) by CRS.foo(...).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/DefaultResolution.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13752</td><td>2005-05-23</td><td>desruisseaux</td><td>Added the 'Impl' suffix to direct implementations of all metadata interfaces; deprecated the old implementations (not yet deleted).</td></tr>
+<tr><td class="rev">12958</td><td>2005-04-04</td><td>desruisseaux</td><td>Constructor tuning in metadata</td></tr>
+<tr><td class="rev">12952</td><td>2005-04-03</td><td>desruisseaux</td><td>Updated metadata implementation for GeoAPI changes (GEO-51 and GEO-56)</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/DefaultResolution.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">9120</td><td>2004-11-15</td><td>desruisseaux</td><td>New metadata implementations</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/DefaultResolution.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/DefaultResolution.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/DefaultBrowseGraphic.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/DefaultBrowseGraphic.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/10796/DefaultBrowseGraphic.xhtml (added)
+++ sis/ip-review/rev/10796/DefaultBrowseGraphic.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,73 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultBrowseGraphic changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultBrowseGraphic changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto reformat</cite>" tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/BrowseGraphicImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2004, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2004, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>// J2SE direct dependencies
+import java.net.URL;
+
+<span class="del">// OpenGIS direct dependencies</span>
+<span class="del">import org.opengis.util.InternationalString;</span>
+<span class="del"></span>
+<span class="del">// Geotools dependencies</span>
+import org.geotools.metadata.MetadataEntity;
+import org.geotools.resources.Utilities;
+
+
+/**</pre></td>
+<td><pre>// J2SE direct dependencies
+import java.net.URL;
+
+import org.geotools.metadata.MetadataEntity;
+import org.geotools.resources.Utilities;
+<span class="add">import org.opengis.util.InternationalString;</span>
+
+
+/**</pre></td></tr>
+<tr><td><pre> *
+ * @version $Id$
+ * @author Martin Desruisseaux
+<span class="del"> * @author Touraïvane</span>
+ */
+public class BrowseGraphic extends MetadataEntity
+        implements org.opengis.metadata.identification.BrowseGraphic</pre></td>
+<td><pre> *
+ * @version $Id$
+ * @author Martin Desruisseaux
+<span class="add"> * @author Toura�vane</span>
+ */
+public class BrowseGraphic extends MetadataEntity
+        implements org.opengis.metadata.identification.BrowseGraphic</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/DefaultBrowseGraphic.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/DefaultBrowseGraphic.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/DefaultDataIdentification.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/DefaultDataIdentification.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/10796/DefaultDataIdentification.xhtml (added)
+++ sis/ip-review/rev/10796/DefaultDataIdentification.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,140 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultDataIdentification changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultDataIdentification changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto reformat</cite>" tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/DataIdentificationImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2004, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2004, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.metadata.identification;
+
+// J2SE direct dependencies
+<span class="del">import java.util.Set;</span>
+import java.util.Collections;
+import java.util.Locale;
+
+<span class="del">// OpenGIS direct dependencies</span>
+<span class="del">// OpenGIS direct dependencies</span>
+import org.opengis.metadata.extent.Extent;
+import org.opengis.metadata.extent.GeographicBoundingBox;
+<span class="del">import org.opengis.metadata.extent.GeographicDescription;</span>
+import org.opengis.metadata.spatial.SpatialRepresentationType;
+<span class="del">import org.opengis.metadata.identification.TopicCategory;</span>
+<span class="del">import org.opengis.metadata.identification.Resolution;</span>
+import org.opengis.util.InternationalString;
+<span class="del">import org.opengis.metadata.citation.Citation;</span>
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.metadata.MetadataEntity;</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+<span class="del">import org.geotools.util.CheckedHashSet;</span>
+
+<span class="del"></span>
+/**
+ * Information required to identify a dataset.
+ *
+ * @version $Id$
+ * @author Martin Desruisseaux
+<span class="del"> * @author Touraïvane</span>
+ */
+public class DataIdentification extends Identification
+        implements org.opengis.metadata.identification.DataIdentification</pre></td>
+<td><pre>package org.geotools.metadata.identification;
+
+// J2SE direct dependencies
+import java.util.Collections;
+import java.util.Locale;
+<span class="add">import java.util.Set;</span>
+
+<span class="add">import org.geotools.resources.Utilities;</span>
+<span class="add">import org.geotools.util.CheckedHashSet;</span>
+<span class="add">import org.opengis.metadata.citation.Citation;</span>
+import org.opengis.metadata.extent.Extent;
+import org.opengis.metadata.extent.GeographicBoundingBox;
+<span class="add">import org.opengis.metadata.identification.Resolution;</span>
+<span class="add">import org.opengis.metadata.identification.TopicCategory;</span>
+import org.opengis.metadata.spatial.SpatialRepresentationType;
+import org.opengis.util.InternationalString;
+
+
+/**
+ * Information required to identify a dataset.
+ *
+ * @version $Id$
+ * @author Martin Desruisseaux
+<span class="add"> * @author Toura�vane</span>
+ */
+public class DataIdentification extends Identification
+        implements org.opengis.metadata.identification.DataIdentification</pre></td></tr>
+<tr><td><pre>private Set geographicDescription;
+
+/**
+<span class="del"> * Description of the dataset in the producer’s processing environment, including items</span>
+ * such as the software, the computer operating system, file name, and the dataset size
+ */
+private InternationalString environmentDescription;</pre></td>
+<td><pre>private Set geographicDescription;
+
+/**
+<span class="add"> * Description of the dataset in the producer�s processing environment, including items</span>
+ * such as the software, the computer operating system, file name, and the dataset size
+ */
+private InternationalString environmentDescription;</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Description of the dataset in the producer’s processing environment, including items</span>
+ * such as the software, the computer operating system, file name, and the dataset size.
+ */
+public InternationalString getEnvironmentDescription() {</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Description of the dataset in the producer�s processing environment, including items</span>
+ * such as the software, the computer operating system, file name, and the dataset size.
+ */
+public InternationalString getEnvironmentDescription() {</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Set the description of the dataset in the producer’s processing environment.</span>
+ */
+public synchronized void setEnvironmentDescription(final InternationalString newValue)  {
+    checkWritePermission();</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Set the description of the dataset in the producer�s processing environment.</span>
+ */
+public synchronized void setEnvironmentDescription(final InternationalString newValue)  {
+    checkWritePermission();</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/DefaultDataIdentification.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/DefaultDataIdentification.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/DefaultKeywords.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/DefaultKeywords.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/10796/DefaultKeywords.xhtml (added)
+++ sis/ip-review/rev/10796/DefaultKeywords.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,79 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultKeywords changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultKeywords changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto reformat</cite>" tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/KeywordsImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2004, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2004, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>// J2SE direct dependencies
+import java.util.List;
+
+<span class="del">// OpenGIS direct dependencies</span>
+<span class="del">import org.opengis.util.InternationalString;</span>
+<span class="del">import org.opengis.metadata.citation.Citation;</span>
+<span class="del">import org.opengis.metadata.identification.KeywordType;</span>
+<span class="del"></span>
+<span class="del">// Geotools dependencies</span>
+import org.geotools.metadata.MetadataEntity;
+import org.geotools.resources.Utilities;
+import org.geotools.util.CheckedArrayList;
+
+
+/**</pre></td>
+<td><pre>// J2SE direct dependencies
+import java.util.List;
+
+import org.geotools.metadata.MetadataEntity;
+import org.geotools.resources.Utilities;
+import org.geotools.util.CheckedArrayList;
+<span class="add">import org.opengis.metadata.citation.Citation;</span>
+<span class="add">import org.opengis.metadata.identification.KeywordType;</span>
+<span class="add">import org.opengis.util.InternationalString;</span>
+
+
+/**</pre></td></tr>
+<tr><td><pre> *
+ * @version $Id$
+ * @author Martin Desruisseaux
+<span class="del"> * @author Touraïvane</span>
+ */
+public class Keywords extends MetadataEntity
+        implements org.opengis.metadata.identification.Keywords</pre></td>
+<td><pre> *
+ * @version $Id$
+ * @author Martin Desruisseaux
+<span class="add"> * @author Toura�vane</span>
+ */
+public class Keywords extends MetadataEntity
+        implements org.opengis.metadata.identification.Keywords</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/DefaultKeywords.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/DefaultKeywords.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/DefaultResolution.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/DefaultResolution.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/10796/DefaultResolution.xhtml (added)
+++ sis/ip-review/rev/10796/DefaultResolution.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,70 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultResolution changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultResolution changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto reformat</cite>" tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/ResolutionImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2004, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2004, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.metadata.identification;
+
+// OpenGIS direct dependencies
+<span class="del">import org.opengis.util.InternationalString;</span>
+<span class="del"></span>
+<span class="del">// Geotools dependencies</span>
+import org.geotools.metadata.MetadataEntity;
+<span class="del">import org.geotools.resources.Utilities;</span>
+
+
+/**</pre></td>
+<td><pre>package org.geotools.metadata.identification;
+
+// OpenGIS direct dependencies
+import org.geotools.metadata.MetadataEntity;
+
+
+/**</pre></td></tr>
+<tr><td><pre> *
+ * @version $Id$
+ * @author Martin Desruisseaux
+<span class="del"> * @author Touraïvane</span>
+ */
+public class Resolution extends MetadataEntity
+        implements org.opengis.metadata.identification.Resolution</pre></td>
+<td><pre> *
+ * @version $Id$
+ * @author Martin Desruisseaux
+<span class="add"> * @author Toura�vane</span>
+ */
+public class Resolution extends MetadataEntity
+        implements org.opengis.metadata.identification.Resolution</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/DefaultResolution.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/DefaultResolution.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/DefaultBrowseGraphic.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/DefaultBrowseGraphic.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/20874/DefaultBrowseGraphic.xhtml (added)
+++ sis/ip-review/rev/20874/DefaultBrowseGraphic.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,64 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultBrowseGraphic changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultBrowseGraphic changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option) any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/BrowseGraphicImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+<span class="del"> *</span>
+ *    This package contains documentation from OpenGIS specifications.
+ *    OpenGIS consortium's work is fully acknowledged here.
+ */</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2004-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+ *    This package contains documentation from OpenGIS specifications.
+ *    OpenGIS consortium's work is fully acknowledged here.
+ */</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/DefaultBrowseGraphic.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/DefaultBrowseGraphic.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/DefaultDataIdentification.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/DefaultDataIdentification.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/20874/DefaultDataIdentification.xhtml (added)
+++ sis/ip-review/rev/20874/DefaultDataIdentification.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,64 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultDataIdentification changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultDataIdentification changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option) any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/DataIdentificationImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+<span class="del"> *</span>
+ *    This package contains documentation from OpenGIS specifications.
+ *    OpenGIS consortium's work is fully acknowledged here.
+ */</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2004-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+ *    This package contains documentation from OpenGIS specifications.
+ *    OpenGIS consortium's work is fully acknowledged here.
+ */</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/DefaultDataIdentification.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/DefaultDataIdentification.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/DefaultKeywords.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/DefaultKeywords.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/20874/DefaultKeywords.xhtml (added)
+++ sis/ip-review/rev/20874/DefaultKeywords.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,64 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultKeywords changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultKeywords changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option) any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/KeywordsImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+<span class="del"> *</span>
+ *    This package contains documentation from OpenGIS specifications.
+ *    OpenGIS consortium's work is fully acknowledged here.
+ */</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2004-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+ *    This package contains documentation from OpenGIS specifications.
+ *    OpenGIS consortium's work is fully acknowledged here.
+ */</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/DefaultKeywords.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/DefaultKeywords.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/DefaultResolution.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/DefaultResolution.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/20874/DefaultResolution.xhtml (added)
+++ sis/ip-review/rev/20874/DefaultResolution.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,64 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultResolution changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultResolution changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option) any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/ResolutionImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+<span class="del"> *</span>
+ *    This package contains documentation from OpenGIS specifications.
+ *    OpenGIS consortium's work is fully acknowledged here.
+ */</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2004-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+ *    This package contains documentation from OpenGIS specifications.
+ *    OpenGIS consortium's work is fully acknowledged here.
+ */</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/DefaultResolution.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/DefaultResolution.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24868/DefaultResolution.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24868/DefaultResolution.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/24868/DefaultResolution.xhtml (added)
+++ sis/ip-review/rev/24868/DefaultResolution.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,94 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultResolution changes for revisions 24867:24868</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultResolution changes for revisions 24867:24868</h1>
+
+<p>Replacement of <code>double</code> by <code>RepresentativeFraction</code> as a consequence of
+changes in GeoAPI interface. Reverting this contribution result in compilation error, which is
+solved by re-doing the same type replacement. The <code>hashCode()</code> method has been removed
+(we inherit the generic implementation from the parent class) and the <code>setEquivalentScale(double)</code>
+method has also been removed.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24867:24868 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/ResolutionImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24867</th><th>Revision 24868</th></tr>
+<tr><td><pre>package org.geotools.metadata.iso.identification;
+
+// OpenGIS dependencies
+import org.opengis.metadata.identification.Resolution;
+
+// Geotools dependencies</pre></td>
+<td><pre>package org.geotools.metadata.iso.identification;
+
+// OpenGIS dependencies
+<span class="add">import org.opengis.metadata.identification.RepresentativeFraction;</span>
+import org.opengis.metadata.identification.Resolution;
+
+// Geotools dependencies</pre></td></tr>
+<tr><td><pre> * Only one of {@linkplain #getEquivalentScale equivalent scale} and
+ * {@linkplain #getDistance ground sample distance} may be provided.
+ */
+<span class="del">private double equivalentScale;</span>
+
+/**
+ * Ground sample distance.</pre></td>
+<td><pre> * Only one of {@linkplain #getEquivalentScale equivalent scale} and
+ * {@linkplain #getDistance ground sample distance} may be provided.
+ */
+<span class="add">private RepresentativeFraction equivalentScale;</span>
+
+/**
+ * Ground sample distance.</pre></td></tr>
+<tr><td><pre> * Only one of {@linkplain #getEquivalentScale equivalent scale} and
+ * {@linkplain #getDistance ground sample distance} may be provided.
+ */
+<span class="del">public double getEquivalentScale()  {</span>
+    return equivalentScale;
+}</pre></td>
+<td><pre> * Only one of {@linkplain #getEquivalentScale equivalent scale} and
+ * {@linkplain #getDistance ground sample distance} may be provided.
+ */
+<span class="add">public RepresentativeFraction getEquivalentScale()  {</span>
+    return equivalentScale;
+}</pre></td></tr>
+<tr><td><pre> */
+public synchronized void setEquivalentScale(final double newValue) {
+    checkWritePermission();
+<span class="del">    equivalentScale = newValue;</span>
+}
+
+/**</pre></td>
+<td><pre> */
+public synchronized void setEquivalentScale(final double newValue) {
+    checkWritePermission();
+<span class="add">    equivalentScale = RepresentativeFractionImpl.fromDouble( newValue );</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> */
+public synchronized int hashCode() {
+    int code = (int)serialVersionUID;
+<span class="del">    code ^= (int)equivalentScale;</span>
+    code ^= (int)distance;
+    return code;
+}</pre></td>
+<td><pre> */
+public synchronized int hashCode() {
+    int code = (int)serialVersionUID;
+<span class="add">    code ^= (int)equivalentScale.hashCode();</span>
+    code ^= (int)distance;
+    return code;
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24868/DefaultResolution.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24868/DefaultResolution.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24897/DefaultRepresentativeFraction.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24897/DefaultRepresentativeFraction.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/24897/DefaultRepresentativeFraction.xhtml (added)
+++ sis/ip-review/rev/24897/DefaultRepresentativeFraction.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,79 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultRepresentativeFraction at revision 24897</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultRepresentativeFraction at revision 24897</h1>
+
+<p>The key point in this contribution is the idea to define <code>RepresentativeFraction</code>
+as a kind of <code>java.lang.Number</code>. But this is not really an idea specific to that commit,
+since it is suggested by the GeoAPI interface javadoc. From that point, everything else is mandated
+by the GeoAPI interface and the <code>Number</code> contract.</p>
+
+<p>This code has been rewritten in Geotk/SIS. But because of the above constraints, it can only
+vary in minor details: <code>intValue()</code> checking for the case where the denominator is
+equals to 1, the useless <code>(obj == null)</code> check removed from the <code>equals</code>
+method, the <code>serialVersionUID</code> value and name of the static factory method.
+Note that the details of the <code>hashCode()</code> method is specified in the GeoAPI interface,
+so that method can not be different.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn cat -r24897 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/RepresentativeFractionImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24897</th></tr>
+<tr><td><pre><span class="add">package org.geotools.metadata.iso.identification;
+
+import org.opengis.metadata.identification.RepresentativeFraction;
+
+/**
+ * Set this up as a number - because it is.
+ *
+ * @author Jody
+ */
+public class RepresentativeFractionImpl extends Number implements RepresentativeFraction {
+    private static final long serialVersionUID = 7228422109144637537L;
+    int denominator;
+
+    public RepresentativeFractionImpl( int denominator ){
+        this.denominator = denominator;
+    }
+
+    public static RepresentativeFraction fromDouble( double value ){
+        return new RepresentativeFractionImpl( (int) (1.0 / value) ); // flip!
+    }
+    public double doubleValue() {
+        return 1.0 / (double) denominator;
+    }
+    public float floatValue() {
+        return 1.0f / (float) denominator;
+    }
+    public int intValue() {
+        return 0;
+    }
+    public long longValue() {
+        return 0;
+    }
+    public int getDenominator() {
+        return denominator;
+    }
+    public boolean equals( Object obj ) {
+        if( obj == null || !(obj instanceof RepresentativeFraction) ){
+            return false;
+        }
+        RepresentativeFraction other = (RepresentativeFraction) obj;
+        return denominator == other.getDenominator();
+    }
+    public int hashCode() {
+        return denominator;
+    }
+}</span></pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24897/DefaultRepresentativeFraction.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24897/DefaultRepresentativeFraction.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24897/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24897/HEADER.html?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/24897/HEADER.html (added)
+++ sis/ip-review/rev/24897/HEADER.html Mon Mar 18 12:45:29 2013
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 24897</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 24897</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-03-23</td></tr>
+  <tr><td><b>Message:</b></td><td>now with more number</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24897/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24897/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24925/DefaultDataIdentification.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/DefaultDataIdentification.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/24925/DefaultDataIdentification.xhtml (added)
+++ sis/ip-review/rev/24925/DefaultDataIdentification.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,102 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultDataIdentification changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultDataIdentification changes for revisions 24924:24925</h1>
+<p>This commit propagates the names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/DataIdentificationImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>// J2SE direct dependencies
+import java.util.Collection;
+import java.util.Locale;
+import java.nio.charset.Charset;</pre></td>
+<td><pre>// J2SE direct dependencies
+import java.util.Collection;
+<span class="add">import java.util.Collections;</span>
+import java.util.Locale;
+import java.nio.charset.Charset;</pre></td></tr>
+<tr><td><pre>import org.opengis.metadata.identification.DataIdentification;
+import org.opengis.metadata.extent.Extent;
+import org.opengis.metadata.extent.GeographicBoundingBox;
+import org.opengis.metadata.identification.Resolution;
+import org.opengis.metadata.identification.TopicCategory;
+import org.opengis.metadata.spatial.SpatialRepresentationType;</pre></td>
+<td><pre>import org.opengis.metadata.identification.DataIdentification;
+import org.opengis.metadata.extent.Extent;
+import org.opengis.metadata.extent.GeographicBoundingBox;
+<span class="add">import org.opengis.metadata.identification.CharacterSet;</span>
+import org.opengis.metadata.identification.Resolution;
+import org.opengis.metadata.identification.TopicCategory;
+import org.opengis.metadata.spatial.SpatialRepresentationType;</pre></td></tr>
+<tr><td><pre>/**
+ * Full name of the character coding standard used for the dataset.
+ */
+<span class="del">private Charset characterSet;</span>
+
+/**
+ * Main theme(s) of the datset.</pre></td>
+<td><pre>/**
+ * Full name of the character coding standard used for the dataset.
+ */
+<span class="add">private CharacterSet characterSet;</span>
+
+/**
+ * Main theme(s) of the datset.</pre></td></tr>
+<tr><td><pre> * Full name of the character coding standard used for the dataset.
+ */
+public Charset getCharacterSet() {
+<span class="del">    return characterSet;</span>
+}
+
+/**
+ * Set the full name of the character coding standard used for the dataset.
+ */
+<span class="del">public synchronized void setCharacterSet(final Charset newValue)  {</span>
+    checkWritePermission();
+    characterSet = newValue;
+}</pre></td>
+<td><pre> * Full name of the character coding standard used for the dataset.
+ */
+public Charset getCharacterSet() {
+<span class="add">    return characterSet.toCharset();</span>
+}
+<span class="add">public Collection getCharacterSets() {</span>
+<span class="add">    return Collections.singleton( characterSet );</span>
+<span class="add">}</span>
+
+/**
+ * Set the full name of the character coding standard used for the dataset.
+ */
+<span class="add">public synchronized void setCharacterSet(final CharacterSet newValue)  {</span>
+    checkWritePermission();
+    characterSet = newValue;
+}</pre></td></tr>
+<tr><td><pre>spatialRepresentationTypes = (Collection)          unmodifiable(spatialRepresentationTypes);
+spatialResolutions         = (Collection)          unmodifiable(spatialResolutions);
+language                   = (Collection)          unmodifiable(language);
+<span class="del">characterSet               = (Charset)             unmodifiable(characterSet);</span>
+topicCategories            = (Collection)          unmodifiable(topicCategories);
+geographicBox              = (Collection)          unmodifiable(geographicBox);
+geographicDescription      = (Collection)          unmodifiable(geographicDescription);</pre></td>
+<td><pre>spatialRepresentationTypes = (Collection)          unmodifiable(spatialRepresentationTypes);
+spatialResolutions         = (Collection)          unmodifiable(spatialResolutions);
+language                   = (Collection)          unmodifiable(language);
+<span class="add">characterSet               = (CharacterSet)        unmodifiable(characterSet);</span>
+topicCategories            = (Collection)          unmodifiable(topicCategories);
+geographicBox              = (Collection)          unmodifiable(geographicBox);
+geographicDescription      = (Collection)          unmodifiable(geographicDescription);</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24925/DefaultDataIdentification.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24925/DefaultDataIdentification.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24965/DefaultRepresentativeFraction.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24965/DefaultRepresentativeFraction.xhtml?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/24965/DefaultRepresentativeFraction.xhtml (added)
+++ sis/ip-review/rev/24965/DefaultRepresentativeFraction.xhtml Mon Mar 18 12:45:29 2013
@@ -0,0 +1,59 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DefaultRepresentativeFraction changes for revisions 24964:24965</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DefaultRepresentativeFraction changes for revisions 24964:24965</h1>
+
+<p>The <code>toScale()</code> method added by this commit has been removed from Geotk/SIS.
+The change in <code>equals(Object)</code> implementation is mandated by the GeoAPI interface
+(it is almost a copy-and-paste from the GeoAPI javadoc), so it can not be different except
+for the omission of the useless <code>(object != null)</code> check.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24964:24965 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/iso/identification/RepresentativeFractionImpl.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24964</th><th>Revision 24965</th></tr>
+<tr><td><pre>    }
+}
+
+/**
+ * Returns the scale in a form usable for computation.
+ *</pre></td>
+<td><pre>    }
+}
+
+<span class="add">public double toScale(){</span>
+<span class="add">    return doubleValue();</span>
+<span class="add">}</span>
+/**
+ * Returns the scale in a form usable for computation.
+ *</pre></td></tr>
+<tr><td><pre>     * - a.equals(b) == b.equals(a)   (reflexivity)
+     * - a.equals(b) implies (a.hashCode() == b.hashCode())
+     */
+<span class="del">    if (object!=null &amp;&amp; object.getClass().equals(getClass())) {</span>
+<span class="del">        final RepresentativeFractionImpl that = (RepresentativeFractionImpl) object;</span>
+<span class="del">        return denominator == that.denominator;</span>
+    }
+    return false;
+}</pre></td>
+<td><pre>     * - a.equals(b) == b.equals(a)   (reflexivity)
+     * - a.equals(b) implies (a.hashCode() == b.hashCode())
+     */
+<span class="add">    if (object!=null &amp;&amp; object instanceof RepresentativeFraction ){</span>
+<span class="add">        final RepresentativeFraction that = (RepresentativeFraction) object;</span>
+<span class="add">        return denominator == that.getDenominator();</span>
+    }
+    return false;
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24965/DefaultRepresentativeFraction.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24965/DefaultRepresentativeFraction.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24965/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24965/HEADER.html?rev=1457741&view=auto
==============================================================================
--- sis/ip-review/rev/24965/HEADER.html (added)
+++ sis/ip-review/rev/24965/HEADER.html Mon Mar 18 12:45:29 2013
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 24965</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 24965</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-03-29</td></tr>
+  <tr><td><b>Message:</b></td><td>updated with toScale method</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24965/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24965/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message