Author: desruisseaux Date: Thu Feb 28 21:17:41 2013 New Revision: 1451354 URL: http://svn.apache.org/r1451354 Log: Added IP reviews. Added: sis/ip-review/AbstractMetadata.xhtml (with props) sis/ip-review/PropertyMap.xhtml (with props) sis/ip-review/PropertyTree.xhtml (with props) Added: sis/ip-review/AbstractMetadata.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/AbstractMetadata.xhtml?rev=1451354&view=auto ============================================================================== --- sis/ip-review/AbstractMetadata.xhtml (added) +++ sis/ip-review/AbstractMetadata.xhtml Thu Feb 28 21:17:41 2013 @@ -0,0 +1,39 @@ + + + + + AbstractMetadata history + + + +
+

AbstractMetadata history

+

Click on the commit message for inspecting the diff and how the code has been rewritten.

+

Command line:

+
svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/AbstractMetadata.java
+ + + + + + + + + + + + + + + + + + + + +
Rev.DateAuthorMessage
306402008-06-12acusterCopyright headers: lib/metadata, this time with feeling (and the el in Toolkit)
305472008-06-06desruisseauxAdded a few MetadataStandard constants. Make the error message slightly more explicit when there is no setter for a given property.
305192008-06-05acusterMetadata header cleanup and copyright review.
302582008-05-08acusterReshuffle the top level repo: drop uDig, move up trunk, tags, and branches.
302572008-05-08acusterMove trunk/gt/ directory contents up to trunk/ and drop gt
300432008-04-25desruisseauxReverted back the ThreadLocal variable type to Boolean (last change from Boolean to current Thread was a mistake). Opportunist usage of hashCode in AbstractMetadata.equals(...).
300412008-04-25desruisseauxRenamed 'isMarshalling(boolean)' as 'xmlMarshalling(boolean)' and added a warning telling that it is a problematic patch. Removed the synchronized keyword in AbstractMetadata.equals(Object) as a fix of GEOT-1777).
296522008-03-17desruisseauxMore effort for computing a "gridToCRS" transform for a mosaic.
289222008-01-24acusterBump the (at)since version to 2.5 since WKTParser was cut from 2.4
285402007-12-29acusterHide buttons which are not yet used
280512007-11-26desruisseauxMore Java 5 parameterized types. Include a fix for GEOT-1599 (CitationImpl.getIdentifiers() should returns a set of Identifiers, not a set of Strings).
278562007-11-12desruisseauxReplaced 'Logger.getLogger(...)' calls by 'Logging.getLogger(...)' (GEOT-1545).
251752007-04-16desruisseauxRemoved 'equals', 'hashCode', 'toString' and 'freeze' methods from every metadata implementation. They are now implemented by generic methods inherited from AbstractMetadata, which perform their work using Java reflection. This way we avoid lot of redundancy, some errors introduced by maintenance ('equals' method not updated in the way they should), more systematic implementations (espcially for the 'toString' method, which was not implemented at all for a majority of metadata), more support for future introduction of other metadata standards than ISO 19115, etc. The cost is more runtime overhead, but it still possible to provide custom implementations for 'equals' and 'hashCode' only in the class that appear to be bottleneck, if we want.
+
+ + Propchange: sis/ip-review/AbstractMetadata.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/AbstractMetadata.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/PropertyMap.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/PropertyMap.xhtml?rev=1451354&view=auto ============================================================================== --- sis/ip-review/PropertyMap.xhtml (added) +++ sis/ip-review/PropertyMap.xhtml Thu Feb 28 21:17:41 2013 @@ -0,0 +1,37 @@ + + + + + PropertyMap history + + + +
+

PropertyMap history

+

Click on the commit message for inspecting the diff and how the code has been rewritten.

+

Command line:

+
svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/PropertyMap.java
+ + + + + + + + + + + + + + + + + + +
Rev.DateAuthorMessage
308522008-07-03desruisseauxPropertyMap now converts automatically from String to a variety of types (InternationalString, File, Number...) and add singleton to collection. UML identifier name are now accepted as well as property name inferred from method name.
306402008-06-12acusterCopyright headers: lib/metadata, this time with feeling (and the el in Toolkit)
305472008-06-06desruisseauxAdded a few MetadataStandard constants. Make the error message slightly more explicit when there is no setter for a given property.
305192008-06-05acusterMetadata header cleanup and copyright review.
303132008-05-16desruisseauxChanged my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.
302582008-05-08acusterReshuffle the top level repo: drop uDig, move up trunk, tags, and branches.
302572008-05-08acusterMove trunk/gt/ directory contents up to trunk/ and drop gt
289222008-01-24acusterBump the (at)since version to 2.5 since WKTParser was cut from 2.4
285402007-12-29acusterHide buttons which are not yet used
280512007-11-26desruisseauxMore Java 5 parameterized types. Include a fix for GEOT-1599 (CitationImpl.getIdentifiers() should returns a set of Identifiers, not a set of Strings).
251572007-04-12desruisseauxMetadata review. Also provided a first draft of support classes for new 'equals(...)' copy constructor implementations backed by Java reflection.
+
+ + Propchange: sis/ip-review/PropertyMap.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/PropertyMap.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/PropertyTree.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/PropertyTree.xhtml?rev=1451354&view=auto ============================================================================== --- sis/ip-review/PropertyTree.xhtml (added) +++ sis/ip-review/PropertyTree.xhtml Thu Feb 28 21:17:41 2013 @@ -0,0 +1,39 @@ + + + + + PropertyTree history + + + +
+

PropertyTree history

+

Click on the commit message for inspecting the diff and how the code has been rewritten.

+

Command line:

+
svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/metadata/src/main/java/org/geotools/metadata/PropertyTree.java
+ + + + + + + + + + + + + + + + + + + + +
Rev.DateAuthorMessage
306402008-06-12acusterCopyright headers: lib/metadata, this time with feeling (and the el in Toolkit)
305472008-06-06desruisseauxAdded a few MetadataStandard constants. Make the error message slightly more explicit when there is no setter for a given property.
305192008-06-05acusterMetadata header cleanup and copyright review.
303132008-05-16desruisseauxChanged my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.
302582008-05-08acusterReshuffle the top level repo: drop uDig, move up trunk, tags, and branches.
302572008-05-08acusterMove trunk/gt/ directory contents up to trunk/ and drop gt
289222008-01-24acusterBump the (at)since version to 2.5 since WKTParser was cut from 2.4
285402007-12-29acusterHide buttons which are not yet used
282522007-12-04desruisseauxMore MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.
279832007-11-22desruisseauxUse more Java 5 constructs for safety.
278642007-11-12desruisseauxUse more Java 5 features. Also fixed a test which failed randomly.
254762007-05-09desruisseauxGEOT-1265: provides a way to print a tree of authority factory dependencies.
251752007-04-16desruisseauxRemoved 'equals', 'hashCode', 'toString' and 'freeze' methods from every metadata implementation. They are now implemented by generic methods inherited from AbstractMetadata, which perform their work using Java reflection. This way we avoid lot of redundancy, some errors introduced by maintenance ('equals' method not updated in the way they should), more systematic implementations (espcially for the 'toString' method, which was not implemented at all for a majority of metadata), more support for future introduction of other metadata standards than ISO 19115, etc. The cost is more runtime overhead, but it still possible to provide custom implementations for 'equals' and 'hashCode' only in the class that appear to be bottleneck, if we want.
+
+ + Propchange: sis/ip-review/PropertyTree.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/PropertyTree.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html