sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1422657 - in /sis/ip-review: Envelope2D.xhtml rev/20874/Envelope2D.xhtml rev/22698/ rev/22698/Envelope2D.xhtml rev/22698/HEADER.html rev/24925/Envelope2D.xhtml rev/30920/Envelope2D.xhtml
Date Sun, 16 Dec 2012 18:22:53 GMT
Author: desruisseaux
Date: Sun Dec 16 18:22:52 2012
New Revision: 1422657

URL: http://svn.apache.org/viewvc?rev=1422657&view=rev
Log:
Added IP review for Envelope2D.

Added:
    sis/ip-review/Envelope2D.xhtml   (with props)
    sis/ip-review/rev/20874/Envelope2D.xhtml   (with props)
    sis/ip-review/rev/22698/
    sis/ip-review/rev/22698/Envelope2D.xhtml   (with props)
    sis/ip-review/rev/22698/HEADER.html   (with props)
    sis/ip-review/rev/24925/Envelope2D.xhtml   (with props)
    sis/ip-review/rev/30920/Envelope2D.xhtml   (with props)

Added: sis/ip-review/Envelope2D.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/Envelope2D.xhtml?rev=1422657&view=auto
==============================================================================
--- sis/ip-review/Envelope2D.xhtml (added)
+++ sis/ip-review/Envelope2D.xhtml Sun Dec 16 18:22:52 2012
@@ -0,0 +1,62 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Envelope2D history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Envelope2D history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and
how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/Envelope2D.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30920</td><td>2008-07-04</td><td class="unav">jgarnett</td><td><a
href="rev/30920/Envelope2D.xhtml">Feature.isValid and the addition of DirectPosition.getCoordinate()</a></td></tr>
+<tr><td class="rev">30776</td><td>2008-06-20</td><td>desruisseaux</td><td>GeoTools
implementation update for GeoAPI change (GEO-136): Envelope.getCenter renamed as getMedian
and getLength renamed as getSpan. Deprecated GridRange, to be replaced by GridEnvelope.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright:
Update referencing headers</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed
my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few
tests show that the compiler always select the best overloaded flavor working on primitive
types (except if an argument is a boolean and the other a different primitive type). Updated
a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return
values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29426</td><td>2008-02-22</td><td>desruisseaux</td><td>Bug
fix in the automatic selection of an ImageReaderSpi from the filename.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">28069</td><td>2007-11-27</td><td>desruisseaux</td><td>Java
5 generics in org.geotools.image.io, and partially in org.geotools.parameters.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">26137</td><td>2007-07-03</td><td>desruisseaux</td><td>Image
I/O GeographicMetadata should now supports read and write operations for most attributes.
More tests needed.</td></tr>
+<tr><td class="rev">25779</td><td>2007-06-08</td><td>desruisseaux</td><td>Added
CRS.transform(CoordinateOperation, ...) methods, which are able to handle the special cases
where the source envelope contains a singularity like a pole or the 180� longitude. As
a side effect, changed Envelope.toString() to a more straightforward formatting, easier for
debugging.</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a
href="rev/24925/Envelope2D.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">22997</td><td>2006-11-26</td><td>desruisseaux</td><td>Replaced
the use of some deprecated methods (MonolineFormatter.initGeotools --> Logging.forceMonolineConsoleOutput;
Utilities.unexpectedException --> Logging.unexpectedException; GeneralEnvelope.getCoordinateReferenceSystem
--> Envelope.getCoordinateReferenceSystem).</td></tr>
+<tr><td class="rev">22710</td><td>2006-11-12</td><td>desruisseaux</td><td>Review
of coverage branch merge: In 'CategoryList', check for the 'no data' category name only if
the geophysics value is some NaN value. Moved XAffineTransform to a public place and added
methods for testing axis swapping, as a proposed replacement for 'GeneralGridGeometry.swapXY(CoordinateSystem)'
(replacement not yet done; waiting for the okay from the mailing list). In GeneralGridGeometry,
added methods for returning a math transform relative to some pixel corner instead of pixel
center, as a proposed replacement for the 'getTransform(...)' public static methods (I would
like to remove those static methods in order to keep the API a little bit more orthogonal).</td></tr>
+<tr><td class="rev">22698</td><td>2006-11-11</td><td class="unav">jgarnett</td><td><a
href="rev/22698/Envelope2D.xhtml">added constructor based</a></td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">21154</td><td>2006-08-22</td><td>desruisseaux</td><td>Moved
around some GeoAPI 2.1 methods that were added, putting them close to related methods and
adding javadoc. In the specific case of DefaultCoordinateSystemAxis, those new methods were
fully implemented. For all other classes (related to naming), those new methods still empty
stubs, but now throw UnsupportedOperationException instead of returning null. Those methods
will need to be revisited and implemented when GeoAPI 2.1 will be ready.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a
href="rev/20874/Envelope2D.xhtml">ip review</a></td></tr>
+<tr><td class="rev">20652</td><td>2006-07-21</td><td>desruisseaux</td><td>Renamed
some resources. Changed exception type.</td></tr>
+<tr><td class="rev">17720</td><td>2006-01-24</td><td>desruisseaux</td><td>Method
signature change in GeneraleEnvelope before 2.2-RC1 release. This is a compatible change if
the user recompile its code.</td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16172</td><td>2005-10-10</td><td>desruisseaux</td><td>Moved
a JTS dependency from the CRS class to the JTS class (GEOT-716)</td></tr>
+<tr><td class="rev">16145</td><td>2005-10-07</td><td>desruisseaux</td><td>Dependencies
cleanup before 2.2.M1 release: move ParseWKT2GeoTiffMetadata and JTS classes (GEOT-716)</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged
the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction
of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare
branch for splitting main</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized
I18N resources</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added
@since javadoc tag</td></tr>
+<tr><td class="rev">13046</td><td>2005-04-10</td><td>desruisseaux</td><td>First
"should be working" (translation: "not yet tested") version of CoverageStack.</td></tr>
+<tr><td class="rev">12020</td><td>2005-03-11</td><td>desruisseaux</td><td>First
working version of Resampler2D port (side effect: GEOT-390 fix)</td></tr>
+<tr><td class="rev">11960</td><td>2005-03-10</td><td>desruisseaux</td><td>First
draft of GridCoverage 'resampler' operation port</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/Envelope2D.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/Envelope2D.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/Envelope2D.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/Envelope2D.xhtml?rev=1422657&view=auto
==============================================================================
--- sis/ip-review/rev/20874/Envelope2D.xhtml (added)
+++ sis/ip-review/rev/20874/Envelope2D.xhtml Sun Dec 16 18:22:52 2012
@@ -0,0 +1,60 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Envelope2D changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Envelope2D changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option)
any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those
who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/Envelope2D.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free
Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+ */
+package org.geotools.geometry;</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2004-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.geometry;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/Envelope2D.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/Envelope2D.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/22698/Envelope2D.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/22698/Envelope2D.xhtml?rev=1422657&view=auto
==============================================================================
--- sis/ip-review/rev/22698/Envelope2D.xhtml (added)
+++ sis/ip-review/rev/22698/Envelope2D.xhtml Sun Dec 16 18:22:52 2012
@@ -0,0 +1,99 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Envelope2D changes for revisions 22697:22698</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Envelope2D changes for revisions 22697:22698</h1>
+<p>This commit constructs an <code>Envelope</code> from its two corners.
+This is a quite natural commit since the ISO 19107 <code>Envelope</code> is defined
that way.
+This code has been rewritten in a different way in SIS
+(except the Javadoc which is a copy-and-paste of the Javadoc of an other constructor):</p>
+<ul>
+  <li>We added a <code>FooEnvelope(DirectPosition lowerCorner, DirectPosition
upperCorner)</code>
+      constructor to every envelope implementations, not only <code>Envelope2D</code>.</li>
+  <li>We generalized the argument type from <code>DirectPosition2D</code>
to <code>DirectPosition</code>.
+    <ul>
+      <li>Implies additional code for checking the argument dimension.</li>
+      <li>Implies replacement of access to <code>x</code> and <code>y</code>
fields
+          by call to the <code>getOrdinate(int)</code> method.</li>
+    </ul></li>
+  <li>We do not reorder anymore the lower and upper values (the call to <code>Math.min(…)</code>
and <code>Math.abs(…)</code>
+      in this commit), since inversion may be intentional in the case of envelopes crossing
the anti-meridian.</li>
+  <li>We take the CRS in account (this commit ignores the CRS).</li>
+</ul>
+<p>Furthermore this commit contains a bug: the last non-trivial line should access
the <code>y</code> field, not <code>x</code>.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r22697:22698 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/Envelope2D.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 22697</th><th>Revision 22698</th></tr>
+<tr><td><pre>    super(x, y, width, height);
+    setCoordinateReferenceSystem(crs);
+}
+<span class="del"></span>
+/**
+ * Returns the coordinate reference system in which the coordinates are given.
+ *
+ * @return The coordinate reference system, or {@code null}.</pre></td>
+<td><pre>    super(x, y, width, height);
+    setCoordinateReferenceSystem(crs);
+}
+/**
+<span class="add"> * Constructs two-dimensional envelope defined by the specified coordinates.
Despite</span>
+<span class="add"> * their name, the (&lt;var&gt;x&lt;/var&gt;,&lt;var&gt;y&lt;/var&gt;)
coordinates don't need to be oriented</span>
+<span class="add"> * toward ({@linkplain AxisDirection#EAST East}, {@linkplain AxisDirection#NORTH
North}).</span>
+<span class="add"> * Those parameter names simply match the {@linkplain #x x} and {@linkplain
#y y} fields.</span>
+<span class="add"> * The actual axis orientations are determined by the specified CRS.</span>
+<span class="add"> * See the {@linkplain Envelope2D class javadoc} for details.</span>
+<span class="add"> */</span>
+<span class="add">public Envelope2D( DirectPosition2D a, DirectPosition2D b )</span>
+<span class="add">{</span>
+<span class="add">    this( a.getCoordinateReferenceSystem(),</span>
+<span class="add">          Math.min( a.x, b.x ),</span>
+<span class="add">          Math.min( a.y, b.y ),</span>
+<span class="add">          Math.abs( a.x- b.x ),</span>
+<span class="add">          Math.abs( a.x- b.x ) );</span>
+<span class="add">}</span>
+<span class="add">/**</span>
+ * Returns the coordinate reference system in which the coordinates are given.
+ *
+ * @return The coordinate reference system, or {@code null}.</pre></td></tr>
+</table>
+
+<p>The SIS code is as below:</p>
+<table class="changes">
+<tr><th>Apache SIS code</th></tr>
+<tr><td><blockquote><pre>public Envelope2D(final DirectPosition lowerCorner,
final DirectPosition upperCorner)
+        throws MismatchedReferenceSystemException, MismatchedDimensionException
+{
+    // The call to getCommonCRS(…) performs a check against null values.
+    this(getCommonCRS(lowerCorner, upperCorner), lowerCorner, upperCorner);
+}
+
+private Envelope2D(final CoordinateReferenceSystem crs,
+                   final DirectPosition lowerCorner,
+                   final DirectPosition upperCorner)
+{
+    /*
+     * JDK constraint: The call to ensureDimensionMatch(…) should have been first if
Sun/Oracle
+     * fixed RFE #4093999 (Relax constraint on placement of this()/super() call in constructors).
+     */
+    this(lowerCorner.getOrdinate(0), lowerCorner.getOrdinate(1),
+         upperCorner.getOrdinate(0), upperCorner.getOrdinate(1));
+    AbstractDirectPosition.ensureDimensionMatch(crs, 2);
+    this.crs = crs;
+}
+
+private Envelope2D(final double xmin, final double ymin, final double xmax, final double
ymax) {
+    super(xmin, ymin, xmax - xmin, ymax - ymin);
+}</pre></blockquote></td></tr></table>
+
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/22698/Envelope2D.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/22698/Envelope2D.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/22698/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/22698/HEADER.html?rev=1422657&view=auto
==============================================================================
--- sis/ip-review/rev/22698/HEADER.html (added)
+++ sis/ip-review/rev/22698/HEADER.html Sun Dec 16 18:22:52 2012
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 22698</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 22698</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2006-11-11</td></tr>
+  <tr><td><b>Message:</b></td><td>added constructor based</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/22698/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/22698/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24925/Envelope2D.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/Envelope2D.xhtml?rev=1422657&view=auto
==============================================================================
--- sis/ip-review/rev/24925/Envelope2D.xhtml (added)
+++ sis/ip-review/rev/24925/Envelope2D.xhtml Sun Dec 16 18:22:52 2012
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Envelope2D changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Envelope2D changes for revisions 24924:24925</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/Envelope2D.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>// OpenGIS dependencies
+import org.opengis.util.Cloneable;
+<span class="del">import org.opengis.spatialschema.geometry.Envelope;</span>
+<span class="del">import org.opengis.spatialschema.geometry.DirectPosition;</span>
+<span class="del">import org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+<span class="del">import org.opengis.spatialschema.geometry.MismatchedReferenceSystemException;</span>
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+import org.opengis.referencing.cs.AxisDirection;  // For javadoc</pre></td>
+<td><pre>// OpenGIS dependencies
+import org.opengis.util.Cloneable;
+<span class="add">import org.opengis.geometry.DirectPosition;</span>
+<span class="add">import org.opengis.geometry.Envelope;</span>
+<span class="add">import org.opengis.geometry.MismatchedDimensionException;</span>
+<span class="add">import org.opengis.geometry.MismatchedReferenceSystemException;</span>
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+import org.opengis.referencing.cs.AxisDirection;  // For javadoc</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24925/Envelope2D.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24925/Envelope2D.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/30920/Envelope2D.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/30920/Envelope2D.xhtml?rev=1422657&view=auto
==============================================================================
--- sis/ip-review/rev/30920/Envelope2D.xhtml (added)
+++ sis/ip-review/rev/30920/Envelope2D.xhtml Sun Dec 16 18:22:52 2012
@@ -0,0 +1,37 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Envelope2D changes for revisions 30919:30920</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Envelope2D changes for revisions 30919:30920</h1>
+<p>This commit propagates the method names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the methods cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r30919:30920 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/Envelope2D.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 30919</th><th>Revision 30920</th></tr>
+<tr><td><pre> */
+public Envelope2D(final Envelope envelope) {
+    super(envelope.getMinimum(0), envelope.getMinimum(1),
+<span class="del">          envelope.getLength (0), envelope.getLength (1));</span>
+
+    // TODO: check below should be first, if only Sun could fix RFE #4093999.
+    final int dimension = envelope.getDimension();</pre></td>
+<td><pre> */
+public Envelope2D(final Envelope envelope) {
+    super(envelope.getMinimum(0), envelope.getMinimum(1),
+<span class="add">          envelope.getSpan(0), envelope.getSpan(1));</span>
+
+    // TODO: check below should be first, if only Sun could fix RFE #4093999.
+    final int dimension = envelope.getDimension();</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/30920/Envelope2D.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/30920/Envelope2D.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message