sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1422216 - in /sis/ip-review: ./ rev/07848/ rev/10796/ rev/20598/ rev/20874/ rev/24925/ rev/30920/
Date Sat, 15 Dec 2012 10:38:07 GMT
Author: desruisseaux
Date: Sat Dec 15 10:38:05 2012
New Revision: 1422216

URL: http://svn.apache.org/viewvc?rev=1422216&view=rev
Log:
IP review for AbstractDirectPosition.

Added:
    sis/ip-review/AbstractDirectPosition.xhtml   (with props)
    sis/ip-review/GeneralDirectPosition.xhtml   (with props)
    sis/ip-review/rev/07848/
    sis/ip-review/rev/07848/AbstractDirectPosition.xhtml   (with props)
    sis/ip-review/rev/07848/HEADER.html   (with props)
    sis/ip-review/rev/10796/AbstractDirectPosition.xhtml   (with props)
    sis/ip-review/rev/20598/AbstractDirectPosition.xhtml   (with props)
    sis/ip-review/rev/20874/AbstractDirectPosition.xhtml   (with props)
    sis/ip-review/rev/24925/AbstractDirectPosition.xhtml   (with props)
    sis/ip-review/rev/30920/
    sis/ip-review/rev/30920/AbstractDirectPosition.xhtml   (with props)
    sis/ip-review/rev/30920/GeneralDirectPosition.xhtml   (with props)
    sis/ip-review/rev/30920/HEADER.html   (with props)

Added: sis/ip-review/AbstractDirectPosition.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/AbstractDirectPosition.xhtml?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/AbstractDirectPosition.xhtml (added)
+++ sis/ip-review/AbstractDirectPosition.xhtml Sat Dec 15 10:38:05 2012
@@ -0,0 +1,71 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractDirectPosition history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractDirectPosition history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractDirectPosition.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30939</td><td>2008-07-07</td><td>desruisseaux</td><td>Avoid usage of deprecated metadata methods.</td></tr>
+<tr><td class="rev">30920</td><td>2008-07-04</td><td class="unav">jgarnett</td><td><a href="rev/30920/AbstractDirectPosition.xhtml">Feature.isValid and the addition of DirectPosition.getCoordinate()</a></td></tr>
+<tr><td class="rev">30892</td><td>2008-07-04</td><td>desruisseaux</td><td>Compatible GeoAPI change: DirectPosition.getCoordinates() made singular (GEO-135).</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update referencing headers</td></tr>
+<tr><td class="rev">30497</td><td>2008-06-03</td><td>desruisseaux</td><td>Renamed Position.getPosition() as getDirectPosition() in GeoAPI interface for avoiding ambiguity (GEO-87). Javadoc fixes.</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28779</td><td>2008-01-16</td><td>desruisseaux</td><td>In referencing module, changed the DirectPosition2D.hashCode() and equals(Object) implementation in order to comply with DirectPosition contract, which fix an AssertionError. It has the unfortunate side-effect of violating the Point2D.hashCode() contract. Unfortunatly it is not possible to comply to both in same time. I added a note in javadoc trying to make that clear.In the coverage module, applied the ImageWorker changes mentioned on the mailing list. Also provided a first draft of an ImageWorkerTest. Note that the build still fail in the shapefile-renderer module for a reason that I believe unrelated to those changes. The same changes have already been applied to the 2.4 branch, which build fine.</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28521</td><td>2007-12-27</td><td>desruisseaux</td><td>Type safety.</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">28069</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 generics in org.geotools.image.io, and partially in org.geotools.parameters.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">26137</td><td>2007-07-03</td><td>desruisseaux</td><td>Image I/O GeographicMetadata should now supports read and write operations for most attributes. More tests needed.</td></tr>
+<tr><td class="rev">25779</td><td>2007-06-08</td><td>desruisseaux</td><td>Added CRS.transform(CoordinateOperation, ...) methods, which are able to handle the special cases where the source envelope contains a singularity like a pole or the 180� longitude. As a side effect, changed Envelope.toString() to a more straightforward formatting, easier for debugging.</td></tr>
+<tr><td class="rev">25548</td><td>2007-05-16</td><td>desruisseaux</td><td>Aligned with GeoAPI changes.</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a href="rev/24925/AbstractDirectPosition.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/AbstractDirectPosition.xhtml">ip review</a></td></tr>
+<tr><td class="rev">20605</td><td>2006-07-18</td><td>desruisseaux</td><td>Javadoc updates. Internationalized two error messages.</td></tr>
+<tr><td class="rev">20598</td><td>2006-07-18</td><td class="unav">simboss</td><td><a href="rev/20598/AbstractDirectPosition.xhtml">-committing first bunch of changes from the coverage branch. Modules involved are*api *referencing *coverage *main *renderer *shaperenderer</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">17460</td><td>2006-01-05</td><td>desruisseaux</td><td>Added support classes for GO-1 implementation. Partial Maven 2 fixes for the new module/renderer module.</td></tr>
+<tr><td class="rev">16526</td><td>2005-10-27</td><td>desruisseaux</td><td>More responsabilities moved from GridCoverage2D to GridGeometry2D (GEOT-701). This refactoring had a significant impact on Resample2D; the rest of the code should stay neutral.</td></tr>
+<tr><td class="rev">16205</td><td>2005-10-11</td><td>desruisseaux</td><td>Cleaned javadoc warning. More work done on Maven 2 configuration (GEOT-691)</td></tr>
+<tr><td class="rev">16172</td><td>2005-10-10</td><td>desruisseaux</td><td>Moved a JTS dependency from the CRS class to the JTS class (GEOT-716)</td></tr>
+<tr><td class="rev">15736</td><td>2005-09-19</td><td>desruisseaux</td><td>Added convenience methods or constructors</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13046</td><td>2005-04-10</td><td>desruisseaux</td><td>First "should be working" (translation: "not yet tested") version of CoverageStack.</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/AbstractDirectPosition.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">10167</td><td>2005-01-02</td><td>desruisseaux</td><td>Improved console: added distance computation</td></tr>
+<tr><td class="rev">8796</td><td>2004-10-22</td><td>desruisseaux</td><td>Cleaning referencing's operation basic package</td></tr>
+<tr><td class="rev">7848</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a href="rev/07848/AbstractDirectPosition.xhtml">round 2 of sync with geoapi</a></td></tr>
+<tr><td class="rev">6536</td><td>2004-06-25</td><td>desruisseaux</td><td>Added SingleCRS class / Renamed ObliqueCartesianCS as AffineCS / Moved Position as super-interface for DirectPosition and Point</td></tr>
+<tr><td class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing CRS implementation</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/GeneralDirectPosition.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/GeneralDirectPosition.xhtml?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/GeneralDirectPosition.xhtml (added)
+++ sis/ip-review/GeneralDirectPosition.xhtml Sat Dec 15 10:38:05 2012
@@ -0,0 +1,66 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralDirectPosition history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralDirectPosition history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/GeneralDirectPosition.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30920</td><td>2008-07-04</td><td class="unav">jgarnett</td><td><a href="rev/30920/GeneralDirectPosition.xhtml">Feature.isValid and the addition of DirectPosition.getCoordinate()</a></td></tr>
+<tr><td class="rev">30892</td><td>2008-07-04</td><td>desruisseaux</td><td>Compatible GeoAPI change: DirectPosition.getCoordinates() made singular (GEO-135).</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28779</td><td>2008-01-16</td><td>desruisseaux</td><td>In referencing module, changed the DirectPosition2D.hashCode() and equals(Object) implementation in order to comply with DirectPosition contract, which fix an AssertionError. It has the unfortunate side-effect of violating the Point2D.hashCode() contract. Unfortunatly it is not possible to comply to both in same time. I added a note in javadoc trying to make that clear.In the coverage module, applied the ImageWorker changes mentioned on the mailing list. Also provided a first draft of an ImageWorkerTest. Note that the build still fail in the shapefile-renderer module for a reason that I believe unrelated to those changes. The same changes have already been applied to the 2.4 branch, which build fine.</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28069</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 generics in org.geotools.image.io, and partially in org.geotools.parameters.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">26137</td><td>2007-07-03</td><td>desruisseaux</td><td>Image I/O GeographicMetadata should now supports read and write operations for most attributes. More tests needed.</td></tr>
+<tr><td class="rev">25779</td><td>2007-06-08</td><td>desruisseaux</td><td>Added CRS.transform(CoordinateOperation, ...) methods, which are able to handle the special cases where the source envelope contains a singularity like a pole or the 180� longitude. As a side effect, changed Envelope.toString() to a more straightforward formatting, easier for debugging.</td></tr>
+<tr><td class="rev">25548</td><td>2007-05-16</td><td>desruisseaux</td><td>Aligned with GeoAPI changes.</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a href="rev/24925/AbstractDirectPosition.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/AbstractDirectPosition.xhtml">ip review</a></td></tr>
+<tr><td class="rev">20605</td><td>2006-07-18</td><td>desruisseaux</td><td>Javadoc updates. Internationalized two error messages.</td></tr>
+<tr><td class="rev">20598</td><td>2006-07-18</td><td class="unav">simboss</td><td><a href="rev/20598/AbstractDirectPosition.xhtml">-committing first bunch of changes from the coverage branch. Modules involved are*api *referencing *coverage *main *renderer *shaperenderer</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">17460</td><td>2006-01-05</td><td>desruisseaux</td><td>Added support classes for GO-1 implementation. Partial Maven 2 fixes for the new module/renderer module.</td></tr>
+<tr><td class="rev">16526</td><td>2005-10-27</td><td>desruisseaux</td><td>More responsabilities moved from GridCoverage2D to GridGeometry2D (GEOT-701). This refactoring had a significant impact on Resample2D; the rest of the code should stay neutral.</td></tr>
+<tr><td class="rev">16205</td><td>2005-10-11</td><td>desruisseaux</td><td>Cleaned javadoc warning. More work done on Maven 2 configuration (GEOT-691)</td></tr>
+<tr><td class="rev">16172</td><td>2005-10-10</td><td>desruisseaux</td><td>Moved a JTS dependency from the CRS class to the JTS class (GEOT-716)</td></tr>
+<tr><td class="rev">15736</td><td>2005-09-19</td><td>desruisseaux</td><td>Added convenience methods or constructors</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13046</td><td>2005-04-10</td><td>desruisseaux</td><td>First "should be working" (translation: "not yet tested") version of CoverageStack.</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/AbstractDirectPosition.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">10167</td><td>2005-01-02</td><td>desruisseaux</td><td>Improved console: added distance computation</td></tr>
+<tr><td class="rev">8796</td><td>2004-10-22</td><td>desruisseaux</td><td>Cleaning referencing's operation basic package</td></tr>
+<tr><td class="rev">7848</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a href="rev/07848/AbstractDirectPosition.xhtml">round 2 of sync with geoapi</a></td></tr>
+<tr><td class="rev">6536</td><td>2004-06-25</td><td>desruisseaux</td><td>Added SingleCRS class / Renamed ObliqueCartesianCS as AffineCS / Moved Position as super-interface for DirectPosition and Point</td></tr>
+<tr><td class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing CRS implementation</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/GeneralDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/GeneralDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/07848/AbstractDirectPosition.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07848/AbstractDirectPosition.xhtml?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/rev/07848/AbstractDirectPosition.xhtml (added)
+++ sis/ip-review/rev/07848/AbstractDirectPosition.xhtml Sat Dec 15 10:38:05 2012
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Abstract &amp; GeneralDirectPosition changes for revisions 7847:7848</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Abstract &amp; GeneralDirectPosition changes for revisions 7847:7848</h1>
+<p>This commit removes the <code>Locale</code> argument in the call to <code>getName(…)</code>,
+as a consequence of the removal of that argument in the GeoAPI method signature.
+This is a trivial change which can not be done in any other way (except omission of the call to <code>toString()</code>,
+which Geotk/SIS does), since keeping that argument causes a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r7847:7848 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractDirectPosition.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 7847</th><th>Revision 7848</th></tr>
+<tr><td><pre>    final int dimension = crs.getCoordinateSystem().getDimension();
+    if (dimension &lt; minimalDimension) {
+        throw new IllegalArgumentException(Resources.format(
+<span class="del">               ResourceKeys.ERROR_MISMATCHED_DIMENSION_$3, crs.getName(Locale.getDefault()),</span>
+                            new Integer(dimension), new Integer(minimalDimension)));
+    }
+}</pre></td>
+<td><pre>    final int dimension = crs.getCoordinateSystem().getDimension();
+    if (dimension &lt; minimalDimension) {
+        throw new IllegalArgumentException(Resources.format(
+<span class="add">               ResourceKeys.ERROR_MISMATCHED_DIMENSION_$3, crs.getName().toString(),</span>
+                            new Integer(dimension), new Integer(minimalDimension)));
+    }
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/07848/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/07848/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/07848/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07848/HEADER.html?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/rev/07848/HEADER.html (added)
+++ sis/ip-review/rev/07848/HEADER.html Sat Dec 15 10:38:05 2012
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 7848</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 7848</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2004-09-08</td></tr>
+  <tr><td><b>Message:</b></td><td>round 2 of sync with geoapi</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/07848/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/07848/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/AbstractDirectPosition.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/AbstractDirectPosition.xhtml?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/rev/10796/AbstractDirectPosition.xhtml (added)
+++ sis/ip-review/rev/10796/AbstractDirectPosition.xhtml Sat Dec 15 10:38:05 2012
@@ -0,0 +1,77 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Abstract &amp; GeneralDirectPosition changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Abstract &amp; GeneralDirectPosition changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto reformat</cite>" tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractDirectPosition.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.geometry;
+
+// J2SE dependencies
+<span class="del">import java.util.Locale;</span>
+<span class="del">import java.util.Arrays;</span>
+import java.io.Serializable;
+<span class="del">import java.awt.geom.Point2D;</span>
+
+<span class="del">// OpenGIS dependencies</span>
+import org.opengis.spatialschema.geometry.DirectPosition;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+<span class="del">import org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+<span class="del">import org.geotools.resources.cts.Resources;</span>
+<span class="del">import org.geotools.resources.cts.ResourceKeys;</span>
+
+<span class="del"></span>
+/**
+ * Holds the coordinates for a position within some coordinate reference system. Since
+ * &lt;code&gt;DirectPosition&lt;/code&gt;s, as data types, will often be included in larger objects</pre></td>
+<td><pre>package org.geotools.geometry;
+
+// J2SE dependencies
+<span class="add">import java.awt.geom.Point2D;</span>
+import java.io.Serializable;
+
+<span class="add">import org.geotools.resources.Utilities;</span>
+<span class="add">import org.geotools.resources.cts.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.cts.Resources;</span>
+<span class="add">import org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+import org.opengis.spatialschema.geometry.DirectPosition;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+
+/**
+ * Holds the coordinates for a position within some coordinate reference system. Since
+ * &lt;code&gt;DirectPosition&lt;/code&gt;s, as data types, will often be included in larger objects</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20598/AbstractDirectPosition.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20598/AbstractDirectPosition.xhtml?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/rev/20598/AbstractDirectPosition.xhtml (added)
+++ sis/ip-review/rev/20598/AbstractDirectPosition.xhtml Sat Dec 15 10:38:05 2012
@@ -0,0 +1,36 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Abstract &amp; GeneralDirectPosition changes for revisions 20597:20598</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Abstract &amp; GeneralDirectPosition changes for revisions 20597:20598</h1>
+<p>This commit removes the <code>public</code> visibility to the <code>toString(DirectPosition)</code> method.
+In Geotk/SIS, this method is still public, so that change has not been ported.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20597:20598 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractDirectPosition.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20597</th><th>Revision 20598</th></tr>
+<tr><td><pre> * a lot of position needs to be formatted, it is more efficient to use an
+ * other instance of {@link CoordinateFormat}.
+ */
+<span class="del">static synchronized String toString(final DirectPosition position) {</span>
+    if (format == null) {
+        format = new CoordinateFormat();
+    }</pre></td>
+<td><pre> * a lot of position needs to be formatted, it is more efficient to use an
+ * other instance of {@link CoordinateFormat}.
+ */
+<span class="add">public static synchronized String toString(final DirectPosition position) {</span>
+    if (format == null) {
+        format = new CoordinateFormat();
+    }</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20598/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20598/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/AbstractDirectPosition.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/AbstractDirectPosition.xhtml?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/rev/20874/AbstractDirectPosition.xhtml (added)
+++ sis/ip-review/rev/20874/AbstractDirectPosition.xhtml Sat Dec 15 10:38:05 2012
@@ -0,0 +1,73 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Abstract &amp; GeneralDirectPosition changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Abstract &amp; GeneralDirectPosition changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option) any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractDirectPosition.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+ */
+package org.geotools.geometry;</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.geometry;</pre></td></tr>
+<tr><td><pre>import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+// Geotools dependencies
+<span class="del">import org.geotools.resources.Utilities;</span>
+import org.geotools.resources.i18n.Errors;
+import org.geotools.resources.i18n.ErrorKeys;
+import org.geotools.measure.CoordinateFormat;</pre></td>
+<td><pre>import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+// Geotools dependencies
+import org.geotools.resources.i18n.Errors;
+import org.geotools.resources.i18n.ErrorKeys;
+import org.geotools.measure.CoordinateFormat;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24925/AbstractDirectPosition.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/AbstractDirectPosition.xhtml?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/rev/24925/AbstractDirectPosition.xhtml (added)
+++ sis/ip-review/rev/24925/AbstractDirectPosition.xhtml Sat Dec 15 10:38:05 2012
@@ -0,0 +1,51 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Abstract &amp; GeneralDirectPosition changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Abstract &amp; GeneralDirectPosition changes for revisions 24924:24925</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractDirectPosition.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>// OpenGIS dependencies
+import org.opengis.referencing.cs.AxisDirection; // For javadoc
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+<span class="del">import org.opengis.spatialschema.geometry.DirectPosition;</span>
+<span class="del">import org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.resources.i18n.Errors;</pre></td>
+<td><pre>// OpenGIS dependencies
+import org.opengis.referencing.cs.AxisDirection; // For javadoc
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+<span class="add">import org.opengis.geometry.DirectPosition;</span>
+<span class="add">import org.opengis.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.resources.i18n.Errors;</pre></td></tr>
+<tr><td><pre>/**
+ * Returns always {@code this}, the direct position for this
+<span class="del"> * {@linkplain org.opengis.spatialschema.geometry.geometry.Position position}.</span>
+ */
+public DirectPosition getPosition() {
+    return this;</pre></td>
+<td><pre>/**
+ * Returns always {@code this}, the direct position for this
+<span class="add"> * {@linkplain org.opengis.geometry.coordinate.Position position}.</span>
+ */
+public DirectPosition getPosition() {
+    return this;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24925/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24925/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/30920/AbstractDirectPosition.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/30920/AbstractDirectPosition.xhtml?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/rev/30920/AbstractDirectPosition.xhtml (added)
+++ sis/ip-review/rev/30920/AbstractDirectPosition.xhtml Sat Dec 15 10:38:05 2012
@@ -0,0 +1,34 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractDirectPosition changes for revisions 30919:30920</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractDirectPosition changes for revisions 30919:30920</h1>
+<p>This change has not be ported to SIS/Geotk.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r30919:30920 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/AbstractDirectPosition.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 30919</th><th>Revision 30920</th></tr>
+<tr><td><pre>    }
+    return ordinates;
+}
+<span class="del"></span>
+/**
+ * @deprecated Renamed as {@link #getCoordinate} for consistency with ISO 19107.
+ *</pre></td>
+<td><pre>    }
+    return ordinates;
+}
+/**
+ * @deprecated Renamed as {@link #getCoordinate} for consistency with ISO 19107.
+ *</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/30920/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/30920/AbstractDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/30920/GeneralDirectPosition.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/30920/GeneralDirectPosition.xhtml?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/rev/30920/GeneralDirectPosition.xhtml (added)
+++ sis/ip-review/rev/30920/GeneralDirectPosition.xhtml Sat Dec 15 10:38:05 2012
@@ -0,0 +1,35 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralDirectPosition changes for revisions 30919:30920</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralDirectPosition changes for revisions 30919:30920</h1>
+<p>This commits applies a change which was done in GeoAPI.
+This is a trivial change which can not be done in any other way, since keeping
+the old method name causes a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r30919:30920 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/geometry/GeneralDirectPosition.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 30919</th><th>Revision 30920</th></tr>
+<tr><td><pre> * @since 2.2
+ */
+public GeneralDirectPosition(final DirectPosition point) {
+<span class="del">    ordinates = point.getCoordinates(); // Should already be cloned.</span>
+    crs = point.getCoordinateReferenceSystem();
+}</pre></td>
+<td><pre> * @since 2.2
+ */
+public GeneralDirectPosition(final DirectPosition point) {
+<span class="add">    ordinates = point.getCoordinate(); // Should already be cloned.</span>
+    crs = point.getCoordinateReferenceSystem();
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/30920/GeneralDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/30920/GeneralDirectPosition.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/30920/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/30920/HEADER.html?rev=1422216&view=auto
==============================================================================
--- sis/ip-review/rev/30920/HEADER.html (added)
+++ sis/ip-review/rev/30920/HEADER.html Sat Dec 15 10:38:05 2012
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 30920</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 30920</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2008-07-04</td></tr>
+  <tr><td><b>Message:</b></td><td>Feature.isValid and the addition of DirectPosition.getCoordinate()</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/30920/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/30920/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message