sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ross Laidlaw (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SIS-34) LICENSE/NOTICE file is in incorrect location in SIS webapp
Date Sat, 14 Jul 2012 13:45:33 GMT

    [ https://issues.apache.org/jira/browse/SIS-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414401#comment-13414401
] 

Ross Laidlaw edited comment on SIS-34 at 7/14/12 1:44 PM:
----------------------------------------------------------

Here's a patch of the changes I tried out on the sis-parent POM, based on the Rave code. 
It seems to be working - if I unpack the war file it has the META-INF directory in the right
place, containing the LICENSE, NOTICE and DEPENDENCIES files.  And the META-INF directory
has been removed from WEB-INF/classes as well.  For reference, here's the code from the patch:

{code}
<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-war-plugin</artifactId>
  <version>2.2</version>
  <configuration>
    <!-- 
      copy legal files added by the maven-remote-resources-plugin 
      to the /META-INF directory as expected for web application archives,
      see SIS-34
    -->
    <webResources>
      <resource>
        <directory>${project.build.outputDirectory}/META-INF</directory>
        <includes>
          <include>LICENSE</include>
          <include>NOTICE</include>
          <include>DEPENDENCIES</include>
        </includes>
        <targetPath>META-INF</targetPath>
        <filtering>false</filtering>
      </resource>
    </webResources>
    <!-- 
      remove the META-INF directory from /WEB-INF/classes in the packaged
      war because this directory should be at the top level of web 
      application archives as /META-INF, see SIS-34
    -->
    <packagingExcludes>WEB-INF/classes/META-INF/</packagingExcludes>
  </configuration>
</plugin>
{code}
                
      was (Author: rlaidlaw):
    Here's a patch of the changes I tried out on the sis-parent POM, based on the Rave code.
 It seems to be working - if I unpack the war file it has the META-INF directory in the right
place, containing the LICENSE, NOTICE and DEPENDENCIES files.  And the META-INF directory
has been removed from WEB-INF/classes as well.
                  
> LICENSE/NOTICE file is in incorrect location in SIS webapp
> ----------------------------------------------------------
>
>                 Key: SIS-34
>                 URL: https://issues.apache.org/jira/browse/SIS-34
>             Project: Spatial Information Systems
>          Issue Type: Bug
>          Components: build process
>            Reporter: Kevan Miller
>            Assignee: Chris A. Mattmann
>            Priority: Critical
>             Fix For: 0.2-incubating
>
>         Attachments: SIS-34.rlaidlaw.2012-07-14.patch.txt
>
>
> Per [~kevan]:
> {quote}
> The LICENSE/NOTICE files in sis-webapp-0.2-incubating.war are not in the correct location
(WEB-INF/classes/META-INF/LICENSE) which is minor, IMO.
> {quote}
> Need to update Maven to put them in the right place.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message