serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Schmidt <s...@ryandesign.com>
Subject Re: svn commit: r1811083 - /serf/trunk/SConstruct
Date Wed, 04 Oct 2017 18:36:01 GMT

> On Oct 4, 2017, at 09:56, rhuijben@apache.org wrote:
> 
> Author: rhuijben
> Date: Wed Oct  4 14:56:22 2017
> New Revision: 1811083
> 
> URL: http://svn.apache.org/viewvc?rev=1811083&view=rev
> Log:
> Fix syntax of a print() in the scons file to unbreak building with most
> recent scons version.
> 
> * SConstruct
>  Use Python 3.0 valid syntax to make Scons 3.0.0 happy on both python 3.0
>  and 2.7.
> 
> Modified:
>    serf/trunk/SConstruct
> 
> Modified: serf/trunk/SConstruct
> URL: http://svn.apache.org/viewvc/serf/trunk/SConstruct?rev=1811083&r1=1811082&r2=1811083&view=diff
> ==============================================================================
> --- serf/trunk/SConstruct (original)
> +++ serf/trunk/SConstruct Wed Oct  4 14:56:22 2017
> @@ -199,7 +199,7 @@ CALLOUT_OKAY = not (env.GetOption('clean
> 
> unknown = opts.UnknownVariables()
> if unknown:
> -  print 'Warning: Used unknown variables:', ', '.join(unknown.keys())
> +  print('Warning: Used unknown variables:', ', '.join(unknown.keys()))

Note that the bug in scons 3.0.0 that required python 3 print syntax has already been fixed
and will presumably be in the next scons release.

https://github.com/SConsProject/scons/commit/2e0de3c55f22b3eaa7767b69740b898f3d2f46bf




Mime
View raw message