serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bert Huijben" <b...@qqmail.nl>
Subject RE: [PATCH] Support Brotli (RFC 7932) decompression
Date Mon, 13 Mar 2017 08:00:59 GMT
> -----Original Message-----
> From: Evgeny Kotkov [mailto:evgeny.kotkov@visualsvn.com]
> Sent: dinsdag 7 maart 2017 12:30
> To: dev@serf.apache.org
> Subject: [PATCH] Support Brotli (RFC 7932) decompression
> 
> Hi,
> 
> This patch adds support for decompressing Brotli (RFC 7932) data and
> allows decoding "Content-Encoding: br" responses with Serf.  Brotli is
> a new compression format that is supported by browsers (Mozilla Firefox
> since 44.0, Google Chrome since 50.0) and major web servers.
> 
> The patch introduces an optional dependency on the Brotli library from
> https://github.com/google/brotli and a new bucket that allows decoding
> Brotli data.  The new bucket features zero-copy processing, which is only
> possible with the new API from the upcoming 1.0.x series of the library.

Thanks for providing this patch. The patch looks very good. The only minor nit I could find
was that the brotli header file detection doesn't appear to do things the scons way.

But really, I currently don't know how to write it better. We can improve after it lands on
trunk.

+1
Feel free to commit your patch to trunk with an 'Approved by: rhuijben', like we do on Subversion
:-)
(all ASF committers can commit to serf... no technical limitations)


BTW: Any idea when we can expect the 1.0.x series to be released?

	Bert


Mime
View raw message