serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From br...@apache.org
Subject svn commit: r1774546 - in /serf/trunk/buckets: fcgi_buckets.c hpack_buckets.c
Date Fri, 16 Dec 2016 00:16:20 GMT
Author: brane
Date: Fri Dec 16 00:16:20 2016
New Revision: 1774546

URL: http://svn.apache.org/viewvc?rev=1774546&view=rev
Log:
Fix some compilation warnings.

* buckets/fcgi_buckets.c (serf_fcgi_frame_refill):
   Use APR_SIZE_T_FMT for a size-type printf argument.

* buckets/hpack_buckets.c (hpack_process):
   Remove a range check that is (a) always false and (b) was already
   taken care of in read_hpack_int.

Modified:
    serf/trunk/buckets/fcgi_buckets.c
    serf/trunk/buckets/hpack_buckets.c

Modified: serf/trunk/buckets/fcgi_buckets.c
URL: http://svn.apache.org/viewvc/serf/trunk/buckets/fcgi_buckets.c?rev=1774546&r1=1774545&r2=1774546&view=diff
==============================================================================
--- serf/trunk/buckets/fcgi_buckets.c (original)
+++ serf/trunk/buckets/fcgi_buckets.c Fri Dec 16 00:16:20 2016
@@ -742,7 +742,8 @@ static apr_status_t serf_fcgi_frame_refi
     }
 
     serf__log(LOGLVL_DEBUG, LOGCOMP_CONN, __FILE__, ctx->config,
-              "Generating 0x%x frame on stream 0x%x of size 0x%x\n",
+              "Generating 0x%x frame on stream 0x%x of size %"
+              APR_SIZE_T_FMT "\n",
               ctx->frame_type, ctx->stream_id, payload);
 
     /* Create FCGI record */

Modified: serf/trunk/buckets/hpack_buckets.c
URL: http://svn.apache.org/viewvc/serf/trunk/buckets/hpack_buckets.c?rev=1774546&r1=1774545&r2=1774546&view=diff
==============================================================================
--- serf/trunk/buckets/hpack_buckets.c (original)
+++ serf/trunk/buckets/hpack_buckets.c Fri Dec 16 00:16:20 2016
@@ -1868,9 +1868,7 @@ hpack_process(serf_bucket_t *bucket)
                     if (status)
                         continue;
 
-                      /* Send remote tablesize update to our table */
-                    if (v >= APR_SIZE_MAX)
-                        return SERF_ERROR_HTTP2_COMPRESSION_ERROR;
+                    /* Send remote tablesize update to our table */
                     status = hpack_table_size_update(ctx->tbl, (apr_size_t)v);
                     if (status)
                         return status;



Mime
View raw message