serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: [PATCH] Fix default compression level in deflate compress buckets
Date Wed, 24 Aug 2016 22:32:33 GMT
Evgeny Kotkov wrote on Wed, Aug 24, 2016 at 23:29:00 +0300:
> [[[
> * buckets/deflate_buckets.c
>   (serf_deflate_wait_for_data): Pass Z_DEFAULT_COMPRESSION instead
>    of Z_DEFAULT_STRATEGY as the compression level to deflateInit2().

Might be better to say the "why", not the "what":

    (serf_deflate_wait_for_data): Enable compression by default.

> +++ buckets/deflate_buckets.c	(working copy)
> @@ -503,7 +503,7 @@ static apr_status_t serf_deflate_wait_for_data(ser
> -            zRC = deflateInit2(&ctx->zstream, Z_DEFAULT_STRATEGY, Z_DEFLATED,
> +            zRC = deflateInit2(&ctx->zstream, Z_DEFAULT_COMPRESSION, Z_DEFLATED,

Cheers,

Daniel


Mime
View raw message