From dev-return-1226-apmail-serf-dev-archive=serf.apache.org@serf.apache.org Mon Dec 21 01:20:10 2015 Return-Path: X-Original-To: apmail-serf-dev-archive@minotaur.apache.org Delivered-To: apmail-serf-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 510061896C for ; Mon, 21 Dec 2015 01:20:10 +0000 (UTC) Received: (qmail 12368 invoked by uid 500); 21 Dec 2015 01:20:10 -0000 Delivered-To: apmail-serf-dev-archive@serf.apache.org Received: (qmail 12325 invoked by uid 500); 21 Dec 2015 01:20:10 -0000 Mailing-List: contact dev-help@serf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@serf.apache.org Received: (qmail 12306 invoked by uid 99); 21 Dec 2015 01:20:09 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Dec 2015 01:20:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 312FDC013F for ; Mon, 21 Dec 2015 01:20:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.898 X-Spam-Level: ** X-Spam-Status: No, score=2.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Kk2FfAf3Nv-H for ; Mon, 21 Dec 2015 01:20:08 +0000 (UTC) Received: from mail-vk0-f43.google.com (mail-vk0-f43.google.com [209.85.213.43]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 9C4DF2026F for ; Mon, 21 Dec 2015 01:20:07 +0000 (UTC) Received: by mail-vk0-f43.google.com with SMTP id f2so54183273vkb.3 for ; Sun, 20 Dec 2015 17:20:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=rV/H/m/pxL2NzyJBToNYpNfI0MZA09WlksFgaW/68CE=; b=HPQwTxw/IOpmGBDOysuL+xtVIj/Cvpc8nEr9uCIYXbgA0v9e6QqA9peggmikpVEdVA xuWiiK+bX+621uxZw1ZjaMAfCtX2YnkTASZZfIjDfIjyzLiUxJvM4t81bNbxzaOxCtzI QpqVVq00KI3JONYmdR8TDGyrRd7zRGDQBhlDIw3khN1poh6cNIUYrrNJ2Ggj5j0wKRzI u6pC+BiHi9/sRLJNzD4GMh4Q4aNf82dYrjdwcAsCy1RPki4hTxRqCP6LRTU546VJIEnR h9Ix0qRAkQ+Ur53JXdAm9K3TbBST9LqqxXHu+Yf+PGEDevdFjXhZx/39JoxltbNwA7Gc 54Bg== MIME-Version: 1.0 X-Received: by 10.31.47.200 with SMTP id v191mr11636718vkv.116.1450660800300; Sun, 20 Dec 2015 17:20:00 -0800 (PST) Received: by 10.31.220.70 with HTTP; Sun, 20 Dec 2015 17:20:00 -0800 (PST) In-Reply-To: <20151219210830.EE9C63A088E@svn01-us-west.apache.org> References: <20151219210830.EE9C63A088E@svn01-us-west.apache.org> Date: Sun, 20 Dec 2015 19:20:00 -0600 Message-ID: Subject: Re: svn propchange: r1720339 - svn:log From: Greg Stein To: Bert Huijben Cc: dev@serf.apache.org Content-Type: multipart/alternative; boundary=001a1143fae0b10f0805275e4990 --001a1143fae0b10f0805275e4990 Content-Type: text/plain; charset=UTF-8 On Sat, Dec 19, 2015 at 3:08 PM, wrote: >... > +* src/outgoing_request.c > + Move file here. > + (serf__handle_response): Accidental early commit of a verification > + that we are actually calling against a response instance instead > + of some other bucket wrapping a response (which would cause a > + segfault on the further calls) > Hmm. This might be the first use for the read_bucket() call... if the caller needs a RESPONSE bucket, but might be looking at a wrapper, then it can use read_bucket to get the RESPONSE. Maybe our wrappers should start implementing read_bucket ? On the other hand, what wrapper might be in there, and what problems might ensue by "unwrapping" the RESPONSE? Cheers, -g --001a1143fae0b10f0805275e4990--