serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Zhakov <i...@visualsvn.com>
Subject Re: serf_bucket_copy_create() wrapped bucket ownership
Date Tue, 03 Nov 2015 16:23:40 GMT
On 3 November 2015 at 17:56, Bert Huijben <bert@qqmail.nl> wrote:
>> -----Original Message-----
>> From: Ivan Zhakov [mailto:ivan@visualsvn.com]
>> Sent: dinsdag 3 november 2015 15:01
>> To: dev@serf.apache.org
>> Subject: serf_bucket_copy_create() wrapped bucket ownership
>>
>> Should serf_bucket_destroy() for COPY_BUCKET destroy wrapped bucket or
>> not? Currently it doesn't and this is inconsistent with other buckets
>> behavior.
>
> I think it should.
>
> Only in very specific cases a bucket shouldn't destroy its inner stream.
>
> Buckets that explicitly read some prefix of another stream that is not yet
> closed (or more in particular the http2 unframe stream) is one of such
> exceptions, but I don't see why the copy stream should be one of them.
>
Fixed in r1712320.

The same problem exists in prefix buckets: should I fix them also?

-- 
Ivan Zhakov

Mime
View raw message