serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Zhakov <i...@visualsvn.com>
Subject Re: svn commit: r1715431 - in /serf/trunk: buckets/response_buckets.c serf_bucket_types.h test/test_buckets.c
Date Sat, 21 Nov 2015 15:59:47 GMT
On 21 November 2015 at 01:09,  <rhuijben@apache.org> wrote:
> Author: rhuijben
> Date: Fri Nov 20 22:09:46 2015
> New Revision: 1715431
>
> URL: http://svn.apache.org/viewvc?rev=1715431&view=rev
> Log:
> Allow a response to handle multiple sets of headers for a single request.
> This enables support for http statee like 100 'Continue'.
>
Hi Bert,

Thanks for fixing this long-standing problem!

>
> * buckets/response_buckets.c
>   (response_context_t): Hold two sets of headers.
>   (serf_bucket_response_create): Tweak init.
>   (serf_bucket_response_get_headers): Get the fetch headers.
>   (serf_response_destroy_and_data): Update cleanup.
>   (parse_status_line): Allow parsing another statusline.
>   (fetch_headers): Store new headers in incoming headers.
>   (run_machine): Handle new states.
>
>   (serf_bucket_response_wait_for_some_headers): New function.
> +apr_status_t serf_bucket_response_wait_for_some_headers(
> +    serf_bucket_t *bucket,
> +     int wait_for_next)

I've two questions about this function:
- What is the purpose of wait_for_next parameter?
- May be better API would be
serf_bucket_response_for_headers2(serf_bucket_t *bucket, int
ignore_interim_status) ? I

-- 
Ivan Zhakov

Mime
View raw message