serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Zhakov <i...@visualsvn.com>
Subject Re: svn commit: r1713489 - serf_bucket_readline()
Date Wed, 11 Nov 2015 12:21:44 GMT
On 11 November 2015 at 01:44, Bert Huijben <bert@qqmail.nl> wrote:
>> -----Original Message-----
>> From: Bert Huijben [mailto:bert@qqmail.nl]
>> Sent: dinsdag 10 november 2015 23:37
>> To: 'Ivan Zhakov' <ivan@visualsvn.com>; rhuijben@apache.org
>> Cc: dev@serf.apache.org
>> Subject: RE: svn commit: r1713489 - in /serf/trunk: buckets/event_buckets.c
>> outgoing.c serf_private.h
>> > -----Original Message-----
>> > From: Ivan Zhakov [mailto:ivan@visualsvn.com]
>> > Sent: dinsdag 10 november 2015 20:43
>> > To: rhuijben@apache.org
>> > Cc: dev@serf.apache.org
>> > Subject: Re: svn commit: r1713489 - in /serf/trunk:
>> buckets/event_buckets.c
>> > outgoing.c serf_private.h
>> >
>> > On 9 November 2015 at 20:49,  <rhuijben@apache.org> wrote:
>> > > Author: rhuijben
>> > > Date: Mon Nov  9 17:49:59 2015
>> > > New Revision: 1713489
>> > >
>> > > URL: http://svn.apache.org/viewvc?rev=1713489&view=rev
>> > > Log:
>> > > Replace the track bucket in the request writing with a tiny bit more
>> > > advanced event bucket that tracks both writing done and destroyed. The
>> > > timings of these callbacks will allow simplifying some logic introduced
>> > > in r1712776.
>> > >
>> > > For now declare the event bucket as a private type.
>> > >
>> > > * buckets/event_buckets.c
>> > >   New file.
>> > >
>> > > * outgoing.c
>> > >   (request_writing_done): New function.
>> > >   (request_writing_finished): Tweak to implement
>> > serf_bucket_event_callback_t.
>> > >   (write_to_connection): Add event bucket directly after the request
>> > bucket,
>> > >     instead of an aggregate when the writing is done.
>> > >
>> > Hi Bert,
>> >
>> > What do you think about alternative design for event buckets: make
>> > event bucket wrap any other bucket (request bucket in our case)? I
>> > think it will be more flexible since we could add callback to be
>> > called before reading from wrapped bucket to track pending request.
>>
>> That might work, but would have different characteristics unless you do
>> more special things.
>
> There is one more problem with all this wrapping: All layers need to somehow support
all read methods.
>
> Wrapping works for all methods except: readline.
>
How is event bucket situation different from barrier bucket for example?

-- 
Ivan Zhakov

Mime
View raw message