serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bert Huijben" <b...@qqmail.nl>
Subject RE: svn commit: r1715774 - /serf/trunk/protocols/fcgi_protocol.c
Date Mon, 23 Nov 2015 12:13:57 GMT
Luckily clang reports issues like this as warning. (Public functions without a prototype).

 

I’m trying to find why the mac bots fail since a commit last Wednesday, while no other test
environments complain.

 

 

Usually the Sparc bot is the one to notice segfaults…

 

                Bert

 

From: Greg Stein [mailto:gstein@gmail.com] 
Sent: maandag 23 november 2015 12:51
To: Bert Huijben <rhuijben@apache.org>
Cc: dev@serf.apache.org
Subject: Re: svn commit: r1715774 - /serf/trunk/protocols/fcgi_protocol.c

 

hehe... seems I need to write a shell script to look at serf.a for unprefixed symbols :-P

 

On Mon, Nov 23, 2015 at 5:47 AM, <rhuijben@apache.org <mailto:rhuijben@apache.org>
> wrote:

Author: rhuijben
Date: Mon Nov 23 11:47:37 2015
New Revision: 1715774

URL: http://svn.apache.org/viewvc?rev=1715774 <http://svn.apache.org/viewvc?rev=1715774&view=rev>
&view=rev
Log:
Mark a few more functions static.

* protocols/fcgi_protocol.c
  (fcgi_teardown,
   fcgi_outgoing_teardown,
   fcgi_server_teardown): Mark static.

Modified:
    serf/trunk/protocols/fcgi_protocol.c

Modified: serf/trunk/protocols/fcgi_protocol.c
URL: http://svn.apache.org/viewvc/serf/trunk/protocols/fcgi_protocol.c?rev=1715774 <http://svn.apache.org/viewvc/serf/trunk/protocols/fcgi_protocol.c?rev=1715774&r1=1715773&r2=1715774&view=diff>
&r1=1715773&r2=1715774&view=diff
==============================================================================
--- serf/trunk/protocols/fcgi_protocol.c (original)
+++ serf/trunk/protocols/fcgi_protocol.c Mon Nov 23 11:47:37 2015
@@ -376,7 +376,7 @@ static apr_status_t fcgi_hangup(serf_fcg
     return APR_ENOTIMPL;
 }

-void fcgi_teardown(serf_fcgi_protocol_t *fcgi)
+static void fcgi_teardown(serf_fcgi_protocol_t *fcgi)
 {

 }
@@ -472,7 +472,7 @@ static apr_status_t fcgi_outgoing_hangup
     return fcgi_hangup(fcgi);
 }

-void fcgi_outgoing_teardown(serf_connection_t *conn)
+static void fcgi_outgoing_teardown(serf_connection_t *conn)
 {
     serf_fcgi_protocol_t *fcgi = conn->protocol_baton;

@@ -530,7 +530,7 @@ static apr_status_t fcgi_server_hangup(s
     return fcgi_hangup(fcgi);
 }

-void fcgi_server_teardown(serf_incoming_t *client)
+static void fcgi_server_teardown(serf_incoming_t *client)
 {
     serf_fcgi_protocol_t *fcgi = client->protocol_baton;




 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message