serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bert Huijben" <b...@qqmail.nl>
Subject RE: svn commit: r1714297 - in /serf/trunk: buckets/event_buckets.c outgoing.c serf_private.h
Date Sat, 14 Nov 2015 14:19:57 GMT


> -----Original Message-----
> From: Bert Huijben [mailto:bert@qqmail.nl]
> Sent: zaterdag 14 november 2015 15:15
> To: 'Ivan Zhakov' <ivan@visualsvn.com>; rhuijben@apache.org
> Cc: dev@serf.apache.org
> Subject: RE: svn commit: r1714297 - in /serf/trunk: buckets/event_buckets.c
> outgoing.c serf_private.h


> Writing that function as a wrapper would require coding that function,
> reviewing it and testing it, while I don't see any usecase where somebody
> uses this function.
> And in all current implementations/usages just using the default readline
> would 100% do the same thing without measurable performance
> degradation.
> 
> Same reason as why we never implement read_for_sendfile().... There is not
> a single user in serf that would use it.

Note that 1 week ago (before r1713788) the typical implementation of serf_bucket_readline()
on most advanced buckets was a NULL pointer with a ### TODO comment.

	Bert



Mime
View raw message