serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bert Huijben" <b...@qqmail.nl>
Subject RE: svn commit: r1714297 - in /serf/trunk: buckets/event_buckets.c outgoing.c serf_private.h
Date Sat, 14 Nov 2015 14:14:43 GMT


> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan@visualsvn.com]
> Sent: zaterdag 14 november 2015 14:25
> To: rhuijben@apache.org
> Cc: dev@serf.apache.org
> Subject: Re: svn commit: r1714297 - in /serf/trunk: buckets/event_buckets.c
> outgoing.c serf_private.h
> 
> On 14 November 2015 at 12:36,  <rhuijben@apache.org> wrote:
> > Author: rhuijben
> > Date: Sat Nov 14 09:36:08 2015
> > New Revision: 1714297
> >
> > URL: http://svn.apache.org/viewvc?rev=1714297&view=rev
> > Log:
> > Redefine the event bucket as a wrapping bucket, to remove dependencies
> on
> > implementation details on the 'aggregation' stream around the event
> bucket.
> >
> > Calculate total number of bytes read to increase event value.
> >
> > @@ -128,7 +215,7 @@ static void serf_event_destroy(serf_buck
> >  const serf_bucket_type_t serf_bucket_type__event = {
> >      "EVENT",
> >      serf_event_read,
> > -    serf_event_readline,
> > +    serf_default_readline,
> Is it intentional? Why event bucket doesn't forward readline calls
> directly to wrapped bucket?

I don't see why you would use the event bucket when you are reading yourself, instead of putting
it in a write stream. And write streams typically don't use readline. (They would typically
use read or read_iovec depending on whether ssl or compression/decompression is used)

Writing that function as a wrapper would require coding that function, reviewing it and testing
it, while I don't see any usecase where somebody uses this function.
And in all current implementations/usages just using the default readline would 100% do the
same thing without measurable performance degradation.

Same reason as why we never implement read_for_sendfile().... There is not a single user in
serf that would use it.

	Bert


Mime
View raw message