serf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Zhakov <i...@visualsvn.com>
Subject Re: svn commit: r1700439 - in /serf/tools/buildbot/windows: serf-config.cmd.template serftest-build.cmd serftest-cleanup.cmd serftest-template.cmd serftest-test.cmd
Date Tue, 01 Sep 2015 09:36:36 GMT
On 1 September 2015 at 12:27,  <rhuijben@apache.org> wrote:
> Author: rhuijben
> Date: Tue Sep  1 09:27:07 2015
> New Revision: 1700439
>
> URL: http://svn.apache.org/r1700439
> Log:
> Checkpoint buildbot scripts
>
> Added:
>     serf/tools/buildbot/windows/serf-config.cmd.template   (with props)
>     serf/tools/buildbot/windows/serftest-build.cmd   (with props)
>     serf/tools/buildbot/windows/serftest-cleanup.cmd   (with props)
>     serf/tools/buildbot/windows/serftest-template.cmd   (with props)
>     serf/tools/buildbot/windows/serftest-test.cmd   (with props)
>
> Added: serf/tools/buildbot/windows/serf-config.cmd.template
> URL: http://svn.apache.org/viewvc/serf/tools/buildbot/windows/serf-config.cmd.template?rev=1700439&view=auto
> ==============================================================================
> --- serf/tools/buildbot/windows/serf-config.cmd.template (added)
> +++ serf/tools/buildbot/windows/serf-config.cmd.template Tue Sep  1 09:27:07 2015
> @@ -0,0 +1,50 @@
> +@echo off
> +REM ================================================================
> +REM   Licensed to the Apache Software Foundation (ASF) under one
> +REM   or more contributor license agreements.  See the NOTICE file
> +REM   distributed with this work for additional information
> +REM   regarding copyright ownership.  The ASF licenses this file
> +REM   to you under the Apache License, Version 2.0 (the
> +REM   "License"); you may not use this file except in compliance
> +REM   with the License.  You may obtain a copy of the License at
> +REM
> +REM     http://www.apache.org/licenses/LICENSE-2.0
> +REM
> +REM   Unless required by applicable law or agreed to in writing,
> +REM   software distributed under the License is distributed on an
> +REM   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +REM   KIND, either express or implied.  See the License for the
> +REM   specific language governing permissions and limitations
> +REM   under the License.
> +REM ================================================================
> +
> +CALL "c:\Program Files\Microsoft Visual Studio 9.0\VC\vcvarsall.bat" x86
It's better to use environment variable instead of hardcoded Visual
Studio installation path. I.e.
CALL "%VS90COMNTOOLS\..\..\VC\vcvarsall.bat" x86

> Added: serf/tools/buildbot/windows/serftest-cleanup.cmd
> URL: http://svn.apache.org/viewvc/serf/tools/buildbot/windows/serftest-cleanup.cmd?rev=1700439&view=auto
> ==============================================================================
> --- serf/tools/buildbot/windows/serftest-cleanup.cmd (added)
> +++ serf/tools/buildbot/windows/serftest-cleanup.cmd Tue Sep  1 09:27:07 2015
[...]

> +
> +PUSHD "%TEMP%"
> +IF NOT ERRORLEVEL 1 (
> +  rmdir /s /q "%TEMP%" 2> nul:
> +)
> +POPD
> +
> +
> +taskkill /im msbuild.exe /f 2> nul:
> +taskkill /im svn.exe /f 2> nul:
Is it really needed for serf tests to run?

-- 
Ivan Zhakov

Mime
View raw message