ripple-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Gebhardt (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (RIPPLE-63) Ripple should default to local proxy, not remote
Date Tue, 28 Oct 2014 21:58:34 GMT

    [ https://issues.apache.org/jira/browse/RIPPLE-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187517#comment-14187517
] 

Andreas Gebhardt edited comment on RIPPLE-63 at 10/28/14 9:57 PM:
------------------------------------------------------------------

Hi Brent,

the call of »db.save(...)« is invalid if the default (local) proxy is (should be) set. The
first argument is the key and the second the value, defined here lib/client/db.js +77

> function save(key, value, prefix, callback)

The local proxy isn't set as you can see in attchment x-domain-proxy-default-brocken.png.
After select »remote« (x-domain-proxy-remote.png) and switch back to »local« (x-domain-proxy-local.png)
the local proxy settings are applied.

Fortunately the fix is easy (https://github.com/agebhar1/incubator-ripple/commit/7d01641cf8815425a437989249ed5bc0678d1e76),
i start a pull request for this at Github.

After dropping the database table (via js console) on the initial start the default proxy
setting is applied (x-domain-proxy-default-fixed.png).

Kind Regards,
Andreas



was (Author: agebhardt):
Hi Brent,

the call of »db.save(...)« is invalid if the default (local) proxy is (should be) set. The
first argument is the key and the second the value, defined here lib/client/db.js +77

> function save(key, value, prefix, callback)

The local proxy isn't set as you can see in attchment x-domain-proxy-default-brocken.png.
After select »remote« (x-domain-proxy-remote.png) and switch back to »local« (x-domain-proxy-local.png)
the local proxy settings are applied.

Fortunately the fix is easy, i start a pull request for this at Github.

After dropping the database table (via js console) on the initial start the default proxy
setting is applied (x-domain-proxy-default-fixed.png).

Kind Regards,
Andreas


> Ripple should default to local proxy, not remote
> ------------------------------------------------
>
>                 Key: RIPPLE-63
>                 URL: https://issues.apache.org/jira/browse/RIPPLE-63
>             Project: Apache Ripple
>          Issue Type: Bug
>            Reporter: Vladimir Kotikov
>         Attachments: x-domain-proxy-default-brocken.png, x-domain-proxy-default-fixed.png,
x-domain-proxy-local.png, x-domain-proxy-remote.png
>
>
> The default Ripple option is to use a remote proxy, so all calls go through e.g. https://rippleapi.herokuapp.com/xhr_proxy?tinyhippos_apikey=ABC&tinyhippos_rurl=https%3A//login.somehost.net/common/oauth2/token.
> This is a terrible option because the information that user is sending may be extremely
security sensitive.
> You can set the proxy to be local, but you’d need to specify that every time you launch
Chrome.
> Using local proxy is more common practice, and maybe it should be used by default?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message