ripple-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brent Lintner (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (RIPPLE-10) `ripple emulate` should return proper 404 when a .html file is not found
Date Tue, 25 Jun 2013 19:46:20 GMT

     [ https://issues.apache.org/jira/browse/RIPPLE-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Brent Lintner resolved RIPPLE-10.
---------------------------------

    Resolution: Fixed

PR is up here: https://github.com/apache/incubator-ripple/pull/9

Any thoughts before I pull in?
                
> `ripple emulate` should return proper 404 when a .html file is not found
> ------------------------------------------------------------------------
>
>                 Key: RIPPLE-10
>                 URL: https://issues.apache.org/jira/browse/RIPPLE-10
>             Project: Apache Ripple
>          Issue Type: Bug
>         Environment: CLI, NPM
>            Reporter: Brent Lintner
>            Assignee: Brent Lintner
>            Priority: Minor
>              Labels: v0.9.16
>
> Steps to reproduce:
> 1. Install v0.9.16
> 2. Run `ripple emulate --path simple-app/`
> Note: make sure simple-app does not have foo.html in it.
> 3. Open a browser and navigate to "localhost:4400/foo.html"
> Expected: Something like "Cannot GET /foo.html"
> Actually: It returns a (gracefully handled) server error:
> TypeError: path must be a string
>     at Object.fs.open (fs.js:330:11)
>     at Object.fs.readFile (fs.js:116:6)
>     at inject (/Users/brent/local/node/lib/node_modules/ripple-emulator/lib/server/emulate/hosted.js:127:12)
>     at Object.handle (/Users/brent/local/node/lib/node_modules/ripple-emulator/lib/server/emulate/hosted.js:152:13)
>     at next (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/node_modules/connect/lib/proto.js:199:15)
>     at next (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/node_modules/connect/lib/proto.js:174:78)
>     at pass (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/lib/router/index.js:107:24)
>     at Router._dispatch (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/lib/router/index.js:170:5)
>     at Object.router (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/lib/router/index.js:33:10)
>     at next (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/node_modules/connect/lib/proto.js:199:15)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message