portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From woon...@apache.org
Subject svn commit: r773935 - /portals/jetspeed-2/portal/trunk/jetspeed-portal-resources/src/main/resources/assembly/headtag.xml
Date Tue, 12 May 2009 15:21:20 GMT
Author: woonsan
Date: Tue May 12 15:21:20 2009
New Revision: 773935

URL: http://svn.apache.org/viewvc?rev=773935&view=rev
Log:
JS2-1003: Adding some optional dojo.requires to run j2-admin's permissions management portlet
and constraints management portlet.
The main problem is that dojo widgets are available only when the dojo requires are written
during page loading.
If dojo requires statement for a specific widget is added in the loaded page later, then the
widget cannot be accessible by dojo.widget.getId().
In the previous version, head contributions are initially done by a separate lifecycle for
every portlet window.
However, in JS-2.2's desktop mode, head contributions are done for each portlet content after
page loaded and dynamically added into the page.
This is why permissions management portlet and constraints management portlet did not work.

To resolve this problem, we can choose the following possible options:
(a) Add all dojo widget requires statements for j2-admin portlets in the headtag.xml, so every
widget requires lines are to be added by default.
(b) Consider to upgrade dojo toolkit if possible.
(c) If dojo.requires statements are newly added by a portlet window under desktop mode, reload
the page.

For 2.2 release, I'd like to stick to (a) because of the time constraints and reducing risks.

Modified:
    portals/jetspeed-2/portal/trunk/jetspeed-portal-resources/src/main/resources/assembly/headtag.xml

Modified: portals/jetspeed-2/portal/trunk/jetspeed-portal-resources/src/main/resources/assembly/headtag.xml
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/trunk/jetspeed-portal-resources/src/main/resources/assembly/headtag.xml?rev=773935&r1=773934&r2=773935&view=diff
==============================================================================
--- portals/jetspeed-2/portal/trunk/jetspeed-portal-resources/src/main/resources/assembly/headtag.xml
(original)
+++ portals/jetspeed-2/portal/trunk/jetspeed-portal-resources/src/main/resources/assembly/headtag.xml
Tue May 12 15:21:20 2009
@@ -270,6 +270,13 @@
         <value>dojo.widget.TabContainer</value>
         <value>dojo.widget.AccordionContainer</value>
         <value>dojo.widget.Menu2</value>
+        
+        <value>dojo.widget.LayoutContainer</value>
+        <value>dojo.widget.ContentPane</value>
+        <value>dojo.widget.SplitContainer</value>
+        <value>dojo.widget.Checkbox</value>
+        <value>dojo.widget.Dialog</value>
+        <value>dojo.widget.Button</value>
       </list>
     </constructor-arg>
   </bean>
@@ -284,6 +291,8 @@
         <value>jetspeed.widget.PortalAccordionContainer</value>
         <value>jetspeed.widget.PortalBreadcrumbContainer</value>
         <value>jetspeed.widget.PortalTooltipManager</value>
+        
+        <value>jetspeed.widget.EditorTable</value>
       </list>
     </constructor-arg>
   </bean>
@@ -465,4 +474,4 @@
     </constructor-arg>
   </bean>
 
-</beans>
+</beans>
\ No newline at end of file



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message