portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From woon...@apache.org
Subject svn commit: r772985 - /portals/jetspeed-2/portal/trunk/components/jetspeed-portal-site/src/main/java/org/apache/jetspeed/portalsite/impl/PortalSiteSessionContextImpl.java
Date Fri, 08 May 2009 13:48:58 GMT
Author: woonsan
Date: Fri May  8 13:48:57 2009
New Revision: 772985

URL: http://svn.apache.org/viewvc?rev=772985&view=rev
Log:
JS2-995: Fixing non-thread-safe session attribute (PortalSiteSessionContext object) usage
problem.
When a thread sets an instance to session, then the previous instance from the same session
in another thread receives valueUnbound() event, which invalidate the state before retrieving
managed page.
This problem rarely happen in portal pipeline because every request pipeline is the same,
so there's no need to renew the siteSessionContext.
However, under desktop mode, there could be multiple simultaneous requests to ajax-pipeline,
so it can happen sometimes.
Of course, even in portal pipeline, this problem can happen when there are simultaneous requests
from the same session. (e.g. from multiple iframes.)

Modified:
    portals/jetspeed-2/portal/trunk/components/jetspeed-portal-site/src/main/java/org/apache/jetspeed/portalsite/impl/PortalSiteSessionContextImpl.java

Modified: portals/jetspeed-2/portal/trunk/components/jetspeed-portal-site/src/main/java/org/apache/jetspeed/portalsite/impl/PortalSiteSessionContextImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/trunk/components/jetspeed-portal-site/src/main/java/org/apache/jetspeed/portalsite/impl/PortalSiteSessionContextImpl.java?rev=772985&r1=772984&r2=772985&view=diff
==============================================================================
--- portals/jetspeed-2/portal/trunk/components/jetspeed-portal-site/src/main/java/org/apache/jetspeed/portalsite/impl/PortalSiteSessionContextImpl.java
(original)
+++ portals/jetspeed-2/portal/trunk/components/jetspeed-portal-site/src/main/java/org/apache/jetspeed/portalsite/impl/PortalSiteSessionContextImpl.java
Fri May  8 13:48:57 2009
@@ -1248,9 +1248,6 @@
             }
         }
 
-        // clear session context state
-        clearSessionProfileLocators();
-
         // log binding event
         if (log.isDebugEnabled())
         {



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message