portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tay...@apache.org
Subject svn commit: r737244 - /portals/jetspeed-2/portal/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/login/filter/PortalFilter.java
Date Fri, 23 Jan 2009 23:14:17 GMT
Author: taylor
Date: Fri Jan 23 23:14:17 2009
New Revision: 737244

URL: http://svn.apache.org/viewvc?rev=737244&view=rev
Log:
i don't fully understand the purpose of the commits on Sept 8, 2008 to this class. Im just
fixing the most obvious error: invalid passwords were causing a stack trace to the browser.
The new logic needs to be reviewed and tested for any introduced errors. For now it seems
to be working with this patch

Modified:
    portals/jetspeed-2/portal/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/login/filter/PortalFilter.java

Modified: portals/jetspeed-2/portal/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/login/filter/PortalFilter.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/login/filter/PortalFilter.java?rev=737244&r1=737243&r2=737244&view=diff
==============================================================================
--- portals/jetspeed-2/portal/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/login/filter/PortalFilter.java
(original)
+++ portals/jetspeed-2/portal/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/login/filter/PortalFilter.java
Fri Jan 23 23:14:17 2009
@@ -80,8 +80,10 @@
                 try{
                 	authUser = authProvider.authenticate(username, password);	
                 }
-                catch (SecurityException e) {
-                		throw new ServletException(e);                		
+                catch (SecurityException e) 
+                {
+                    audit.logUserActivity(username, request.getRemoteAddr(), AuditActivity.AUTHENTICATION_FAILURE,
"PortalFilter");                    
+                    request.getSession().setAttribute(LoginConstants.ERRORCODE, LoginConstants.ERROR_INVALID_PASSWORD);
 				}
                 if (authUser != null)
                 {



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message