portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "MATSUDA Masaaki (JIRA)" <jetspeed-...@portals.apache.org>
Subject [jira] Commented: (JS1-529) Cannot browse specified tab or menu URL
Date Thu, 01 Feb 2007 17:07:05 GMT

    [ https://issues.apache.org/jira/browse/JS1-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469508
] 

MATSUDA Masaaki commented on JS1-529:
-------------------------------------

Index: VelocityPanedPortletController.java
===================================================================
--- VelocityPanedPortletController.java	(revision 501853)
+++ VelocityPanedPortletController.java	(working copy)
@@ -21,6 +21,8 @@
 import org.apache.turbine.util.RunData;
 
 // Jetspeed stuff
+import org.apache.jetspeed.om.profile.Portlets;
+import org.apache.jetspeed.om.profile.Profile;
 import org.apache.jetspeed.portal.Portlet;
 import org.apache.jetspeed.portal.PanedPortletController;
 import org.apache.jetspeed.util.template.JetspeedLink;
@@ -120,6 +122,60 @@
                 return true;
             }
 
+            Profile profile = ((JetspeedRunData)rundata).getProfile();
+            boolean paneNotFound = false;
+            // check if the target pane(peid) is existing under the current pane(p.getID()).
+            boolean includedSubPane = false;
+            String searchPortletId = peid;
+            do
+            {
+                Portlets portlets = profile.getDocument().getPortletsById(searchPortletId);
+                searchPortletId = null;
+                if (portlets != null)
+                {
+                    Portlets parentPortlets = portlets.getParentPortlets();
+                    if (parentPortlets != null)
+                    {
+                        searchPortletId = parentPortlets.getId();
+                        if (searchPortletId.equals(p.getID()))
+                        {
+                            subPane = p.getID();
+                            includedSubPane = true;
+                            break;
+                        }
+                    }
+                }
+                else
+                {
+                    paneNotFound = true;
+                }
+            }
+            while (searchPortletId != null);
+
+            // check if the target pane(peid) is existing over the current pane(p.getID()).
+            boolean includingSubPane = false;
+            searchPortletId = p.getID();
+            do
+            {
+                Portlets portlets = profile.getDocument().getPortletsById(searchPortletId);
+                searchPortletId = null;
+                if (portlets != null)
+                {
+                    Portlets parentPortlets = portlets.getParentPortlets();
+                    if (parentPortlets != null )
+                    {
+                        searchPortletId = parentPortlets.getId();
+                        if (searchPortletId.equals(peid))
+                        {
+                            includingSubPane = true;
+                            break;
+                        }
+                    }
+                }
+            }
+            while (searchPortletId != null);
+
+
             // is this the sub pane?
             if (subPane!=null && p.getID().equals(subPane))
             {
@@ -148,7 +204,18 @@
                 }
                 else
                 {
-                    return (p.getID().equals(last));
+                    if (p.getID().equals(last))
+                    {
+                        if (includingSubPane)
+                        {
+                            return true;
+                        }
+                        else if (paneNotFound)
+                        {
+                            return true;
+                        }
+                    }
+                    return false;
                 }
             }
             else


> Cannot browse specified tab or menu URL
> ---------------------------------------
>
>                 Key: JS1-529
>                 URL: https://issues.apache.org/jira/browse/JS1-529
>             Project: Jetspeed
>          Issue Type: Bug
>          Components: Miscellaneous
>    Affects Versions: 1.5, 1.6-dev
>         Environment: Perhaps any.
>            Reporter: MATSUDA Masaaki
>            Priority: Critical
>
> Cannot browse specified tab or menu URL.
> For example,
> 1. First, visit Jetspeed site.
>   http://www.bluesunrise.com/jetspeed/
> 2. Open RSS tab.
> 3. Open xmlhack tab that is child tab of RSS tab.
> 4. Copy URL shown browser address bar.
>   http://www.bluesunrise.com/jetspeed/portal/media-type/html/user/anon/page/default.psml/js_pane/113
> 5. Move to another tab, or open new browser.
> 6. Paste copied URL into browser's address bar.
> 7. You will know that xmlhack page could not browse.
> I tried another situation, tab in menu or so on 
> but result is the same.
> I noticed that this is because Google can not find 
> contents in the site using Jetspeed. Sad...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message