portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sie, Yang" <yang....@fmr.com>
Subject RE: [jira] Commented: (JS2-633) nested layout broken with permission security enabled
Date Wed, 20 Dec 2006 20:41:34 GMT
Hello David:

I rebuilt the page-manager.jar (not the jetspeed-portal.jar) with our
version of code. It worked well under file system page manager. In Db
page manager it is still failed for the same reason. And it didn't even
allow me to delete the last fragment!  

I went in to the org.apache.jetspeed.om.page.impl.FragmentImpl and
wanted to do the same. I found it was slightly different (with an extra
'mutable' check) from the psml version. So I am here copying the section
for you to review and change. 

Thank you.

if (!filteredFragments.isEmpty())
{
	if (mutable)
	{
		return new FilteredFragmentList(this,
filteredFragments);
	}
	else
	{
		return filteredFragments;
	}
}
else
{
	return null;
}


---
Yang Sie
Fidelity Invenstments
E19A 
One Federal Street
Boston, MA 02110

Tel: 617-563-5778


>-----Original Message-----
>From: David Sean Taylor (JIRA) [mailto:jetspeed-dev@portals.apache.org]
>Sent: Wednesday, December 20, 2006 1:28 PM
>To: jetspeed-dev@jakarta.apache.org
>Subject: [jira] Commented: (JS2-633) nested layout broken with
permission
>security enabled
>
>    [ http://issues.apache.org/jira/browse/JS2-
>633?page=comments#action_12460014 ]
>
>David Sean Taylor commented on JS2-633:
>---------------------------------------
>
>patch has been applied
>please rebuild the jetspeed-portal jar, and restart and retest
>
>
>> nested layout broken with permission security enabled
>> -----------------------------------------------------
>>
>>                 Key: JS2-633
>>                 URL: http://issues.apache.org/jira/browse/JS2-633
>>             Project: Jetspeed 2
>>          Issue Type: Bug
>>          Components: Profiler
>>    Affects Versions: 2.1-dev
>>         Environment: Tomcat 5 on Windows, potential on IBM WAS
>>            Reporter: Yang Sie
>>         Assigned To: David Sean Taylor
>>
>> with permission security enabled, a page with nested layout generates
>null pointer exception under the condition that a portlet in the inner
most
>nested layout is denied access.
>> For example: a page with root layout as oneColumnNoAction, inside
this
>layout, this are portletA and a TwoColumnNoAction layout. under the
>TwoColumnNoAction, portletB at the left cell, and a OneColumn layout at
the
>right cell. inside the OneColumn layout positioned portletC.  if
portletC
>is forbidden from the current user, while portletA and portletB are OK
to
>see. Null pointer is thrown.
>> In general, if *all* portlets (suppose more than one) under the
OneColumn
>layout are blocked to the current user, Null Pointer error is thrown.
To
>make null pointer go away, at least one potlet inside the inner most
layout
>(OneColumn layout) has to be accessible to user. Another point to note
is
>that, if the inner most layout (OneColumn layout) has no portlet
fragment
>at all (means no <fragment type='portlet' .../>. the page is displayed
>correctly (i.e. only portletA and portletB apepar on the page, which
>*theoritically* should be the same for the display situation,  from
user
>point of view, when portletC is forbidden). Theory is that JS2 treats
those
>two situations differently somehow.
>
>--
>This message is automatically generated by JIRA.
>-
>If you think it was sent incorrectly contact one of the administrators:
>http://issues.apache.org/jira/secure/Administrators.jspa
>-
>For more information on JIRA, see:
http://www.atlassian.com/software/jira
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
>For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message