portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ate Douma (JIRA)" <jetspeed-...@portals.apache.org>
Subject [jira] Resolved: (JS2-611) Custom Portlet Mode and Window State incorrectly handled / processed from portlet.xml
Date Wed, 15 Nov 2006 13:39:41 GMT
     [ http://issues.apache.org/jira/browse/JS2-611?page=all ]

Ate Douma resolved JS2-611.
---------------------------

    Resolution: Fixed

I've implemented a fix for this which temporarily provides backwards compatibility still allowing
allowing both the old but incorrect custom-portlet-mode/name or custom-window-state/name definitions
as well the correct custom-portlet-mode/portlet-mode and custom-window-state/window-state
definitions.
As soon as we provide portlet.xml xsd validation though the old definitions *will* break portlet-application
deployment.

> Custom Portlet Mode and Window State incorrectly handled / processed from portlet.xml
> -------------------------------------------------------------------------------------
>
>                 Key: JS2-611
>                 URL: http://issues.apache.org/jira/browse/JS2-611
>             Project: Jetspeed 2
>          Issue Type: Bug
>          Components: Container
>    Affects Versions: 2.1-dev
>            Reporter: Ate Douma
>         Assigned To: Ate Douma
>             Fix For: 2.1, 2.1-dev
>
>
> The definition Jetspeed expects in portlet.xml for declaring a custom-portlet-mode and
custom-window-state is not according to the official portlet 1.0 descriptor xsd.
> Currently, for Jetspeed to recognize custom-portlet-mode or custom-window-state definitions,
you have to define them like:
>   <custom-portlet-mode>
>     <description>optional description</description>
>     <name>sample-mode</name>
>   </custom-portlet-mode>
>   <custom-window-state>
>     <description>optional description</description>
>     <name>sample-state</name>
>   </custom-window-state>
> But, the xsd requires them to be defined like:
>   <custom-portlet-mode>
>     <description>optional description</description>
>     <portlet-mode>sample-mode</portlet-mode>
>   </custom-portlet-mode>
>   <custom-window-state>
>     <description>optional description</description>
>     <window-state>sample-state</window-state>
>   </custom-window-state>
> As defense for this invalid handling, I like to point out that the Portlet Specification
1.0 documentation contains examples with the same mistake.
> (I actually implemented this in Jetspeed looking at those examples, not the xsd itself.
My bad ;) )
> I'm going to fix this ASAP, and we will probably (very soon) add portlet.xml xsd validation
too, so to not make these type of mistakes again.
> Only the demo portlet application provided by Jetspeed currently uses a custom-window-state,
and I will fix that one too of course.
> *** WARNING: fixing this *will* break  deployment of custom portlet applications in Jetspeed
which also use this invalid definition ***   

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message