portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <jetspeed-...@portals.apache.org>
Subject [jira] Updated: (JS2-472) FragmentImpl.getFragments() can be null but is assumed not null
Date Fri, 20 Jan 2006 00:14:42 GMT
     [ http://issues.apache.org/jira/browse/JS2-472?page=all ]

David Jencks updated JS2-472:
-----------------------------

    Attachment: FragmentImpl.diff

The attached patch includes the changes to make getFragments() not return null, ever.  However
it also contains some changes to permissions construction/evaluation that if applied now would
break the build, so this is basically to look at, not apply.  I'll include these changes also
in the permissions patch I'm working on.

> FragmentImpl.getFragments() can be null but is assumed not null
> ---------------------------------------------------------------
>
>          Key: JS2-472
>          URL: http://issues.apache.org/jira/browse/JS2-472
>      Project: Jetspeed 2
>         Type: Bug
>     Versions: 2.1-dev
>     Reporter: David Jencks
>  Attachments: FragmentImpl.diff
>
> org.apache.jetspeed.om.page.psml.FragmentImpl.getFragments() can return null if all fragments
fail the security check: see line 560.
> However, ContentFragmentImpl assumes that a non-null value is returned: for instance
in ContentFragmentList.duplicateList().
> I assume the best fix is to always return a list, even if empty.
> I will supply a patch in the next day or two.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message