portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Berger <ber...@imn.htwk-leipzig.de>
Subject Re: [jira] Commented: (JS2-376) request parameter encoding problem
Date Tue, 11 Oct 2005 14:16:06 GMT

>>
>> Index: 
>> components/portal/src/java/org/apache/jetspeed/engine/JetspeedEngine.java 
>>
>> ===================================================================
>> --- 
>> components/portal/src/java/org/apache/jetspeed/engine/JetspeedEngine.java   
>> (revision 312749)
>> +++ 
>> components/portal/src/java/org/apache/jetspeed/engine/JetspeedEngine.java   
>> (working copy)
>> @@ -189,12 +189,8 @@
>>      public void service( RequestContext context ) throws 
>> JetspeedException
>>      {
>>
>> -            String targetPipeline = context
>> -                    
>> .getRequestParameter(PortalReservedParameters.PIPELINE);
>> -            if (null == targetPipeline)
>> -            {
>> -                targetPipeline = 
>> (String)context.getAttribute(PortalReservedParameters.PIPELINE);
>> -            }
>> +            String targetPipeline = 
>> (String)context.getAttribute(PortalReservedParameters.PIPELINE);
>> +
>
>
> -1
> This will break Fusion and other solutions using alternate pipelines
>
I had concerns too removing this line when suggesting the patch, but the 
usage of alternate pipelines is still possible by using request 
attributes instead of request parameters. I had a look into Fusion and 
didn't find a location where the pipeline is set through a request 
parameter.
If I do not have overlooked sth., they are set only through request 
attributes, so this patch wouldn't break Fusion.



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message