portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Sean Taylor <da...@bluesunrise.com>
Subject Re: [jira] Commented: (JS2-376) request parameter encoding problem
Date Tue, 11 Oct 2005 13:44:11 GMT
Shinsuke SUGAYA (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/JS2-376?page=comments#action_12331755 ] 
> 
> Shinsuke SUGAYA commented on JS2-376:
> -------------------------------------
> 
> Hi developers,
> 
> To fix this issue(needs to call ServletRequest#setCharacterEncoding before ServletRequest#getParameter),
I have to apply the following patch. If you have any concerns when applying it, please let
me know. I checked j1 and j2, but I did not find the related code.
> 
> Index: components/portal/src/java/org/apache/jetspeed/engine/JetspeedEngine.java
> ===================================================================
> --- components/portal/src/java/org/apache/jetspeed/engine/JetspeedEngine.java   (revision
312749)
> +++ components/portal/src/java/org/apache/jetspeed/engine/JetspeedEngine.java   (working
copy)
> @@ -189,12 +189,8 @@
>      public void service( RequestContext context ) throws JetspeedException
>      {
> 
> -            String targetPipeline = context
> -                    .getRequestParameter(PortalReservedParameters.PIPELINE);
> -            if (null == targetPipeline)
> -            {
> -                targetPipeline = (String)context.getAttribute(PortalReservedParameters.PIPELINE);
> -            }
> +            String targetPipeline = (String)context.getAttribute(PortalReservedParameters.PIPELINE);
> +

-1
This will break Fusion and other solutions using alternate pipelines

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message