portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Sean Taylor <da...@bluesunrise.com>
Subject Re: svn commit: r202133 - in /portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed: services/title/DynamicTitleServiceImpl.java velocity/JetspeedPowerToolImpl.java
Date Fri, 01 Jul 2005 17:41:10 GMT
James Liao wrote:
> Hi all,
> I think the optimize for DynamicTitleServiceImpl have a problem.
> If a portlet's Resources doesn't contain javax.portlet.title property,
> the portlet will lost its title. For example, almost all the
> Administrative portlet have this problem.
> 
> I have do a little bit investigated on it. I found the cause of this
> is in LanguageImpl and LanguageSetImpl. The LanguageImpl's method:
> setTitle(), setShortTitle() and setKeywords() will not set the value
> into DefaultsResourceBundle object's defaultValues Map.
> 
> So can not use the LanguageSetImpl's createLanguage method like this:
> 
> createLanguage(lang.getLocale(), loadResourceBundle(lang.getLocale()),"","","");
> language.setTitle(lang.getTitle());
> language.setShortTitle(lang.getShortTitle());
> language.setKeywords(StringUtils.join(lang.getKeywords(), ","));
> 
> Should be used like this:
> createLanguage(lang.getLocale(), loadResourceBundle(lang.getLocale()),
> lang.getTitle(), lang.getShortTitle(),
> StringUtils.join(lang.getKeywords(), ","));
> 
> If it is necessary, I could raise a bug for this and provide a patch.
> 
Thanks (again) James
I'll apply this patch and see how it works here today

Regards,

-- 
David Sean Taylor
Bluesunrise Software
david@bluesunrise.com
[office] +01 707 773-4646
[mobile] +01 707 529 9194

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message