portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jetspeed-...@jakarta.apache.org
Subject [jira] Resolved: (JS1-372) [PATCH] FileServerPortlet not designed for subclassing
Date Wed, 01 Sep 2004 14:30:50 GMT
Message:

   The following issue has been resolved as FIXED.

   Resolver: Jeremy Ford
       Date: Wed, 1 Sep 2004 7:30 AM

Patch applied
---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JS1-372

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JS1-372
    Summary: [PATCH] FileServerPortlet not designed for subclassing
       Type: Bug

     Status: Resolved
 Resolution: FIXED

    Project: Jetspeed
 Components: 
             Portlets
   Fix Fors:
             1.6-dev
   Versions:
             1.4b4

   Assignee: 
   Reporter: G Monroe

    Created: Wed, 6 Aug 2003 4:38 PM
    Updated: Wed, 1 Sep 2004 7:30 AM
Environment: Operating System: All
Platform: All

Description:
The FileServerPortlet sets the content inside it's init() method.  Since it is 
good practice to for subclasses to always call super.init(), a subclass of 
FileServerPortlet will get its content set before it can do any processing.

In addition, the getURL(String) method is defined as private with makes it 
harder to overwrite.

Attached to this enhancement report is a diff file which does the following to 
make this class more extensible:

1) Move the setContent call to a separate protected method, initContent.
2) Make the getURL method protected.
3) Added some more javadoc comments.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org


Mime
View raw message