portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From morci...@apache.org
Subject cvs commit: jakarta-jetspeed/xdocs changes.xml
Date Mon, 06 Jan 2003 17:39:22 GMT
morciuch    2003/01/06 09:39:22

  Modified:    docs/site changes.html
               src/java/org/apache/jetspeed/portal/security/portlets
                        StatefulPortletWrapper.java
               xdocs    changes.xml
  Log:
  Removed redundant view permission checks from isClosed and isMinimized methods (see Bugzilla
issue# 15818)
  
  Revision  Changes    Path
  1.91      +3 -2      jakarta-jetspeed/docs/site/changes.html
  
  Index: changes.html
  ===================================================================
  RCS file: /home/cvs/jakarta-jetspeed/docs/site/changes.html,v
  retrieving revision 1.90
  retrieving revision 1.91
  diff -u -r1.90 -r1.91
  --- changes.html	4 Jan 2003 13:41:54 -0000	1.90
  +++ changes.html	6 Jan 2003 17:39:21 -0000	1.91
  @@ -5,7 +5,6 @@
           
   <!-- start the processing -->
       <!-- ====================================================================== -->
  -    <!-- GENERATED FILE, DO NOT EDIT, EDIT THE XML FILE IN xdocs INSTEAD! -->
       <!-- Main Page Section -->
       <!-- ====================================================================== -->
       <html>
  @@ -15,7 +14,6 @@
                           
              
                                       
  -                        
               <title>Jetspeed - Jetspeed Changes Log</title>
           </head>
   
  @@ -134,6 +132,9 @@
     action (add/remove/update/fix) - [Bug # xxx -] date - description (committer's initials)
[Thanks to developer_name]
   </li>
   -->
  +<li>
  +  Fixed - Bug # 15818 - 2003/01/06 - Removed reduntant permission checks  (MO)
  +</li>
   <li>
     Add - 2003/01/02 - Added a JSP-based Stock Quote Portlet demo  (MO)
   </li>
  
  
  
  1.4       +3 -23     jakarta-jetspeed/src/java/org/apache/jetspeed/portal/security/portlets/StatefulPortletWrapper.java
  
  Index: StatefulPortletWrapper.java
  ===================================================================
  RCS file: /home/cvs/jakarta-jetspeed/src/java/org/apache/jetspeed/portal/security/portlets/StatefulPortletWrapper.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- StatefulPortletWrapper.java	10 Sep 2002 15:12:08 -0000	1.3
  +++ StatefulPortletWrapper.java	6 Jan 2003 17:39:22 -0000	1.4
  @@ -115,17 +115,7 @@
        */
       public final boolean isClosed(RunData rundata)
       {
  -        if( checkPermission(rundata, 
  -                            JetspeedSecurity.PERMISSION_VIEW ) )
  -        {
  -            return wrappedState.isClosed( rundata );
  -        }
  -        else
  -        {
  -            //FIXME: for the moment we will allow this call to succeed...
  -            //throw new TurbineRuntimeException( "Security check failed" );
  -            return wrappedState.isClosed( rundata );
  -        }
  +        return wrappedState.isClosed( rundata );
       }
   
       /**
  @@ -195,17 +185,7 @@
        */
       public boolean isMinimized(RunData rundata)
       {
  -        if( checkPermission(rundata, 
  -                            JetspeedSecurity.PERMISSION_VIEW ) )
  -        {
  -            return wrappedState.isMinimized( rundata );
  -        }
  -        else
  -        {
  -            //FIXME: for the moment we will allow this call to succeed...
  -            //throw new TurbineRuntimeException( "Security check failed" );
  -            return wrappedState.isMinimized( rundata );
  -        }
  +        return wrappedState.isMinimized( rundata );
       }
   
       /**
  
  
  
  1.108     +4 -1      jakarta-jetspeed/xdocs/changes.xml
  
  Index: changes.xml
  ===================================================================
  RCS file: /home/cvs/jakarta-jetspeed/xdocs/changes.xml,v
  retrieving revision 1.107
  retrieving revision 1.108
  diff -u -r1.107 -r1.108
  --- changes.xml	2 Jan 2003 19:43:12 -0000	1.107
  +++ changes.xml	6 Jan 2003 17:39:22 -0000	1.108
  @@ -23,6 +23,9 @@
   </li>
   -->
   <li>
  +  Fixed - Bug # 15818 - 2003/01/06 - Removed reduntant permission checks  (MO)
  +</li>
  +<li>
     Add - 2003/01/02 - Added a JSP-based Stock Quote Portlet demo  (MO)
   </li>
   <li>
  
  
  

--
To unsubscribe, e-mail:   <mailto:jetspeed-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:jetspeed-dev-help@jakarta.apache.org>


Mime
View raw message