portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Orciuch" <mark_orci...@ngsltd.com>
Subject RE: cvs commit: jakarta-jetspeed/src/java/org/apache/jetspeed/portal/security/portlets PortletWrapper.java
Date Tue, 03 Sep 2002 14:31:15 GMT
Sorry - you got it.

> -----Original Message-----
> From: Paul Spencer [mailto:paulspencer@mindspring.com]
> Sent: Monday, September 02, 2002 1:47 PM
> To: Jetspeed Developers List
> Subject: Re: cvs commit:
> jakarta-jetspeed/src/java/org/apache/jetspeed/portal/security/portlets
> PortletWrapper.java
> 
> 
> I would prefer the use of constance instead of "200"  and "401"
> 
> Currently:
>     PortletStats.logAccess(rundata, this, "200");
> 
> Prefered:
>     PortletStats.logAccess(rundata, this, PortletStats.ACCESS_OK);
> 
> Paul Spencer
> 
> morciuch@apache.org wrote:
> 
> >morciuch    2002/08/27 12:28:10
> >
> >  Modified:    src/java/org/apache/jetspeed/portal/security/portlets
> >                        PortletWrapper.java
> >  Log:
> >  Added support for PortletStatsService (see Bugzilla issue 11737)
> >  
> >  Revision  Changes    Path
> >  1.11      +10 -1     
> jakarta-jetspeed/src/java/org/apache/jetspeed/portal/security/port
> lets/PortletWrapper.java
> >  
> >  Index: PortletWrapper.java
> >  ===================================================================
> >  RCS file: 
> /home/cvs/jakarta-jetspeed/src/java/org/apache/jetspeed/portal/sec
> urity/portlets/PortletWrapper.java,v
> >  retrieving revision 1.10
> >  retrieving revision 1.11
> >  diff -u -r1.10 -r1.11
> >  --- PortletWrapper.java	25 Aug 2002 22:10:47 -0000	1.10
> >  +++ PortletWrapper.java	27 Aug 2002 19:28:10 -0000	1.11
> >  @@ -67,6 +67,7 @@
> >   import org.apache.jetspeed.util.template.JetspeedLink;
> >   import org.apache.jetspeed.util.template.JetspeedLinkFactory;
> >   import org.apache.jetspeed.util.MimeType;
> >  +import org.apache.jetspeed.services.PortletStats;
> >   
> >   // Turbine imports
> >   import org.apache.turbine.util.Log;
> >  @@ -139,10 +140,18 @@
> >   
> >           if (checkPermission(rundata, 
> JetspeedSecurity.PERMISSION_VIEW))
> >           {
> >  +            if (PortletStats.isEnabled())
> >  +            {
> >  +                PortletStats.logAccess(rundata, this, "200");
> >  +            }
> >               return wrappedPortlet.getContent(rundata);
> >           }
> >           else 
> >           {
> >  +            if (PortletStats.isEnabled())
> >  +            {
> >  +                PortletStats.logAccess(rundata, this, "401");
> >  +            }
> >               return new ClearElement("Sorry, you have no 
> permission to see this portlet");
> >           }
> >       }
> >  
> >  
> >  
> >
> >--
> >To unsubscribe, e-mail:   
> <mailto:jetspeed-dev-unsubscribe@jakarta.apache.org>
> >For additional commands, e-mail: 
> <mailto:jetspeed-dev-help@jakarta.apache.org>
> >
> >
> >  
> >
> 
> 
> 
> 
> 
> --
> To unsubscribe, e-mail:   
> <mailto:jetspeed-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: 
> <mailto:jetspeed-dev-help@jakarta.apache.org>

--
To unsubscribe, e-mail:   <mailto:jetspeed-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:jetspeed-dev-help@jakarta.apache.org>


Mime
View raw message