portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Sean Taylor" <da...@bluesunrise.com>
Subject RE: Bug in Customizer
Date Mon, 20 May 2002 21:04:25 GMT
I just looked at 1.3a2, and it doesn't seem to write the extra <skin/>
entries
Perhaps a Castor upgrade is causing this.

I tried removing the <skin/> entries from 1.3a3 psml, but it didn't fix
the problem...

> -----Original Message-----
> From: David Sean Taylor [mailto:david@bluesunrise.com] 
> Sent: Monday, May 20, 2002 1:48 PM
> To: 'Jetspeed Developers List'
> Subject: RE: Bug in Customizer
> 
> 
> I tested a 4/29 jetspeed, and the bug is still there.
> I went all the way back to 1.3a2, and the bug is not there.
> 
> Even though this is not the cause of the problem, does this 
> line need to go back in?
> 
>    conf.setPortletSkin( pc.getPortletSkin() );   
> 
> See below:
> > -----Original Message-----
> > From: Glenn Golden [mailto:ggolden@umich.edu]
> > Sent: Monday, May 20, 2002 12:18 PM
> > To: 'Jetspeed Developers List'
> > Subject: RE: Bug in Customizer
> > 
> > 
> > David -
> > 
> > Here's my "anon" page:
> > 
> > <?xml version="1.0" encoding="UTF-8"?>
> > <portlets id="200" xmlns="http://www.apache.org/2000/02/CVS">
> >     <skin name="orange-red-Bordered"/>
> > 	<metainfo>
> > 		<title>The CHEF Portal</title>
> > 	</metainfo>
> > 	<entry id="100" parent="chef.motd"/>
> > 	<entry id="101" parent="chef.intro"/>
> > </portlets>
> > 
> > I put in the "skin name" for the Portlets.
> > 
> > The PsmlPortlets object created for this *does* seem to have
> > a skin named "orange-red-Bordered".
> > 
> > The Entry objects have a skin with a null name.
> > 
> > The JetspeedPortletFactoryService's getPortletConfig()
> > returns a config with a null skin -
> > 
> > then (in public Portlet getPorltlet(Entry)) calls
> > PortalToolkit.getSkin() to set the config's skin.
> 
> 
> * Shouldn't it first check the portlets collection?
> 
> 
> > 
> > JetspeedPortalToolkitService.getSkin(String) sees the null 
> > skin name, and uses "this.defaultSkin" which is set to 
> > "orange-grey".  Here's where I would think it would get the 
> > skin from the Portlets, but instead it uses a default for 
> the service.
> > 
> > Now this is past my area of understanding - but perhaps it 
> > rings some bells for you?
> > 
> > My questions are:
> > 
> > - it looks correct that the skin name is at the "Portlets" 
> > level, not at the "Entry" level, as that matches the UI of 
> > the customizers...
> > 
> > - where is / was the code that looked at the PsmlPortlets for 
> > a skin if not defined in the Entry?  Is / was this a feature 
> > of creating these objects from the .psml file?
> > 
> > - is the Entry having a skin, but it having a null name suspicious?
> 
> Could be. I noticed that entries such as <skin/> get written out.
> Not sure if the customizer always wrote things outthis way or not.
> 
> > 
> > 
> > - Glenn
> > 
> > > -----Original Message-----
> > > From: David Sean Taylor [mailto:david@bluesunrise.com]
> > > Sent: Monday, May 20, 2002 1:35 PM
> > > To: 'Jetspeed-Dev'
> > > Subject: Bug in Customizer
> > > 
> > > 
> > > Im looking into a new bug in the customizer.
> > > It seems that the changes to the skins do not work anymore. Try 
> > > changing from orange-gray to orange-red. The title bars 
> > change in the 
> > > customizer, but when you save they go back to gray.
> > > 
> > > Been all of the place trying to hunt this down this morning
> > > (great start to a Monday...) and I see something suspicious 
> > > on a commit from 5/15.
> > > 
> > > Look at the diffs here:
> > > 
> > http://cvs.apache.org/viewcvs.cgi/jakarta-jetspeed/src/java/or
> g/apache/j
> etspeed/services/portletfactory/JetspeedPortletFactoryService.
> java.diff?
> r1=1.11&r2=1.12&diff_format=h
> 
> It appears the setting of the skin was deleted.
> 
>    conf.setPortletSkin( pc.getPortletSkin() );   
> 
> I tried rolling back the changes but it broke the customizer.
> I guess there are other files that need to rollback too
> 
> I will try to look into it more today, if anyone familiar with this
> commit could have a look much appreciated
> 
> 
>   
> 
> 
> 
> --
> To unsubscribe, e-mail:
> <mailto:jetspeed-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
> <mailto:jetspeed-dev-help@jakarta.apache.org>
> 
> --
> To unsubscribe, e-mail:
> <mailto:jetspeed-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
> <mailto:jetspeed-dev-help@jakarta.apache.org>
> 
> 
> 
> --
> To unsubscribe, e-mail:   
> <mailto:jetspeed-dev-> unsubscribe@jakarta.apache.org>
> For 
> additional commands, 
> e-mail: <mailto:jetspeed-dev-help@jakarta.apache.org>
> 
> 



--
To unsubscribe, e-mail:   <mailto:jetspeed-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:jetspeed-dev-help@jakarta.apache.org>


Mime
View raw message