portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glenn Golden <ggol...@umich.edu>
Subject [PATCH] for redirect
Date Tue, 26 Mar 2002 20:50:41 GMT
Ok, I've sent a patch to Turbine.

The solution I selected was to have the Action class just do a:

RunData.setRedirectURI()

When it wants to call for a redirect.

Make sure not to set any headers or body in the response directly before (or
after) this.

If the Action class does this, and turbine is patched (you can apply the
patch to our version of turbine or the tip, I'll attach it fyi), things work
well again.

That is, once you patch Jetspeed's redirect calls, which are all done
directly to the response object, not to the run data.

I've made these changes and included the patch.

Warning: I'm not sure that the redirects in the VelocityPortletAction
classes doCancel() etc. will work. I have to check this out - it may be that
by the time these are called (not as a turbine action, but as part of
processing the portlets) it's far too late to call for a redirect. I made
the changes to the code to do it the new way, and I'll report back soon to
see if we need further changes in the way these actions are handled to
support redirects.


- Glenn
 
--------------------------------------------
Glenn R. Golden, Systems Research Programmer
University of Michigan School of Information
ggolden@umich.edu               734-615-1419
http://www-personal.si.umich.edu/~ggolden/
--------------------------------------------


> -----Original Message-----
> From: David Sean Taylor [mailto:david@bluesunrise.com] 
> Sent: Monday, March 25, 2002 11:21 PM
> To: 'Jetspeed Developers List'
> Subject: RE: Turbine - Jetspeed interaction problems
> 
> 
> > Next Step: If we like this, how do we get this into Turbine?
> 
> Just join the Turbine-dev or Turbine-user list and post your 
> argument there. Your argument is sound. Im on the turbine 
> lists, I'll try to help if they don't want to fix it.
> 
> You can also send them a patch.
> 
> 
> 
> 
> --
> To unsubscribe, e-mail:   
> <mailto:jetspeed-dev-> unsubscribe@jakarta.apache.org>
> For 
> additional commands, 
> e-mail: <mailto:jetspeed-dev-help@jakarta.apache.org>
> 


Mime
View raw message