portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Raphaël Luta <raphael.l...@networks.groupvu.com>
Subject Re: cvs commit: jakarta-jetspeed/src/java/org/apache/jetspeed/portal/controllers CardPortletController.java
Date Wed, 25 Apr 2001 18:16:55 GMT


ingo@apache.org wrote:
> 
> ingo        01/04/25 09:56:07
> 
>   Modified:    src/java/org/apache/jetspeed/portal/controllers
>                         CardPortletController.java
>   Log:
>   [FIX] produce card controller links without "template=/Ecs.jsp" part.
>   To be removed again when Ecs is not used any more.
> 
>   Revision  Changes    Path
>   1.13      +6 -1      jakarta-jetspeed/src/java/org/apache/jetspeed/portal/controllers/CardPortletController.java
> 
>   Index: CardPortletController.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-jetspeed/src/java/org/apache/jetspeed/portal/controllers/CardPortletController.java,v
>   retrieving revision 1.12
>   retrieving revision 1.13
>   diff -u -r1.12 -r1.13
>   --- CardPortletController.java        2001/03/07 06:45:51     1.12
>   +++ CardPortletController.java        2001/04/25 16:56:05     1.13
>   @@ -81,7 +81,7 @@
>    or with an invalid value, use the first portlet (position 0)</li>
>    </p>
>    @author <a href="mailto:raphael@apache.org">Raphaël Luta</a>
>   -@version $Id: CardPortletController.java,v 1.12 2001/03/07 06:45:51 taylor Exp $
>   +@version $Id: CardPortletController.java,v 1.13 2001/04/25 16:56:05 ingo Exp $
>    */
>    public class CardPortletController extends AbstractPortletController {
> 
>   @@ -190,6 +190,11 @@
>            uri.addQueryData( rundata.getParameters() );
>            uri.removePathInfo( getParameterName() );
>            uri.removeQueryData( getParameterName() );
>   +
>   +        // <TEMP FIX>: As long as portlet pages are displayed via a special
template "Ecs",
>   +        //             this parameter needs to be removed from the uri
>   +        uri.removeQueryData( "template" );
>   +        // </TEMP FIX>
> 
>            if ( MetaData.DEFAULT_TITLE.equals( title ) ) {
>                uri.addPathInfo( getParameterName(), p.getPortletConfig().getPosition()
);
> 

I'm not sure I like this patch as this simply hides the problem rather than fix it
at the source. It's best to find out which component is setting the template to 
"/Ecs.jsp" and fix it because otherwise the error will crop up elsewhere...

--
Raphael Luta - raphael.luta@networks.groupvu.com
Vivendi Universal Networks - Paris

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org


Mime
View raw message