From reviews-return-92612-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Sep 16 19:06:30 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 9F0C31994B for ; Wed, 16 Sep 2020 19:06:30 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id BEA1C123637 for ; Wed, 16 Sep 2020 19:06:29 +0000 (UTC) Received: (qmail 38603 invoked by uid 500); 16 Sep 2020 19:06:29 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 38580 invoked by uid 500); 16 Sep 2020 19:06:29 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 38563 invoked by uid 99); 16 Sep 2020 19:06:29 -0000 Received: from spamproc1-he-fi.apache.org (HELO spamproc1-he-fi.apache.org) (95.217.134.168) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Sep 2020 19:06:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-fi.apache.org (ASF Mail Server at spamproc1-he-fi.apache.org) with ESMTP id F39D9C0422 for ; Wed, 16 Sep 2020 19:06:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-fi.apache.org X-Spam-Flag: NO X-Spam-Score: 1.611 X-Spam-Level: * X-Spam-Status: No, score=1.611 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.4, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([116.203.227.195]) by localhost (spamproc1-he-fi.apache.org [95.217.134.168]) (amavisd-new, port 10024) with ESMTP id Czof4j0Hhj9b for ; Wed, 16 Sep 2020 19:06:27 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id A100BBB802 for ; Wed, 16 Sep 2020 19:06:26 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id DB75B1603EC; Wed, 16 Sep 2020 19:06:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9212133608892104483==" MIME-Version: 1.0 Subject: Review Request 72875: Consolidated protobuf construction by the JNI scheduler driver. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Wed, 16 Sep 2020 19:06:24 -0000 Message-ID: <20200916190624.2546.83619@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72875/ X-Sender: Andrei Sekretenko Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============9212133608892104483== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72875/ ----------------------------------------------------------- Review request for mesos and Benjamin Mahler. Bugs: MESOS-10189 https://issues.apache.org/jira/browse/MESOS-10189 Repository: mesos Description ------- This patch converts the copy-pasted internals of numerous `construct<>()` specializations for protobufs into a single template. Diffs ----- src/java/jni/construct.cpp 8d8f76e4602e506faa635970f096d344a9ad8562 Diff: https://reviews.apache.org/r/72875/diff/1/ Testing ------- Thanks, Andrei Sekretenko --===============9212133608892104483==--