From reviews-return-92611-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Sep 16 19:05:36 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by minotaur.apache.org (Postfix) with ESMTP id BA95D19949 for ; Wed, 16 Sep 2020 19:05:35 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 7B77942FF6 for ; Wed, 16 Sep 2020 19:05:35 +0000 (UTC) Received: (qmail 37964 invoked by uid 500); 16 Sep 2020 19:05:35 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 37929 invoked by uid 500); 16 Sep 2020 19:05:35 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37916 invoked by uid 99); 16 Sep 2020 19:05:34 -0000 Received: from spamproc1-he-fi.apache.org (HELO spamproc1-he-fi.apache.org) (95.217.134.168) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Sep 2020 19:05:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-fi.apache.org (ASF Mail Server at spamproc1-he-fi.apache.org) with ESMTP id 856C3C041E for ; Wed, 16 Sep 2020 19:05:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-fi.apache.org X-Spam-Flag: NO X-Spam-Score: 1.861 X-Spam-Level: * X-Spam-Status: No, score=1.861 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.4, SPF_NONE=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([116.203.227.195]) by localhost (spamproc1-he-fi.apache.org [95.217.134.168]) (amavisd-new, port 10024) with ESMTP id vvwhNB4YtSVf for ; Wed, 16 Sep 2020 19:05:32 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id A1E937F993 for ; Wed, 16 Sep 2020 19:05:32 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id A87211603EC; Wed, 16 Sep 2020 19:05:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2216986521842017491==" MIME-Version: 1.0 Subject: Review Request 72874: Added offer constraints to `MesosSchedulerDriver::updateFramework()`. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Wed, 16 Sep 2020 19:05:30 -0000 Message-ID: <20200916190530.13989.27195@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72874/ X-Sender: Andrei Sekretenko Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============2216986521842017491== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72874/ ----------------------------------------------------------- Review request for mesos and Benjamin Mahler. Bugs: MESOS-10189 https://issues.apache.org/jira/browse/MESOS-10189 Repository: mesos Description ------- This patch adds an ability to set or clear V0 framework's offer constraints via the C++ V0 scheduler driver. Diffs ----- include/mesos/scheduler.hpp 61cc846a03d2980f18fa66df1de196edc5cb4457 src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 1817bbafc4ce65ee5e58eb787e71c6d06481a32f src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 256632a9589c8573cbe0f0aeb39ee6cb1e4b3256 src/sched/sched.cpp 768ce7d4074a1ea50b656717e25be6c38a423368 src/tests/master/update_framework_tests.cpp d6c45f60cf50739aacbb507e99a5163a6cb3d1a0 src/tests/scheduler_driver_tests.cpp 63d7a3ba9a98d8c343324f5ad85f0b4d0cc033be Diff: https://reviews.apache.org/r/72874/diff/1/ Testing ------- Thanks, Andrei Sekretenko --===============2216986521842017491==--