From reviews-return-92570-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Sep 10 00:04:13 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id E32A9197E3 for ; Thu, 10 Sep 2020 00:04:12 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 972B812219E for ; Thu, 10 Sep 2020 00:04:12 +0000 (UTC) Received: (qmail 57389 invoked by uid 500); 10 Sep 2020 00:04:12 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 57364 invoked by uid 500); 10 Sep 2020 00:04:12 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 57351 invoked by uid 99); 10 Sep 2020 00:04:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Sep 2020 00:04:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5462EC03CE for ; Thu, 10 Sep 2020 00:04:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.612 X-Spam-Level: * X-Spam-Status: No, score=1.612 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.4, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id WC5lp0TL3uyD for ; Thu, 10 Sep 2020 00:04:10 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 7FFB37F5C7 for ; Thu, 10 Sep 2020 00:04:09 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 40B0D1603E3; Thu, 10 Sep 2020 00:04:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0913236541627136313==" MIME-Version: 1.0 Subject: Re: Review Request 72841: Added offer constraints to the `GetFrameworks` protobuf. From: Benjamin Mahler To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Thu, 10 Sep 2020 00:04:09 -0000 Message-ID: <20200910000409.13989.26925@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72841/ X-Sender: Benjamin Mahler X-ReviewBoard-ShipIt: 1 References: <20200907194547.13941.25411@reviews-vm-he-fi.apache.org> In-Reply-To: <20200907194547.13941.25411@reviews-vm-he-fi.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============0913236541627136313== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72841/#review221838 ----------------------------------------------------------- Ship it! Ship It! - Benjamin Mahler On Sept. 7, 2020, 7:45 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72841/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2020, 7:45 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10179 > https://issues.apache.org/jira/browse/MESOS-10179 > > > Repository: mesos > > > Description > ------- > > Added offer constraints to the `GetFrameworks` protobuf. > > > Diffs > ----- > > include/mesos/master/master.proto 021dadcea026da41347b3aaee5ddd12f4f14fa29 > include/mesos/v1/master/master.proto 488fe294e8bfe8e0c6fc23c88f06c0d41169b96d > > > Diff: https://reviews.apache.org/r/72841/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > > --===============0913236541627136313==--