From reviews-return-92558-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Sep 9 07:46:32 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 19CEB193D5 for ; Wed, 9 Sep 2020 07:46:32 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id C2F03121B6A for ; Wed, 9 Sep 2020 07:46:31 +0000 (UTC) Received: (qmail 74305 invoked by uid 500); 9 Sep 2020 07:46:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 74278 invoked by uid 500); 9 Sep 2020 07:46:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 74255 invoked by uid 99); 9 Sep 2020 07:46:30 -0000 Received: from spamproc1-he-fi.apache.org (HELO spamproc1-he-fi.apache.org) (95.217.134.168) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Sep 2020 07:46:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-fi.apache.org (ASF Mail Server at spamproc1-he-fi.apache.org) with ESMTP id E68C1C0464 for ; Wed, 9 Sep 2020 07:46:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-fi.apache.org X-Spam-Flag: NO X-Spam-Score: 1.612 X-Spam-Level: * X-Spam-Status: No, score=1.612 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.4, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([209.188.14.141]) by localhost (spamproc1-he-fi.apache.org [95.217.134.168]) (amavisd-new, port 10024) with ESMTP id QHoAkFiez8xA for ; Wed, 9 Sep 2020 07:46:28 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id B232E7F5C7 for ; Wed, 9 Sep 2020 07:46:27 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 9F99F1603DA; Wed, 9 Sep 2020 07:46:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2234981247614209007==" MIME-Version: 1.0 Subject: Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. From: Mesos Reviewbot To: Benjamin Mahler Cc: Andrei Sekretenko , Mesos Reviewbot , mesos Date: Wed, 09 Sep 2020 07:46:26 -0000 Message-ID: <20200909074626.2546.25475@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72843/ X-Sender: Mesos Reviewbot References: <20200908145731.13941.63844@reviews-vm-he-fi.apache.org> In-Reply-To: <20200908145731.13941.63844@reviews-vm-he-fi.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============2234981247614209007== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72843/#review221824 ----------------------------------------------------------- Patch looks great! Reviews applied: [72843] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Sept. 8, 2020, 2:57 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72843/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2020, 2:57 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Now that synchronous authorization requires the authorizer to keep > object approvers up-to-date by the authorizer, batched processing > of readonly requests in the Master no longer intorduces an additional > delay into propagation of permission changes. > > > Diffs > ----- > > src/master/http.cpp f34ea54ec48065f526327252aa10c6d917a96601 > > > Diff: https://reviews.apache.org/r/72843/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > > --===============2234981247614209007==--