From reviews-return-92536-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Sep 4 06:40:18 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 0AD8019F95 for ; Fri, 4 Sep 2020 06:40:18 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id AF066121BBC for ; Fri, 4 Sep 2020 06:40:17 +0000 (UTC) Received: (qmail 53114 invoked by uid 500); 4 Sep 2020 06:40:17 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 53084 invoked by uid 500); 4 Sep 2020 06:40:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 53070 invoked by uid 99); 4 Sep 2020 06:40:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Sep 2020 06:40:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 54465C00C9 for ; Fri, 4 Sep 2020 06:40:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.614 X-Spam-Level: * X-Spam-Status: No, score=1.614 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.4, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rwzdnM9Opbpb for ; Fri, 4 Sep 2020 06:40:15 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 9B6D0BC255 for ; Fri, 4 Sep 2020 06:40:14 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id C6E411603B4; Fri, 4 Sep 2020 06:40:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6996808895311585930==" MIME-Version: 1.0 Subject: Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. From: Greg Mann To: Qian Zhang Cc: Mesos Reviewbot , Greg Mann , mesos Date: Fri, 04 Sep 2020 06:40:13 -0000 Message-ID: <20200904064013.2546.38408@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72806/ X-Sender: Greg Mann References: <20200904030430.2546.61628@reviews-vm-he-fi.apache.org> In-Reply-To: <20200904030430.2546.61628@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/tests/containerizer/volume_csi_isolator_tests.cpp Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============6996808895311585930== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 4, 2020, 3:04 a.m., Qian Zhang wrote: > > src/tests/containerizer/volume_csi_isolator_tests.cpp > > Lines 1676-1689 (patched) > > > > > > Could you please elaborate a bit on why we need to publish the volume here? I think during recovery volume manager will publish the volume internally, right? And why does `targetPath` not exist when publishing volume succeeds? I ended up removing this test since I wasn't able to synchronize it correctly. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72806/#review221801 ----------------------------------------------------------- On Sept. 4, 2020, 6:39 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72806/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2020, 6:39 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Added tests for 'volume/csi' isolator recovery. > > > Diffs > ----- > > src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72806/diff/8/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"` > > > Thanks, > > Greg Mann > > --===============6996808895311585930==--