From reviews-return-92530-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Sep 3 15:56:27 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 013BA1A3A8 for ; Thu, 3 Sep 2020 15:56:27 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id A746F121DAE for ; Thu, 3 Sep 2020 15:56:26 +0000 (UTC) Received: (qmail 45409 invoked by uid 500); 3 Sep 2020 15:56:26 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 45384 invoked by uid 500); 3 Sep 2020 15:56:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 45362 invoked by uid 99); 3 Sep 2020 15:56:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2020 15:56:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8F9B91A3468 for ; Thu, 3 Sep 2020 15:56:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.612 X-Spam-Level: * X-Spam-Status: No, score=1.612 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.4, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 0XNI-Ce7zZOa for ; Thu, 3 Sep 2020 15:56:24 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id C8D447F98B for ; Thu, 3 Sep 2020 15:56:23 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 6DCF21603B4; Thu, 3 Sep 2020 15:56:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2754542283256632747==" MIME-Version: 1.0 Subject: Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Thu, 03 Sep 2020 15:56:23 -0000 Message-ID: <20200903155623.13941.26875@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72824/ X-Sender: Andrei Sekretenko References: <20200902140853.2546.14003@reviews-vm-he-fi.apache.org> In-Reply-To: <20200902140853.2546.14003@reviews-vm-he-fi.apache.org> Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============2754542283256632747== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72824/ ----------------------------------------------------------- (Updated Sept. 3, 2020, 5:56 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Adjusted comments and logging. Bugs: MESOS-10166 https://issues.apache.org/jira/browse/MESOS-10166 Repository: mesos Description ------- This patch makes the UPDATE_FRAMEWORK call avoid sending the `UpdatedFrameworkMessage` to agents and the `FRAMEWORK_UPDATED` event to V1 API subscribers when the FrameworkInfo is not changed by the call. Diffs (updated) ----- src/master/master.cpp 02723296e569fac9d553b1494a5ca7daa6ef9aa4 Diff: https://reviews.apache.org/r/72824/diff/5/ Changes: https://reviews.apache.org/r/72824/diff/4-5/ Testing ------- Thanks, Andrei Sekretenko --===============2754542283256632747==--