From reviews-return-92526-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Sep 3 15:29:25 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by minotaur.apache.org (Postfix) with ESMTP id 219631A295 for ; Thu, 3 Sep 2020 15:29:25 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 1F28D62A81 for ; Thu, 3 Sep 2020 15:29:24 +0000 (UTC) Received: (qmail 90743 invoked by uid 500); 3 Sep 2020 15:29:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 90717 invoked by uid 500); 3 Sep 2020 15:29:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 90702 invoked by uid 99); 3 Sep 2020 15:29:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2020 15:29:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 89BBE1813B0 for ; Thu, 3 Sep 2020 15:29:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.863 X-Spam-Level: * X-Spam-Status: No, score=1.863 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.4, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id AbXD2t0rIeMD for ; Thu, 3 Sep 2020 15:29:21 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 8E77BBC24D for ; Thu, 3 Sep 2020 15:29:20 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 8D7741603B4; Thu, 3 Sep 2020 15:29:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1184673447509901663==" MIME-Version: 1.0 Subject: Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Thu, 03 Sep 2020 15:29:19 -0000 Message-ID: <20200903152919.2546.40086@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72822/ X-Sender: Andrei Sekretenko References: <20200901194533.2546.75938@reviews-vm-he-fi.apache.org> In-Reply-To: <20200901194533.2546.75938@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/common/type_utils_differencers.hpp Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============1184673447509901663== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72822/ ----------------------------------------------------------- (Updated Sept. 3, 2020, 5:29 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- - converted `FrameworkInfoDifferencer` into a function - renamed the header Bugs: MESOS-10166 https://issues.apache.org/jira/browse/MESOS-10166 Repository: mesos Description ------- This patch extracts the code that performs `FrameworkInfo` comparison via protobuf `MessageDifferencer` from the framework update tests into a set of general-purpose methods. Diffs (updated) ----- include/mesos/type_utils.hpp da9fd9694b08827b968514b4b078097c912640c8 include/mesos/v1/mesos.hpp d8304f10d6ac6bbcf014e515e0bfd77a2b96e138 src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63 src/common/type_utils.cpp bb437844183688e7f69eb0874d87efe5a7d6daf2 src/common/type_utils_differencers.hpp PRE-CREATION src/tests/master/update_framework_tests.cpp d2a63b696e976d9e3c729390d80f33180ab4aa1c src/v1/mesos.cpp c2fb528d323899c42b32c0713b38ebf6f909dd29 Diff: https://reviews.apache.org/r/72822/diff/4/ Changes: https://reviews.apache.org/r/72822/diff/3-4/ Testing ------- Thanks, Andrei Sekretenko --===============1184673447509901663==--